-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
f/aws_organizations_policy:support for tags #15316
f/aws_organizations_policy:support for tags #15316
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @nikhil-goenka, thank you for this PR! It's looking pretty great, just note you'll need to run go fmt
and add the new test to aws/resource_aws_organizations_test.go
within the "Policy"
test case section to remedy the CI checks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks @nikhil-goenka 🚀
Tests passing except for known failure in TestAccAWSOrganizations_serial/Policy/Type_Backup
Output of acceptance tests:
--- PASS: TestAccAWSOrganizations_serial/Organization (299.23s)
--- PASS: TestAccAWSOrganizations_serial/Organization/basic (24.35s)
--- PASS: TestAccAWSOrganizations_serial/Organization/AwsServiceAccessPrincipals (57.70s)
--- PASS: TestAccAWSOrganizations_serial/Organization/EnabledPolicyTypes (153.75s)
--- PASS: TestAccAWSOrganizations_serial/Organization/FeatureSet (19.60s)
--- PASS: TestAccAWSOrganizations_serial/Organization/DataSource (43.84s)
--- PASS: TestAccAWSOrganizations_serial/Account (0.00s)
--- SKIP: TestAccAWSOrganizations_serial/Account/basic (0.00s)
--- SKIP: TestAccAWSOrganizations_serial/Account/ParentId (0.00s)
--- SKIP: TestAccAWSOrganizations_serial/Account/Tags (0.00s)
--- PASS: TestAccAWSOrganizations_serial/OrganizationalUnit (65.23s)
--- PASS: TestAccAWSOrganizations_serial/OrganizationalUnit/basic (23.85s)
--- PASS: TestAccAWSOrganizations_serial/OrganizationalUnit/Name (41.38s)
--- PASS: TestAccAWSOrganizations_serial/OrganizationalUnits (0.00s)
--- PASS: TestAccAWSOrganizations_serial/OrganizationalUnits/DataSource (21.95s)
--- FAIL: TestAccAWSOrganizations_serial/Policy (280.93s)
--- PASS: TestAccAWSOrganizations_serial/Policy/concurrent (30.34s)
--- PASS: TestAccAWSOrganizations_serial/Policy/Description (40.31s)
--- PASS: TestAccAWSOrganizations_serial/Policy/Tags (74.96s)
--- PASS: TestAccAWSOrganizations_serial/Policy/Type_AI_OPT_OUT (22.35s)
--- FAIL: TestAccAWSOrganizations_serial/Policy/Type_Backup (10.29s) -- current failure in master
--- PASS: TestAccAWSOrganizations_serial/Policy/Type_SCP (38.88s)
--- PASS: TestAccAWSOrganizations_serial/Policy/Type_Tag (22.21s)
--- PASS: TestAccAWSOrganizations_serial/Policy/basic (41.59s)
--- PASS: TestAccAWSOrganizations_serial/PolicyAttachment (113.89s)
--- PASS: TestAccAWSOrganizations_serial/PolicyAttachment/Account (50.50s)
--- PASS: TestAccAWSOrganizations_serial/PolicyAttachment/OrganizationalUnit (32.60s)
--- PASS: TestAccAWSOrganizations_serial/PolicyAttachment/Root (30.79s)
This has been released in version 3.8.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks! |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
Community Note
Relates OR Closes #15168
Release note for CHANGELOG:
Output from acceptance testing: