r/storagegateway_tape_pool - add new resource

[DrFaust92]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #10723

Release note for CHANGELOG:

resource_aws_storagegateway_tape_pool: add new resource

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSStorageGatewayTapePool_'
--- PASS: TestAccAWSStorageGatewayTapePool_basic (40.65s)
--- PASS: TestAccAWSStorageGatewayTapePool_retention (39.87s)
--- PASS: TestAccAWSStorageGatewayTapePool_tags (99.66s)
--- PASS: TestAccAWSStorageGatewayTapePool_disappears (29.18s)

[DrFaust92]

Thanks @ewbankkit, also fixed some post test delete issues.

--- PASS: TestAccAWSStorageGatewayTapePool_disappears (34.21s)
--- PASS: TestAccAWSStorageGatewayTapePool_retention (48.40s)
--- PASS: TestAccAWSStorageGatewayTapePool_basic (48.84s)
--- PASS: TestAccAWSStorageGatewayTapePool_tags (123.17s)

[ewbankkit]

LGTM.

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSStorageGatewayTapePool_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSStorageGatewayTapePool_ -timeout 120m
=== RUN   TestAccAWSStorageGatewayTapePool_basic
=== PAUSE TestAccAWSStorageGatewayTapePool_basic
=== RUN   TestAccAWSStorageGatewayTapePool_retention
=== PAUSE TestAccAWSStorageGatewayTapePool_retention
=== RUN   TestAccAWSStorageGatewayTapePool_tags
=== PAUSE TestAccAWSStorageGatewayTapePool_tags
=== RUN   TestAccAWSStorageGatewayTapePool_disappears
=== PAUSE TestAccAWSStorageGatewayTapePool_disappears
=== CONT  TestAccAWSStorageGatewayTapePool_basic
=== CONT  TestAccAWSStorageGatewayTapePool_disappears
=== CONT  TestAccAWSStorageGatewayTapePool_tags
=== CONT  TestAccAWSStorageGatewayTapePool_retention
--- PASS: TestAccAWSStorageGatewayTapePool_disappears (18.51s)
--- PASS: TestAccAWSStorageGatewayTapePool_basic (26.50s)
--- PASS: TestAccAWSStorageGatewayTapePool_retention (27.10s)
--- PASS: TestAccAWSStorageGatewayTapePool_tags (55.03s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	55.084s

[breathingdust]

LGTM 🚀 Thanks @DrFaust92

Verified Acceptance Tests in Commercial (us-west-2)

make testacc TESTARGS='-run=TestAccAWSStorageGatewayTapePool_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSStorageGatewayTapePool_ -timeout 120m
=== RUN   TestAccAWSStorageGatewayTapePool_basic
=== PAUSE TestAccAWSStorageGatewayTapePool_basic
=== RUN   TestAccAWSStorageGatewayTapePool_retention
=== PAUSE TestAccAWSStorageGatewayTapePool_retention
=== RUN   TestAccAWSStorageGatewayTapePool_tags
=== PAUSE TestAccAWSStorageGatewayTapePool_tags
=== RUN   TestAccAWSStorageGatewayTapePool_disappears
=== PAUSE TestAccAWSStorageGatewayTapePool_disappears
=== CONT  TestAccAWSStorageGatewayTapePool_basic
=== CONT  TestAccAWSStorageGatewayTapePool_tags
=== CONT  TestAccAWSStorageGatewayTapePool_retention
=== CONT  TestAccAWSStorageGatewayTapePool_disappears
--- PASS: TestAccAWSStorageGatewayTapePool_disappears (11.63s)
--- PASS: TestAccAWSStorageGatewayTapePool_retention (16.05s)
--- PASS: TestAccAWSStorageGatewayTapePool_basic (16.31s)
--- PASS: TestAccAWSStorageGatewayTapePool_tags (38.87s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	40.314s

Verified Acceptance Tests in GovCloud (us-gov-west-1)

make testacc TESTARGS='-run=TestAccAWSStorageGatewayTapePool_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSStorageGatewayTapePool_ -timeout 120m
=== RUN   TestAccAWSStorageGatewayTapePool_basic
=== PAUSE TestAccAWSStorageGatewayTapePool_basic
=== RUN   TestAccAWSStorageGatewayTapePool_retention
=== PAUSE TestAccAWSStorageGatewayTapePool_retention
=== RUN   TestAccAWSStorageGatewayTapePool_tags
=== PAUSE TestAccAWSStorageGatewayTapePool_tags
=== RUN   TestAccAWSStorageGatewayTapePool_disappears
=== PAUSE TestAccAWSStorageGatewayTapePool_disappears
=== CONT  TestAccAWSStorageGatewayTapePool_basic
=== CONT  TestAccAWSStorageGatewayTapePool_disappears
=== CONT  TestAccAWSStorageGatewayTapePool_tags
=== CONT  TestAccAWSStorageGatewayTapePool_retention
--- PASS: TestAccAWSStorageGatewayTapePool_disappears (8.66s)
2020/10/29 10:51:45 [DEBUG] Trying to get account information via sts:GetCallerIdentity
--- PASS: TestAccAWSStorageGatewayTapePool_retention (12.12s)
--- PASS: TestAccAWSStorageGatewayTapePool_basic (12.67s)
--- PASS: TestAccAWSStorageGatewayTapePool_tags (28.68s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	30.118s

[ghost]

This has been released in version 3.13.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!