f/aws_sfn_state_machine: enable tracing config #15434

nikhil-goenka · 2020-10-01T18:38:21Z

Community Note

Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #15430.
Closes #12506.
Closes #18614.
Closes #18615.

Release note for CHANGELOG:

Output from acceptance testing:

make testacc TESTARGS='-run=TestAccAWSSfnStateMachine_Tracing_Config'
=== RUN   TestAccAWSSfnStateMachine_Tracing_Config
=== PAUSE TestAccAWSSfnStateMachine_Tracing_Config
=== CONT  TestAccAWSSfnStateMachine_Tracing_Config
--- PASS: TestAccAWSSfnStateMachine_Tracing_Config (168.47s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	171.227s
...

nikhil-goenka · 2020-10-01T19:01:36Z

aws/resource_aws_sfn_state_machine_test.go

@@ -359,3 +392,71 @@ EOF
 }
 `, rName, tag1Key, tag1Value, tag2Key, tag2Value)
 }
+
+func testAccAWSSfnStateMachineConfigTracingConfigEnable(rName string) string {


@gdavison : is there some different command to run to format this ? Got terrafmt error, got the same thing last time as well.

lu-liu-rft · 2021-01-26T14:56:09Z

Hi any update on this feature?

lu-liu-rft · 2021-04-15T09:58:03Z

OMG Does this mean 'X-Ray tracing enable' config will be supported for StepFunction very soon?

nikhil-goenka · 2021-04-15T09:59:13Z

OMG Does this mean 'X-Ray tracing enable' config will be supported for StepFunction very soon?

As soon as it get reviewed and merged

nikhil-goenka · 2021-04-20T05:42:25Z

@bflad @gdavison @ewbankkit
Hi Guys,
hope you are doing well, can we please get this reviewed and merged if all looks good.

Acceptance test output: % make testacc TEST=./aws TESTARGS='-run=TestAccAWSSfnStateMachine_createUpdate' ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSSfnStateMachine_createUpdate -timeout 180m === RUN TestAccAWSSfnStateMachine_createUpdate === PAUSE TestAccAWSSfnStateMachine_createUpdate === CONT TestAccAWSSfnStateMachine_createUpdate --- PASS: TestAccAWSSfnStateMachine_createUpdate (107.22s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 110.582s

…uration after Update. Acceptance test output: % make testacc TEST=./aws TESTARGS='-run=TestAccAWSSfnStateMachine_TracingConfiguration\|TestAccAWSSfnStateMachine_expressUpdate' ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSSfnStateMachine_TracingConfiguration\|TestAccAWSSfnStateMachine_expressUpdate -timeout 180m === RUN TestAccAWSSfnStateMachine_expressUpdate === PAUSE TestAccAWSSfnStateMachine_expressUpdate === RUN TestAccAWSSfnStateMachine_TracingConfiguration === PAUSE TestAccAWSSfnStateMachine_TracingConfiguration === CONT TestAccAWSSfnStateMachine_expressUpdate === CONT TestAccAWSSfnStateMachine_TracingConfiguration --- PASS: TestAccAWSSfnStateMachine_TracingConfiguration (114.16s) --- PASS: TestAccAWSSfnStateMachine_expressUpdate (119.29s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 122.419s

…uration after Update. Acceptance test output: % make testacc TEST=./aws TESTARGS='-run=TestAccAWSSfnStateMachine_expressLoggingConfiguration' ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSSfnStateMachine_expressLoggingConfiguration -timeout 180m === RUN TestAccAWSSfnStateMachine_expressLoggingConfiguration === PAUSE TestAccAWSSfnStateMachine_expressLoggingConfiguration === CONT TestAccAWSSfnStateMachine_expressLoggingConfiguration --- PASS: TestAccAWSSfnStateMachine_expressLoggingConfiguration (95.94s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 99.367s

ewbankkit

LGTM 🚀.

Commercial

% make testacc TEST=./aws TESTARGS='-run=TestAccAWSSfnStateMachine_'                           
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSSfnStateMachine_ -timeout 180m
=== RUN   TestAccAWSSfnStateMachine_createUpdate
=== PAUSE TestAccAWSSfnStateMachine_createUpdate
=== RUN   TestAccAWSSfnStateMachine_expressUpdate
=== PAUSE TestAccAWSSfnStateMachine_expressUpdate
=== RUN   TestAccAWSSfnStateMachine_standardUpdate
=== PAUSE TestAccAWSSfnStateMachine_standardUpdate
=== RUN   TestAccAWSSfnStateMachine_tags
=== PAUSE TestAccAWSSfnStateMachine_tags
=== RUN   TestAccAWSSfnStateMachine_TracingConfiguration
=== PAUSE TestAccAWSSfnStateMachine_TracingConfiguration
=== RUN   TestAccAWSSfnStateMachine_disappears
=== PAUSE TestAccAWSSfnStateMachine_disappears
=== RUN   TestAccAWSSfnStateMachine_expressLoggingConfiguration
=== PAUSE TestAccAWSSfnStateMachine_expressLoggingConfiguration
=== CONT  TestAccAWSSfnStateMachine_createUpdate
=== CONT  TestAccAWSSfnStateMachine_TracingConfiguration
=== CONT  TestAccAWSSfnStateMachine_expressLoggingConfiguration
=== CONT  TestAccAWSSfnStateMachine_standardUpdate
=== CONT  TestAccAWSSfnStateMachine_tags
=== CONT  TestAccAWSSfnStateMachine_disappears
=== CONT  TestAccAWSSfnStateMachine_expressUpdate
--- PASS: TestAccAWSSfnStateMachine_expressUpdate (82.85s)
--- PASS: TestAccAWSSfnStateMachine_standardUpdate (86.95s)
--- PASS: TestAccAWSSfnStateMachine_createUpdate (91.58s)
--- PASS: TestAccAWSSfnStateMachine_disappears (97.47s)
--- PASS: TestAccAWSSfnStateMachine_expressLoggingConfiguration (150.39s)
--- PASS: TestAccAWSSfnStateMachine_TracingConfiguration (153.24s)
--- PASS: TestAccAWSSfnStateMachine_tags (158.60s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	161.891s

GovCloud

% make testacc TEST=./aws TESTARGS='-run=TestAccAWSSfnStateMachine_'   
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSSfnStateMachine_ -timeout 180m
=== RUN   TestAccAWSSfnStateMachine_createUpdate
=== PAUSE TestAccAWSSfnStateMachine_createUpdate
=== RUN   TestAccAWSSfnStateMachine_expressUpdate
=== PAUSE TestAccAWSSfnStateMachine_expressUpdate
=== RUN   TestAccAWSSfnStateMachine_standardUpdate
=== PAUSE TestAccAWSSfnStateMachine_standardUpdate
=== RUN   TestAccAWSSfnStateMachine_tags
=== PAUSE TestAccAWSSfnStateMachine_tags
=== RUN   TestAccAWSSfnStateMachine_TracingConfiguration
=== PAUSE TestAccAWSSfnStateMachine_TracingConfiguration
=== RUN   TestAccAWSSfnStateMachine_disappears
=== PAUSE TestAccAWSSfnStateMachine_disappears
=== RUN   TestAccAWSSfnStateMachine_expressLoggingConfiguration
=== PAUSE TestAccAWSSfnStateMachine_expressLoggingConfiguration
=== CONT  TestAccAWSSfnStateMachine_createUpdate
=== CONT  TestAccAWSSfnStateMachine_TracingConfiguration
=== CONT  TestAccAWSSfnStateMachine_standardUpdate
=== CONT  TestAccAWSSfnStateMachine_expressLoggingConfiguration
=== CONT  TestAccAWSSfnStateMachine_tags
=== CONT  TestAccAWSSfnStateMachine_disappears
=== CONT  TestAccAWSSfnStateMachine_expressUpdate
--- PASS: TestAccAWSSfnStateMachine_disappears (59.21s)
--- PASS: TestAccAWSSfnStateMachine_standardUpdate (107.93s)
--- PASS: TestAccAWSSfnStateMachine_tags (109.99s)
--- PASS: TestAccAWSSfnStateMachine_createUpdate (111.59s)
--- PASS: TestAccAWSSfnStateMachine_expressLoggingConfiguration (111.89s)
--- PASS: TestAccAWSSfnStateMachine_expressUpdate (114.22s)
--- PASS: TestAccAWSSfnStateMachine_TracingConfiguration (117.20s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	120.135s

ewbankkit · 2021-05-05T19:17:54Z

@nikhil-goenka Thanks for the contribution 👏.
I took the liberty of tweaking the configuration to be tracing_configuration (and fixed the acceptance tests) in order to get this one merged quicker.

ghost · 2021-05-07T00:08:52Z

This has been released in version 3.39.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

github-actions · 2021-06-07T02:34:37Z

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

nikhil-goenka requested a review from a team October 1, 2020 18:38

ghost added size/M Managed by automation to categorize the size of a PR. service/sfn Issues and PRs that pertain to the sfn service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Oct 1, 2020

github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Oct 1, 2020

ghost added the documentation Introduces or discusses updates to documentation. label Oct 1, 2020

nikhil-goenka commented Oct 1, 2020

View reviewed changes

Base automatically changed from master to main January 23, 2021 00:59

breathingdust requested a review from a team as a code owner January 23, 2021 00:59

ghost added the provider Pertains to the provider itself, rather than any interaction with AWS. label Apr 15, 2021

ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label May 5, 2021

nikhil-goenka added 9 commits May 5, 2021 08:58

f/aws_sfn_state_machine: enable tracing config

b087a21

f/aws_sfn_state_machine: enable tracing config

ea5da4e

f/aws_sfn_state_machine: enable tracing config

9f4c80b

f/aws_sfn_state_machine

c331c78

f/aws_sfn_state_machine

7003365

f/aws_sfn_state_machine

79645a7

f/aws_sfn_state_machine

ef8e716

f/aws_securityhub_member: email is optional variable

4d7fc93

f/aws_securityhub_member: email is optional variable

c498d3a

ewbankkit force-pushed the f/aws_sfn_state_machine-tracing-config branch from a3ee422 to c498d3a Compare May 5, 2021 13:03

ewbankkit mentioned this pull request May 5, 2021

tests/resource/aws_sfn_state_machine: Consistent Update Test Failures #18615

Closed

ewbankkit self-assigned this May 5, 2021

ewbankkit added 3 commits May 5, 2021 09:17

Add CHANGELOG entry.

df00e4e

r/aws_sfn_state_machine: 'tracing_config' -> 'tracing_configuration'.

b6e7c9b

ghost added size/XXL Managed by automation to categorize the size of a PR. and removed size/M Managed by automation to categorize the size of a PR. labels May 5, 2021

ewbankkit approved these changes May 5, 2021

View reviewed changes

ewbankkit merged commit 6a0fd81 into hashicorp:main May 5, 2021

github-actions bot added this to the v3.39.0 milestone May 5, 2021

nikhil-goenka deleted the f/aws_sfn_state_machine-tracing-config branch May 7, 2021 12:10

github-actions bot locked as resolved and limited conversation to collaborators Jun 7, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

f/aws_sfn_state_machine: enable tracing config #15434

f/aws_sfn_state_machine: enable tracing config #15434

nikhil-goenka commented Oct 1, 2020 •

edited by ewbankkit

Loading

nikhil-goenka Oct 1, 2020 •

edited

Loading

lu-liu-rft commented Jan 26, 2021

lu-liu-rft commented Apr 15, 2021

nikhil-goenka commented Apr 15, 2021

nikhil-goenka commented Apr 20, 2021 •

edited

Loading

ewbankkit left a comment

ewbankkit commented May 5, 2021

ghost commented May 7, 2021

github-actions bot commented Jun 7, 2021

f/aws_sfn_state_machine: enable tracing config #15434

f/aws_sfn_state_machine: enable tracing config #15434

Conversation

nikhil-goenka commented Oct 1, 2020 • edited by ewbankkit Loading

Community Note

nikhil-goenka Oct 1, 2020 • edited Loading

Choose a reason for hiding this comment

lu-liu-rft commented Jan 26, 2021

lu-liu-rft commented Apr 15, 2021

nikhil-goenka commented Apr 15, 2021

nikhil-goenka commented Apr 20, 2021 • edited Loading

ewbankkit left a comment

Choose a reason for hiding this comment

Commercial

GovCloud

ewbankkit commented May 5, 2021

ghost commented May 7, 2021

github-actions bot commented Jun 7, 2021

nikhil-goenka commented Oct 1, 2020 •

edited by ewbankkit

Loading

nikhil-goenka Oct 1, 2020 •

edited

Loading

nikhil-goenka commented Apr 20, 2021 •

edited

Loading