Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws_config_remediation_configuration: No support for "automatic" remediation #15491

Closed
dexterlakin opened this issue Oct 5, 2020 · 23 comments · Fixed by #18079
Closed

aws_config_remediation_configuration: No support for "automatic" remediation #15491

dexterlakin opened this issue Oct 5, 2020 · 23 comments · Fixed by #18079
Assignees
Labels
enhancement Requests to existing resources that expand the functionality or scope. good first issue Call to action for new contributors looking for a place to start. Smaller or straightforward issues. service/configservice Issues and PRs that pertain to the configservice service.
Milestone

Comments

@dexterlakin
Copy link

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

I'd like to be able to configure a aws_config_remediation_configuration resource of type "automatic", see: https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-config-remediationconfiguration.html

New or Affected Resource(s)

  • aws_config_remediation_configuration

Potential Terraform Configuration

resource "aws_config_remediation_configuration" "this" {
  type = automatic
  config_rule_name = aws_config_config_rule.this.name
  resource_type    = "AWS::S3::Bucket"
  target_type      = "SSM_DOCUMENT"
  target_id        = "AWS-EnableS3BucketEncryption"
  target_version   = "1"

  parameter {
    name         = "AutomationAssumeRole"
    static_value = "arn:aws:iam::875924563244:role/security_config"
  }
  parameter {
    name           = "BucketName"
    resource_value = "RESOURCE_ID"
  }
  parameter {
    name         = "SSEAlgorithm"
    static_value = "AES256"
  }
}```

### References

* https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-config-remediationconfiguration.html
@dexterlakin dexterlakin added the enhancement Requests to existing resources that expand the functionality or scope. label Oct 5, 2020
@ghost ghost added the service/configservice Issues and PRs that pertain to the configservice service. label Oct 5, 2020
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Oct 5, 2020
@anGie44 anGie44 added good first issue Call to action for new contributors looking for a place to start. Smaller or straightforward issues. and removed needs-triage Waiting for first response or review from a maintainer. labels Oct 5, 2020
@anGie44
Copy link
Contributor

anGie44 commented Oct 5, 2020

Hi @dexterlakin, thank you for creating this issue! Just dropping a note here that in an effort to follow the AWS API, this new argument could be configured as a boolean value instead as the configservice.RemediationConfiguration{} struct specifies the Automatic field as a *bool.

@j-pedrosa
Copy link

How is this going so far?
I need this "auto remediation" to have a very helpful aws-config setup. =)

@IronCore864
Copy link

+1
I'm so frustrated.

@japrakash-contino
Copy link

Is there any update on this ticket? I am also looking for this feature and without it there is no use of it.

@alekov87
Copy link

Any ETA for the fix?

@halfinhalfout
Copy link

FWIW, you can manually toggle a Remediation between Manual and Automatic via the AWS Console (and probably the AWS CLI or API) after aws_config_remediation_configuration creates the Remediation. The AWS TF provider doesn't recognize it as a change. Clearly, that's not ideal, as we want whether the Remediation is Automatic or Manual configured in TF code. However, this is a work-around for enabling Automatic Remediation in the mean-time.

This is what I've seen while using versions 3.10.0 & 3.25.0 of the AWS Provider.

@ctrawick
Copy link
Contributor

ctrawick commented Mar 13, 2021

Any ETA for the fix?

There are multiple pull requests fixing this issue. Please get your friends to 👍 this issue so it can be prioritized for release. Once prioritized, I've seen stuff like this get mainlined within a week or two.

@unknowncoder05
Copy link

I'll have to manually implement this but I left my 👍 in hopes one day I can cleanly automate this haha

@sercue
Copy link

sercue commented Jun 16, 2021

Any ETA on this?

@chris2fer
Copy link

Really really need this 👍

@Mond18S
Copy link

Mond18S commented Jul 14, 2021

👍

@yenerunver
Copy link

+1, we need this as well

@mparmar19
Copy link

We need this.

@lukasz-kuras
Copy link

lukasz-kuras commented Jul 22, 2021

Eager to see that implemented.

@lalits77
Copy link

lalits77 commented Aug 3, 2021

Eagerly waiting for it

@janario
Copy link

janario commented Aug 8, 2021

Any updates here?

This would be super helpful for our usage :-)

@User-nehag
Copy link

Waiting for this from so long.

@tocy1
Copy link

tocy1 commented Aug 17, 2021

Waiting for this

@MLiu-FCC
Copy link

MLiu-FCC commented Sep 1, 2021

Waiting for this
This would be super helpful for our usage :-)

@aakrem
Copy link

aakrem commented Oct 4, 2021

We need this.. and it's already one year..

@breathingdust
Copy link
Member

Hi all 👋 Just letting you know that this is issue is featured on this quarters roadmap. If a PR exists to close the issue a maintainer will review and either make changes directly, or work with the original author to get the contribution merged. If you have written a PR to resolve the issue please ensure the "Allow edits from maintainers" box is checked. Thanks for your patience and we are looking forward to getting this merged soon!

@breathingdust breathingdust added this to the Roadmap milestone Nov 10, 2021
@YakDriver YakDriver self-assigned this Nov 19, 2021
@github-actions github-actions bot modified the milestones: Roadmap, v3.67.0 Nov 22, 2021
@github-actions
Copy link

github-actions bot commented Dec 1, 2021

This functionality has been released in v3.67.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. good first issue Call to action for new contributors looking for a place to start. Smaller or straightforward issues. service/configservice Issues and PRs that pertain to the configservice service.
Projects
None yet