Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/codeartifact_repository_permissions_policy - new resource #15562

Merged

Conversation

DrFaust92
Copy link
Collaborator

@DrFaust92 DrFaust92 commented Oct 8, 2020

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #13714

Release note for CHANGELOG:

resource_aws_codeartifact_repository_permissions_policy - add new resource

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSCodeArtifactRepositoryPermissionsPolicy_'
--- PASS: TestAccAWSCodeArtifactRepositoryPermissionsPolicy_disappears (51.51s)
--- PASS: TestAccAWSCodeArtifactRepositoryPermissionsPolicy_disappears_domain (51.57s)
--- PASS: TestAccAWSCodeArtifactRepositoryPermissionsPolicy_owner (56.46s)
--- PASS: TestAccAWSCodeArtifactRepositoryPermissionsPolicy_basic (106.64s)

@DrFaust92 DrFaust92 requested a review from a team October 8, 2020 16:19
@ghost ghost added size/XL Managed by automation to categorize the size of a PR. provider Pertains to the provider itself, rather than any interaction with AWS. service/codeartifact Issues and PRs that pertain to the codeartifact service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Oct 8, 2020
@DrFaust92 DrFaust92 added the new-resource Introduces a new resource. label Oct 8, 2020
@ghost ghost added the documentation Introduces or discusses updates to documentation. label Oct 8, 2020
@DrFaust92 DrFaust92 changed the title [WIP]r/codeartifact_repository_permissions_policy - new resource r/codeartifact_repository_permissions_policy - new resource Oct 8, 2020
….markdown

Co-authored-by: Kit Ewbank <Kit_Ewbank@hotmail.com>
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSCodeArtifactRepositoryPermissionsPolicy_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSCodeArtifactRepositoryPermissionsPolicy_ -timeout 120m
=== RUN   TestAccAWSCodeArtifactRepositoryPermissionsPolicy_basic
=== PAUSE TestAccAWSCodeArtifactRepositoryPermissionsPolicy_basic
=== RUN   TestAccAWSCodeArtifactRepositoryPermissionsPolicy_owner
=== PAUSE TestAccAWSCodeArtifactRepositoryPermissionsPolicy_owner
=== RUN   TestAccAWSCodeArtifactRepositoryPermissionsPolicy_disappears
=== PAUSE TestAccAWSCodeArtifactRepositoryPermissionsPolicy_disappears
=== RUN   TestAccAWSCodeArtifactRepositoryPermissionsPolicy_disappears_domain
=== PAUSE TestAccAWSCodeArtifactRepositoryPermissionsPolicy_disappears_domain
=== CONT  TestAccAWSCodeArtifactRepositoryPermissionsPolicy_basic
=== CONT  TestAccAWSCodeArtifactRepositoryPermissionsPolicy_disappears_domain
=== CONT  TestAccAWSCodeArtifactRepositoryPermissionsPolicy_disappears
=== CONT  TestAccAWSCodeArtifactRepositoryPermissionsPolicy_owner
=== CONT  TestAccAWSCodeArtifactRepositoryPermissionsPolicy_disappears
    resource_aws_codeartifact_repository_permissions_policy_test.go:86: [INFO] Got non-empty plan, as expected
=== CONT  TestAccAWSCodeArtifactRepositoryPermissionsPolicy_disappears_domain
    resource_aws_codeartifact_repository_permissions_policy_test.go:107: [INFO] Got non-empty plan, as expected
--- PASS: TestAccAWSCodeArtifactRepositoryPermissionsPolicy_disappears_domain (29.09s)
--- PASS: TestAccAWSCodeArtifactRepositoryPermissionsPolicy_disappears (29.20s)
--- PASS: TestAccAWSCodeArtifactRepositoryPermissionsPolicy_owner (31.71s)
--- PASS: TestAccAWSCodeArtifactRepositoryPermissionsPolicy_basic (47.06s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	47.100s

@breathingdust
Copy link
Member

LGTM 🚀 Thanks @DrFaust92

Verified Acceptance Tests in Commercial (us-west-2)

make testacc TEST=./aws TESTARGS='-run=TestAccAWSCodeArtifactRepositoryPermissionsPolicy_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSCodeArtifactRepositoryPermissionsPolicy_ -timeout 120m
=== RUN   TestAccAWSCodeArtifactRepositoryPermissionsPolicy_basic
=== PAUSE TestAccAWSCodeArtifactRepositoryPermissionsPolicy_basic
=== RUN   TestAccAWSCodeArtifactRepositoryPermissionsPolicy_owner
=== PAUSE TestAccAWSCodeArtifactRepositoryPermissionsPolicy_owner
=== RUN   TestAccAWSCodeArtifactRepositoryPermissionsPolicy_disappears
=== PAUSE TestAccAWSCodeArtifactRepositoryPermissionsPolicy_disappears
=== RUN   TestAccAWSCodeArtifactRepositoryPermissionsPolicy_disappears_domain
=== PAUSE TestAccAWSCodeArtifactRepositoryPermissionsPolicy_disappears_domain
=== CONT  TestAccAWSCodeArtifactRepositoryPermissionsPolicy_basic
=== CONT  TestAccAWSCodeArtifactRepositoryPermissionsPolicy_disappears_domain
=== CONT  TestAccAWSCodeArtifactRepositoryPermissionsPolicy_disappears
=== CONT  TestAccAWSCodeArtifactRepositoryPermissionsPolicy_owner
=== CONT  TestAccAWSCodeArtifactRepositoryPermissionsPolicy_disappears_domain
    resource_aws_codeartifact_repository_permissions_policy_test.go:107: [INFO] Got non-empty plan, as expected
=== CONT  TestAccAWSCodeArtifactRepositoryPermissionsPolicy_disappears
    resource_aws_codeartifact_repository_permissions_policy_test.go:86: [INFO] Got non-empty plan, as expected
--- PASS: TestAccAWSCodeArtifactRepositoryPermissionsPolicy_disappears_domain (17.80s)
--- PASS: TestAccAWSCodeArtifactRepositoryPermissionsPolicy_disappears (17.98s)
--- PASS: TestAccAWSCodeArtifactRepositoryPermissionsPolicy_owner (19.90s)
--- PASS: TestAccAWSCodeArtifactRepositoryPermissionsPolicy_basic (31.72s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	33.413s

@breathingdust breathingdust added this to the v3.10.0 milestone Oct 8, 2020
@breathingdust breathingdust merged commit 78905ec into hashicorp:master Oct 8, 2020
breathingdust added a commit that referenced this pull request Oct 8, 2020
@ghost
Copy link

ghost commented Oct 9, 2020

This has been released in version 3.10.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Nov 8, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Nov 8, 2020
@DrFaust92 DrFaust92 deleted the r/codeartifact_permissions branch April 15, 2021 10:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. new-resource Introduces a new resource. provider Pertains to the provider itself, rather than any interaction with AWS. service/codeartifact Issues and PRs that pertain to the codeartifact service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants