F/aws fsx windows file system: Support Support updating throughput_capacity and Storage_Capacity #15582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…capacity without recreation of resource
…capacity without recreation of resource
…capacity without recreation of resource
ghost
added
size/M
github-actions
bot
added
the
needs-triage
…capacity without recreation of resource
…capacity without recreation of resource
…capacity without recreation of resource
DrFaust92
removed
the
needs-triage
DrFaust92
added
the
enhancement
DrFaust92
approved these changes
Oct 11, 2020
|
LGTM 🚀 Thanks @nikhil-goenka for the contribution! Verified Acceptance Tests in Commercial (us-west-2) make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSFsxWindowsFileSystem_ThroughputCapacity'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSFsxWindowsFileSystem_ThroughputCapacity -timeout 120m
=== RUN TestAccAWSFsxWindowsFileSystem_ThroughputCapacity
=== PAUSE TestAccAWSFsxWindowsFileSystem_ThroughputCapacity
=== CONT TestAccAWSFsxWindowsFileSystem_ThroughputCapacity
--- PASS: TestAccAWSFsxWindowsFileSystem_ThroughputCapacity (3631.91s)
PASS
ok github.com/terraform-providers/terraform-provider-aws/aws 3633.552s
make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSFsxWindowsFileSystem_StorageCapacity'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSFsxWindowsFileSystem_StorageCapacity -timeout 120m
=== RUN TestAccAWSFsxWindowsFileSystem_StorageCapacity
=== PAUSE TestAccAWSFsxWindowsFileSystem_StorageCapacity
=== CONT TestAccAWSFsxWindowsFileSystem_StorageCapacity
--- PASS: TestAccAWSFsxWindowsFileSystem_StorageCapacity (3261.52s)
PASS
ok github.com/terraform-providers/terraform-provider-aws/aws 3263.013s
make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSFsxWindowsFileSystem_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSFsxWindowsFileSystem_basic -timeout 120m
=== RUN TestAccAWSFsxWindowsFileSystem_basic
=== PAUSE TestAccAWSFsxWindowsFileSystem_basic
=== CONT TestAccAWSFsxWindowsFileSystem_basic
--- PASS: TestAccAWSFsxWindowsFileSystem_basic (3277.35s)
PASS
ok github.com/terraform-providers/terraform-provider-aws/aws 3278.789s |
|
This has been released in version 3.17.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks! |
bflad
reviewed
Nov 25, 2020
| return nil, "", nil | ||
| } | ||
|
|
||
| return filesystem, aws.StringValue(filesystem.AdministrativeActions[0].Status), nil |
There was a problem hiding this comment.
This line is missing a length check on AdministrativeActions, which can cause a panic. Created followup issue: #16440
bflad
reviewed
Nov 25, 2020
|
|
||
| func waitForFsxFileSystemUpdateOptimizing(conn *fsx.FSx, id string, timeout time.Duration) error { | ||
| stateConf := &resource.StateChangeConf{ | ||
| Pending: []string{fsx.StatusInProgress}, |
There was a problem hiding this comment.
Seems like FSx also uses a PENDING status before it goes in progress. Created followup issue: #16440
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Community Note
Relates OR Closes #15558
Release note for CHANGELOG:
Output from acceptance testing: