Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resource/aws_db_proxy_default_target_group: Make connection_pool_config Optional #16303

Merged
merged 1 commit into from
Nov 24, 2020
Merged

resource/aws_db_proxy_default_target_group: Make connection_pool_config Optional #16303

merged 1 commit into from
Nov 24, 2020

Conversation

gdavison
Copy link
Contributor

The documentation for aws_db_proxy_default_target_group states that connection_pool_config is optional and the API does not require it.

Closes #16285

Release note for CHANGELOG:

* resource/aws_db_proxy_default_target_group: Make `connection_pool_config` optional

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSDBProxyDefaultTargetGroup_'

--- PASS: TestAccAWSDBProxyDefaultTargetGroup_disappears (663.38s)
--- PASS: TestAccAWSDBProxyDefaultTargetGroup_EmptyConnectionPoolConfig (674.40s)
--- PASS: TestAccAWSDBProxyDefaultTargetGroup_MaxConnectionsPercent (697.92s)
--- PASS: TestAccAWSDBProxyDefaultTargetGroup_ConnectionBorrowTimeout (776.49s)
--- PASS: TestAccAWSDBProxyDefaultTargetGroup_SessionPinningFilters (793.09s)
--- PASS: TestAccAWSDBProxyDefaultTargetGroup_MaxIdleConnectionsPercent (795.58s)
--- PASS: TestAccAWSDBProxyDefaultTargetGroup_Basic (795.63s)
--- PASS: TestAccAWSDBProxyDefaultTargetGroup_InitQuery (835.42s)

@gdavison gdavison requested a review from a team as a code owner November 19, 2020 03:37
@ghost ghost added size/S Managed by automation to categorize the size of a PR. service/rds Issues and PRs that pertain to the rds service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Nov 19, 2020
@anGie44 anGie44 self-assigned this Nov 19, 2020
anGie44
anGie44 approved these changes Nov 19, 2020
View reviewed changes
Copy link
Contributor

@anGie44 anGie44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

output of added acceptance test:

--- PASS: TestAccAWSDBProxyDefaultTargetGroup_EmptyConnectionPoolConfig (689.41s)

aws/resource_aws_db_proxy_default_target_group_test.go
testAccCheckAWSDBProxyTargetGroupExists(resourceName, &dbProxyTargetGroup),
testAccMatchResourceAttrRegionalARN(resourceName, "arn", "rds", regexp.MustCompile(`target-group:.+`)),
resource.TestCheckResourceAttr(resourceName, "connection_pool_config.#", "1"),
resource.TestCheckTypeSetElemNestedAttrs(resourceName, "connection_pool_config.*", map[string]string{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool! never thought to use this method for Lists as well

@gdavison gdavison merged commit 7d3d33f into master Nov 24, 2020
@gdavison gdavison deleted the b-db_proxy-connection_pool-optional branch November 24, 2020 18:39
@github-actions github-actions bot added this to the v3.18.0 milestone Nov 24, 2020
gdavison added a commit that referenced this pull request Nov 24, 2020
@gdavison
Update CHANGELOG for #16303
2975c11
@ghost
Copy link

ghost commented Nov 25, 2020

This has been released in version 3.18.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Dec 25, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Dec 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@anGie44 anGie44 anGie44 approved these changes

Assignees

@anGie44 anGie44

Labels
service/rds Issues and PRs that pertain to the rds service. size/S Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.18.0
2 participants
@gdavison @anGie44