Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tech debt: update networkfirewall resources to resource.RetryContext #16348

Closed
anGie44 opened this issue Nov 20, 2020 · 2 comments · Fixed by #16561
Closed

Tech debt: update networkfirewall resources to resource.RetryContext #16348

anGie44 opened this issue Nov 20, 2020 · 2 comments · Fixed by #16561
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/networkfirewall Issues and PRs that pertain to the networkfirewall service. technical-debt Addresses areas of the codebase that need refactoring or redesign.
Milestone

Comments

@anGie44
Copy link
Contributor

anGie44 commented Nov 20, 2020

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

New or Affected Resource(s)

  • aws_networkfirewall_policy
  • aws_networkfirewall_rule_group

Potential Change

err := resource.Retry(waiter.RuleGroupDeleteTimeout, func() *resource.RetryError {

to

err := resource.RetryContext(ctx, waiter.RuleGroupDeleteTimeout, func() *resource.RetryError {

References

@anGie44 anGie44 added the enhancement Requests to existing resources that expand the functionality or scope. label Nov 20, 2020
@ghost ghost added the service/networkfirewall Issues and PRs that pertain to the networkfirewall service. label Nov 20, 2020
@anGie44 anGie44 added the technical-debt Addresses areas of the codebase that need refactoring or redesign. label Nov 20, 2020
@anGie44 anGie44 changed the title networkfirewall: update resources with resource.Retry to resource.RetryContext Tech debt: update networkfirewall resources with resource.Retry to resource.RetryContext Nov 20, 2020
@anGie44 anGie44 changed the title Tech debt: update networkfirewall resources with resource.Retry to resource.RetryContext Tech debt: update networkfirewall resources to resource.RetryContext Nov 20, 2020
@anGie44 anGie44 added this to the v3.20.0 milestone Dec 3, 2020
@ghost
Copy link

ghost commented Dec 3, 2020

This has been released in version 3.20.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Jan 2, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Jan 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/networkfirewall Issues and PRs that pertain to the networkfirewall service. technical-debt Addresses areas of the codebase that need refactoring or redesign.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant