Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update the default creation timeout for fsx windows file system #16363

Merged
merged 1 commit into from
Nov 23, 2020
Merged

update the default creation timeout for fsx windows file system #16363

merged 1 commit into from
Nov 23, 2020

Conversation

denissimonovski
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #16315

Release note for CHANGELOG:

  • default timeout for creation of fsx windows file system updated to 45 minutes.

I could not run the acceptance test because of a VPC limit in my lab.

@denissimonovski denissimonovski requested a review from a team as a code owner November 21, 2020 17:55
@ghost ghost added size/XS Managed by automation to categorize the size of a PR. service/fsx Issues and PRs that pertain to the fsx service. labels Nov 21, 2020
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Nov 21, 2020
github-actions[bot]
github-actions bot reviewed Nov 21, 2020
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @denissimonovski 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@denissimonovski denissimonovski mentioned this pull request Nov 21, 2020
Closed
@DrFaust92 DrFaust92 added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Nov 23, 2020
DrFaust92
DrFaust92 approved these changes Nov 23, 2020
View reviewed changes
Copy link
Collaborator

@DrFaust92 DrFaust92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bflad bflad added this to the v3.17.0 milestone Nov 23, 2020
bflad
bflad approved these changes Nov 23, 2020
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks @denissimonovski 🚀

@bflad bflad added bug Addresses a defect in current functionality. and removed enhancement Requests to existing resources that expand the functionality or scope. labels Nov 23, 2020
@bflad bflad merged commit fc578fe into hashicorp:master Nov 23, 2020
bflad added a commit that referenced this pull request Nov 23, 2020
@bflad
Update CHANGELOG for #16363
9dc4e7d
@ghost
Copy link

ghost commented Nov 24, 2020

This has been released in version 3.17.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@denissimonovski denissimonovski deleted the b-resource_aws_fsx_windows_file_system-modify-default-creation-timeout branch November 24, 2020 21:57
@ghost
Copy link

ghost commented Dec 23, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Dec 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@DrFaust92 DrFaust92 DrFaust92 approved these changes

@bflad bflad bflad approved these changes

Assignees
No one assigned
Labels
bug Addresses a defect in current functionality. service/fsx Issues and PRs that pertain to the fsx service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Milestone
v3.17.0
Development

Successfully merging this pull request may close these issues.

resource/aws_fsx_windows_file_system: Increase default creation timeout
3 participants
@denissimonovski @bflad @DrFaust92