Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow looking up launch templates by ID in aws_launch_template data source #16457

Merged
merged 1 commit into from
Dec 11, 2020
Merged

Allow looking up launch templates by ID in aws_launch_template data source #16457

merged 1 commit into from
Dec 11, 2020

Conversation

yorinasub17
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Release note for CHANGELOG:

* data-source/aws_launch_template: Support looking up Launch Template by `id` field.

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSLaunchTemplateDataSource_id_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSLaunchTemplateDataSource_id_basic -timeout 120m
=== RUN   TestAccAWSLaunchTemplateDataSource_id_basic
=== PAUSE TestAccAWSLaunchTemplateDataSource_id_basic
=== CONT  TestAccAWSLaunchTemplateDataSource_id_basic
--- PASS: TestAccAWSLaunchTemplateDataSource_id_basic (27.95s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       30.250s

@yorinasub17 yorinasub17 requested a review from a team as a code owner November 27, 2020 06:19
@ghost ghost added size/S Managed by automation to categorize the size of a PR. service/ec2 Issues and PRs that pertain to the ec2 service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Nov 27, 2020
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Nov 27, 2020
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @yorinasub17 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@bflad bflad added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Dec 11, 2020
@bflad bflad self-assigned this Dec 11, 2020
@bflad bflad added this to the v3.21.0 milestone Dec 11, 2020
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks @yorinasub17 🚀

Output from acceptance testing in AWS Commercial:

--- PASS: TestAccAWSLaunchTemplateDataSource_associateCarrierIPAddress (48.53s)
--- PASS: TestAccAWSLaunchTemplateDataSource_associatePublicIPAddress (47.62s)
--- PASS: TestAccAWSLaunchTemplateDataSource_basic (21.49s)
--- PASS: TestAccAWSLaunchTemplateDataSource_filter_basic (21.49s)
--- PASS: TestAccAWSLaunchTemplateDataSource_filter_tags (21.49s)
--- PASS: TestAccAWSLaunchTemplateDataSource_id_basic (21.49s)
--- PASS: TestAccAWSLaunchTemplateDataSource_metadataOptions (20.25s)
--- PASS: TestAccAWSLaunchTemplateDataSource_networkInterfaces_deleteOnTermination (47.88s)
--- PASS: TestAccAWSLaunchTemplateDataSource_NonExistent (3.73s)

Output from acceptance testing in AWS GovCloud (US):

--- PASS: TestAccAWSLaunchTemplateDataSource_associateCarrierIPAddress (59.23s)
--- PASS: TestAccAWSLaunchTemplateDataSource_associatePublicIPAddress (57.58s)
--- PASS: TestAccAWSLaunchTemplateDataSource_basic (24.73s)
--- PASS: TestAccAWSLaunchTemplateDataSource_filter_basic (23.87s)
--- PASS: TestAccAWSLaunchTemplateDataSource_filter_tags (24.77s)
--- PASS: TestAccAWSLaunchTemplateDataSource_id_basic (23.81s)
--- PASS: TestAccAWSLaunchTemplateDataSource_metadataOptions (24.94s)
--- PASS: TestAccAWSLaunchTemplateDataSource_networkInterfaces_deleteOnTermination (58.07s)
--- PASS: TestAccAWSLaunchTemplateDataSource_NonExistent (4.21s)

@bflad bflad merged commit 02f6065 into hashicorp:master Dec 11, 2020
bflad added a commit that referenced this pull request Dec 11, 2020
@ghost
Copy link

ghost commented Dec 11, 2020

This has been released in version 3.21.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Jan 10, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Jan 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/ec2 Issues and PRs that pertain to the ec2 service. size/S Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants