Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource/aws_fsx_windows_file_system: Prevent potential panics, unexpected errors, and use correct operation timeout on update #16488

Merged
merged 1 commit into from
Dec 1, 2020

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Nov 30, 2020

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Reference: https://docs.aws.amazon.com/fsx/latest/APIReference/API_AdministrativeAction.html
Closes #16440

Release note for CHANGELOG:

resource/aws_fsx_windows_file_system: Prevent potential panics, unexpected errors, and use correct operation timeout on update

Output from acceptance testing:

Pending

…ected errors, and use correct operation timeout on update

Reference: https://docs.aws.amazon.com/fsx/latest/APIReference/API_AdministrativeAction.html
Reference: #16440

Output from acceptance testing:

```
Pending
```
@ghost ghost added size/S Managed by automation to categorize the size of a PR. service/fsx Issues and PRs that pertain to the fsx service. labels Nov 30, 2020
Copy link
Collaborator

@DrFaust92 DrFaust92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

--- PASS: TestAccAWSFsxWindowsFileSystem_ThroughputCapacity (5161.78s)

@bflad bflad added this to the v3.19.0 milestone Dec 1, 2020
@bflad bflad marked this pull request as ready for review December 1, 2020 16:38
@bflad bflad requested a review from a team as a code owner December 1, 2020 16:38
@bflad
Copy link
Contributor Author

bflad commented Dec 1, 2020

Passing all resource acceptance testing 👍

@bflad bflad merged commit 145b23e into master Dec 1, 2020
bflad added a commit that referenced this pull request Dec 1, 2020
@ghost
Copy link

ghost commented Dec 1, 2020

This has been released in version 3.19.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Dec 31, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Dec 31, 2020
@breathingdust breathingdust deleted the b-aws_fsx_windows_file_system-capacity-updates branch December 14, 2021 20:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
service/fsx Issues and PRs that pertain to the fsx service. size/S Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

resource/aws_fsx_windows_file_system: Unexpected errors and panics with capacity updates
2 participants