Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource/lambda_function: Enhance plan-time validation #16515

Closed
gdavison opened this issue Dec 1, 2020 · 3 comments
Closed

resource/lambda_function: Enhance plan-time validation #16515

gdavison opened this issue Dec 1, 2020 · 3 comments
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/lambda Issues and PRs that pertain to the lambda service. stale Old or inactive issues managed by automation, if no further action taken these will get closed.

Comments

@gdavison
Copy link
Contributor

gdavison commented Dec 1, 2020

Description

As the Lambda function resource has been extended and new plan-time validation options have been added to the Terraform Plugin SDK we have some validation gaps that can now be closed.

  • Replace ConflictsWith on s3_bucket, s3_key, s3_object_version, image_uri, and filename with ExactlyOneOf and add RequiredWith: []string{"s3_key"} on s3_bucket
  • Add ConflictsWith: []string{"filename", "s3_bucket", "s3_key", "s3_object_version"} to image_config
  • Add cross-attribute validation using the schema.Resource field CustomizeDiff to ensure that the value of package_type and the values of s3_bucket, s3_key, s3_object_version, image_uri, image_config, and filename are appropriate

This may not be an exhaustive list of validations.

Affected Resource

  • aws_lambda_function

References

@gdavison gdavison added the enhancement Requests to existing resources that expand the functionality or scope. label Dec 1, 2020
@ghost ghost added the service/lambda Issues and PRs that pertain to the lambda service. label Dec 1, 2020
@bnusunny
Copy link
Contributor

bnusunny commented Sep 2, 2021

@gdavison I will work on this.

Copy link

Marking this issue as stale due to inactivity. This helps our maintainers find and focus on the active issues. If this issue receives no comments in the next 30 days it will automatically be closed. Maintainers can also remove the stale label.

If this issue was automatically closed and you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thank you!

@github-actions github-actions bot added the stale Old or inactive issues managed by automation, if no further action taken these will get closed. label Dec 31, 2023
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Feb 5, 2024
Copy link

github-actions bot commented Mar 7, 2024

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/lambda Issues and PRs that pertain to the lambda service. stale Old or inactive issues managed by automation, if no further action taken these will get closed.
Projects
None yet
Development

No branches or pull requests

2 participants