Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow private_dns_name to be set via aws_vpc_endpoint_service resource #16568

Closed
breathingdust opened this issue Dec 3, 2020 · 4 comments · Fixed by #16495
Closed

Allow private_dns_name to be set via aws_vpc_endpoint_service resource #16568

breathingdust opened this issue Dec 3, 2020 · 4 comments · Fixed by #16495
Assignees
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/ec2 Issues and PRs that pertain to the ec2 service.
Milestone

Comments

@breathingdust
Copy link
Member

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

private_dns_name is currently an exported attribute, but the API does allow it to be set when creating a VPC Endpoint Service Configuration.

New or Affected Resource(s)

  • aws_vpc_endpoint_service

Potential Terraform Configuration

resource "aws_vpc_endpoint_service" "test" {
  acceptance_required = false
  network_load_balancer_arns = [
    aws_lb.test1.arn,
  ]
  private_dns_name = ""
}

References

@breathingdust breathingdust added enhancement Requests to existing resources that expand the functionality or scope. service/ec2 Issues and PRs that pertain to the ec2 service. labels Dec 3, 2020
@ewbankkit
Copy link
Contributor

Addressed via #16495.

@bflad
Copy link
Contributor

bflad commented Jan 5, 2021

Support for configurable private_dns_name and adding a private_dns_name_configuration attribute in the aws_vpc_endpoint_service resource has been merged and will release with version 3.23.0 of the Terraform AWS Provider. Thanks to @craigedmunds and @stijndehaes for their efforts here. 👍

@ghost
Copy link

ghost commented Jan 8, 2021

This has been released in version 3.23.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Feb 4, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Feb 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/ec2 Issues and PRs that pertain to the ec2 service.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants