Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature: Add working_directory to ImageBuilder #16947

Merged
merged 3 commits into from
Jan 4, 2021
Merged

feature: Add working_directory to ImageBuilder #16947

merged 3 commits into from
Jan 4, 2021

Conversation

schabert
Copy link
Contributor

@schabert schabert commented Jan 4, 2021

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #16946

Release note for CHANGELOG:

Additional Property "working_directory"

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

@schabert schabert requested a review from a team as a code owner January 4, 2021 12:43
@ghost ghost added size/XS Managed by automation to categorize the size of a PR. service/imagebuilder Issues and PRs that pertain to the imagebuilder service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Jan 4, 2021
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Jan 4, 2021
github-actions[bot]
github-actions bot reviewed Jan 4, 2021
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @schabert 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@ghost ghost added the documentation Introduces or discusses updates to documentation. label Jan 4, 2021
@bflad bflad added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Jan 4, 2021
@bflad bflad self-assigned this Jan 4, 2021
@bflad bflad added this to the v3.23.0 milestone Jan 4, 2021
bflad
bflad reviewed Jan 4, 2021
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for submitting this, @schabert. We'll get this in with the noted changes.

aws/data_source_aws_imagebuilder_image_recipe_test.go
@@ -59,6 +59,7 @@ resource "aws_imagebuilder_component" "test" {
}]
schemaVersion = 1.0
})
working_directory = "/tmp"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per the Contributing Guide, it is preferred to have new optional arguments in new, separate acceptance tests. Will followup these commits adding a resource test and refactoring this data source test.

aws/data_source_aws_imagebuilder_image_recipe.go
@@ -116,6 +116,10 @@ func dataSourceAwsImageBuilderImageRecipe() *schema.Resource {
Type: schema.TypeString,
Computed: true,
},
"working_directory": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This new attribute needs documentation added in websites/docs/d/imagebuilder_image_recipe.html.markdown -- will followup on merge.

aws/resource_aws_imagebuilder_image_recipe.go Outdated Show resolved Hide resolved
bflad added a commit that referenced this pull request Jan 4, 2021
@bflad
service/imagebuilder: Review items from #16947
c764155 
Reference: #16947 (review)

Output from acceptance testing in AWS Commercial:

```
--- PASS: TestAccAwsImageBuilderImageRecipe_disappears (31.42s)
--- PASS: TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_Ebs_Encrypted (34.85s)
--- PASS: TestAccAwsImageBuilderImageRecipe_basic (35.02s)
--- PASS: TestAccAwsImageBuilderImageRecipe_Description (37.85s)
--- PASS: TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_Ebs_Iops (38.14s)
--- PASS: TestAccAwsImageBuilderImageRecipe_WorkingDirectory (38.17s)
--- PASS: TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_VirtualName (38.18s)
--- PASS: TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_DeviceName (38.24s)
--- PASS: TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_Ebs_VolumeSize (38.32s)
--- PASS: TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_NoDevice (38.39s)
--- PASS: TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_Ebs_DeleteOnTermination (38.44s)
--- PASS: TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_Ebs_VolumeType (38.44s)
--- PASS: TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_Ebs_KmsKeyId (39.35s)
--- PASS: TestAccAwsImageBuilderImageRecipe_Component (39.39s)
--- PASS: TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_Ebs_SnapshotId (48.07s)
--- PASS: TestAccAwsImageBuilderImageRecipe_Tags (64.35s)

--- PASS: TestAccAwsImageBuilderImageRecipeDataSource_Arn (27.89s)
```

Output from acceptance testing in AWS GovCloud (US):

```
--- PASS: TestAccAwsImageBuilderImageRecipe_disappears (37.78s)
--- PASS: TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_VirtualName (40.06s)
--- PASS: TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_Ebs_Encrypted (40.46s)
--- PASS: TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_Ebs_VolumeSize (40.52s)
--- PASS: TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_Ebs_VolumeType (40.68s)
--- PASS: TestAccAwsImageBuilderImageRecipe_basic (41.90s)
--- PASS: TestAccAwsImageBuilderImageRecipe_Description (42.30s)
--- PASS: TestAccAwsImageBuilderImageRecipe_WorkingDirectory (42.46s)
--- PASS: TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_Ebs_DeleteOnTermination (42.62s)
--- PASS: TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_NoDevice (42.64s)
--- PASS: TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_DeviceName (42.82s)
--- PASS: TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_Ebs_KmsKeyId (43.29s)
--- PASS: TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_Ebs_Iops (43.30s)
--- PASS: TestAccAwsImageBuilderImageRecipe_Component (44.64s)
--- PASS: TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_Ebs_SnapshotId (49.57s)
--- PASS: TestAccAwsImageBuilderImageRecipe_Tags (73.70s)

--- PASS: TestAccAwsImageBuilderImageRecipeDataSource_Arn (30.79s)
```
@bflad bflad merged commit 0f51b3e into hashicorp:master Jan 4, 2021
bflad added a commit that referenced this pull request Jan 4, 2021
@bflad
Update CHANGELOG for #16947
ed6bf2f
@schabert schabert deleted the f-add-additional-property-to-imagebuilder branch January 4, 2021 19:26
@ghost
Copy link

ghost commented Jan 8, 2021

This has been released in version 3.23.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Feb 3, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Feb 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@bflad bflad bflad left review comments

Assignees

@bflad bflad

Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/imagebuilder Issues and PRs that pertain to the imagebuilder service. size/XS Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.23.0
Development

Successfully merging this pull request may close these issues.

aws_imagebuilder_image_recipe should allow WorkingDirectory as parameter
2 participants
@schabert @bflad