Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for retry policies and dead letter config for aws_cloudwatch_event_target resources #17241

Merged
merged 11 commits into from
Feb 18, 2021

Conversation

sthulb
Copy link
Contributor

@sthulb sthulb commented Jan 22, 2021

Intro
This PR adds support to create Archives in EventBridge.

Release note for CHANGELOG:

resource_aws_cloudwatch_event_target - adds retry policies and dead letter config for aws_cloudwatch_event_target resources

Tasks

[x] Acceptance test
[x] Update docs

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #17240

Output from acceptance testing:

thulsimo@3c22fbef9550 terraform-provider-aws % make testacc TESTARGS='-run=^TestAccAWSCloudWatchEventTarget_retrypolicy_dlc$'
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=^TestAccAWSCloudWatchEventTarget_retrypolicy_dlc -timeout 120m
=== RUN   TestAccAWSCloudWatchEventTarget_retrypolicy_dlc
=== PAUSE TestAccAWSCloudWatchEventTarget_retrypolicy_dlc
=== CONT  TestAccAWSCloudWatchEventTarget_retrypolicy_dlc
--- PASS: TestAccAWSCloudWatchEventTarget_retrypolicy_dlc (80.64s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       84.015s


...

@sthulb sthulb requested a review from a team as a code owner January 22, 2021 14:02
@ghost ghost added size/M Managed by automation to categorize the size of a PR. service/cloudwatchevents labels Jan 22, 2021
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Jan 22, 2021
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @sthulb 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

Base automatically changed from master to main January 23, 2021 01:00
@ghost ghost added size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. and removed size/M Managed by automation to categorize the size of a PR. labels Jan 27, 2021
@sthulb sthulb changed the title Event target rules feat: add support for retry policies and dead letter config for aws_cloudwatch_event_target resources Jan 27, 2021
@ghost ghost added the documentation Introduces or discusses updates to documentation. label Jan 27, 2021
Copy link
Contributor

@bill-rich bill-rich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. I just had a couple requests. Also please add a .changelog file.

aws/resource_aws_cloudwatch_event_target.go Show resolved Hide resolved
aws/resource_aws_cloudwatch_event_target_test.go Outdated Show resolved Hide resolved
@bill-rich bill-rich self-assigned this Feb 18, 2021
@sthulb
Copy link
Contributor Author

sthulb commented Feb 18, 2021

All items have been resolved – tests pass despite "failing" terrafmt (due to an error outside of my PR)

@bill-rich bill-rich merged commit 01c0c84 into hashicorp:main Feb 18, 2021
@github-actions github-actions bot added this to the v3.29.0 milestone Feb 18, 2021
@ghost
Copy link

ghost commented Feb 19, 2021

This has been released in version 3.29.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Mar 21, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Mar 21, 2021
@breathingdust breathingdust removed the needs-triage Waiting for first response or review from a maintainer. label Sep 17, 2021
@justinretzolk justinretzolk added the partner Contribution from a partner. label May 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. partner Contribution from a partner. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for RetryPolicy and DeadLetterConfig in aws_cloudwatch_event_target
4 participants