Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_imagebuilder_image_recipe: Add support for 'volume_type = "gp3"' #17286

Conversation

ewbankkit
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #17274.

Output from acceptance testing:

$ make testacc TEST=./aws TESTARGS='-run=TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_Ebs_VolumeType'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_Ebs_VolumeType -timeout 120m
=== RUN   TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_Ebs_VolumeTypeGp2
=== PAUSE TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_Ebs_VolumeTypeGp2
=== RUN   TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_Ebs_VolumeTypeGp3
=== PAUSE TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_Ebs_VolumeTypeGp3
=== CONT  TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_Ebs_VolumeTypeGp2
=== CONT  TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_Ebs_VolumeTypeGp3
--- PASS: TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_Ebs_VolumeTypeGp3 (22.45s)
--- PASS: TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_Ebs_VolumeTypeGp2 (22.86s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	22.956s

@ewbankkit ewbankkit requested a review from a team as a code owner January 26, 2021 14:57
@ghost ghost added size/S Managed by automation to categorize the size of a PR. service/imagebuilder Issues and PRs that pertain to the imagebuilder service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Jan 26, 2021
Acceptance test output:

$ make testacc TEST=./aws TESTARGS='-run=TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_Ebs_VolumeType'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_Ebs_VolumeType -timeout 120m
=== RUN   TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_Ebs_VolumeTypeGp2
=== PAUSE TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_Ebs_VolumeTypeGp2
=== RUN   TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_Ebs_VolumeTypeGp3
=== PAUSE TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_Ebs_VolumeTypeGp3
=== CONT  TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_Ebs_VolumeTypeGp2
=== CONT  TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_Ebs_VolumeTypeGp3
--- PASS: TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_Ebs_VolumeTypeGp3 (22.45s)
--- PASS: TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_Ebs_VolumeTypeGp2 (22.86s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	22.956s
@ewbankkit ewbankkit force-pushed the f-r/aws_imagebuilder_image_recipe-volume_type-gp3 branch from 4ae6393 to 64670fb Compare January 26, 2021 15:01
@bill-rich bill-rich self-assigned this Feb 11, 2021
Copy link
Contributor

@bill-rich bill-rich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_Ebs_ -timeout 120m
=== RUN   TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_Ebs_DeleteOnTermination
=== PAUSE TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_Ebs_DeleteOnTermination
=== RUN   TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_Ebs_Encrypted
=== PAUSE TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_Ebs_Encrypted
=== RUN   TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_Ebs_Iops
=== PAUSE TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_Ebs_Iops
=== RUN   TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_Ebs_KmsKeyId
=== PAUSE TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_Ebs_KmsKeyId
=== RUN   TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_Ebs_SnapshotId
=== PAUSE TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_Ebs_SnapshotId
=== RUN   TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_Ebs_VolumeSize
=== PAUSE TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_Ebs_VolumeSize
=== RUN   TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_Ebs_VolumeTypeGp2
=== PAUSE TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_Ebs_VolumeTypeGp2
=== RUN   TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_Ebs_VolumeTypeGp3
=== PAUSE TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_Ebs_VolumeTypeGp3
=== CONT  TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_Ebs_DeleteOnTermination
=== CONT  TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_Ebs_SnapshotId
=== CONT  TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_Ebs_VolumeSize
=== CONT  TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_Ebs_VolumeTypeGp3
=== CONT  TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_Ebs_Iops
=== CONT  TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_Ebs_KmsKeyId
=== CONT  TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_Ebs_Encrypted
=== CONT  TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_Ebs_VolumeTypeGp2
--- PASS: TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_Ebs_DeleteOnTermination (27.98s)
--- PASS: TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_Ebs_Iops (38.62s)
--- PASS: TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_Ebs_KmsKeyId (56.98s)
--- PASS: TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_Ebs_VolumeTypeGp3 (67.61s)
--- PASS: TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_Ebs_VolumeSize (86.93s)
--- PASS: TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_Ebs_SnapshotId (105.53s)
--- PASS: TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_Ebs_Encrypted (107.80s)
--- PASS: TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_Ebs_VolumeTypeGp2 (118.98s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	119.022s

@bill-rich bill-rich merged commit 4f4651c into hashicorp:main Feb 11, 2021
@github-actions github-actions bot added this to the v3.28.0 milestone Feb 11, 2021
@ewbankkit ewbankkit deleted the f-r/aws_imagebuilder_image_recipe-volume_type-gp3 branch February 11, 2021 21:19
@ghost
Copy link

ghost commented Feb 12, 2021

This has been released in version 3.28.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ewbankkit
Copy link
Contributor Author

EbsVolumeTypeGp3 added to VolumeType enumeration in AWS SDK v1.37.19.

@ghost
Copy link

ghost commented Mar 14, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Mar 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
service/imagebuilder Issues and PRs that pertain to the imagebuilder service. size/S Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for gp3 volume type in aws_imagebuilder__image_reciepe resource
2 participants