Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource/aws_msk_cluster: Support instance_type update #17447

Merged
merged 1 commit into from
Apr 30, 2021

Conversation

shuheiktgw
Copy link
Collaborator

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #17264

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSMskCluster_BrokerNodeGroupInfo_InstanceType'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSMskCluster_BrokerNodeGroupInfo_InstanceType -timeout 120m
=== RUN   TestAccAWSMskCluster_BrokerNodeGroupInfo_InstanceType
=== PAUSE TestAccAWSMskCluster_BrokerNodeGroupInfo_InstanceType
=== CONT  TestAccAWSMskCluster_BrokerNodeGroupInfo_InstanceType
--- PASS: TestAccAWSMskCluster_BrokerNodeGroupInfo_InstanceType (5663.60s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	5665.564s

Thank you for your review!

@shuheiktgw shuheiktgw requested a review from a team as a code owner February 3, 2021 23:15
@ghost ghost added size/M Managed by automation to categorize the size of a PR. service/kafka Issues and PRs that pertain to the kafka service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Feb 3, 2021
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Feb 3, 2021
@bflad bflad added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Apr 29, 2021
@bflad bflad self-assigned this Apr 30, 2021
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much, @shuheiktgw, will add CHANGELOG on merge 🚀

Output from acceptance testing (all passing in Commercial and GovCloud):

--- PASS: TestAccAWSMskCluster_EncryptionInfo_EncryptionAtRestKmsKeyArn (1228.52s)
--- PASS: TestAccAWSMskCluster_EncryptionInfo_EncryptionInTransit_InCluster (1233.17s)
--- PASS: TestAccAWSMskCluster_Tags (1234.40s)
--- PASS: TestAccAWSMskCluster_EnhancedMonitoring (1253.82s)
--- PASS: TestAccAWSMskCluster_EncryptionInfo_EncryptionInTransit_ClientBroker (1295.63s)
--- PASS: TestAccAWSMskCluster_basic (1302.42s)
--- PASS: TestAccAWSMskCluster_OpenMonitoring (1412.31s)
--- PASS: TestAccAWSMskCluster_LoggingInfo (1424.35s)
--- PASS: TestAccAWSMskCluster_BrokerNodeGroupInfo_EbsVolumeSize (1452.58s)
--- PASS: TestAccAWSMskCluster_NumberOfBrokerNodes (1732.59s)
--- PASS: TestAccAWSMskCluster_ConfigurationInfo_Revision (1761.38s)
--- PASS: TestAccAWSMskCluster_ClientAuthentication_Sasl_Scram (2698.90s)
--- PASS: TestAccAWSMskCluster_KafkaVersionDowngrade (2703.47s)
--- PASS: TestAccAWSMskCluster_KafkaVersionUpgrade (3312.54s)
--- PASS: TestAccAWSMskCluster_KafkaVersionUpgradeWithConfigurationInfo (3324.70s)
--- PASS: TestAccAWSMskCluster_BrokerNodeGroupInfo_InstanceType (4129.07s)

@bflad bflad merged commit e05fe3b into hashicorp:main Apr 30, 2021
bflad added a commit that referenced this pull request Apr 30, 2021
@bflad bflad added this to the v3.39.0 milestone Apr 30, 2021
@ghost
Copy link

ghost commented May 7, 2021

This has been released in version 3.39.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@github-actions
Copy link

github-actions bot commented Jun 6, 2021

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/kafka Issues and PRs that pertain to the kafka service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Amazon MSK now supports the ability to change the size or family of Apache Kafka brokers
7 participants