Please support gRPC status code [0-99] in the matcher of healthcheck of lb_target_group

[habuchin]

Community Note

• Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
• If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

#17405 now supports protocol_version = "GRPC", but the health_check matcher does not support gRPC status codes.
We need to be able to specify the status code [0-99] when protocol_version = "GRPC".

New or Affected Resource(s)

• aws_lb_target_group

Potential Terraform Configuration

resource "aws_lb_target_group" "example" {
  name     = "example"
  port             = 80
  protocol         = "HTTP"
  vpc_id           = xxxxxxxxx
  target_type      = "ip"
  protocol_version = "GRPC"

  health_check {
    interval            = 30
    path                = "/grpc.health.v1.Health/Check"
    port                = "traffic-port"
    protocol            = "HTTP"
    timeout             = 10
    healthy_threshold   = 2
    unhealthy_threshold = 2
    matcher             = "0"
  }
}

Error: Error modifying Target Group: ValidationError: Health check matcher HTTP code '0' must be within '200-499' inclusive
        status code: 400, request id: xxxxxxxxx

References

• https://docs.aws.amazon.com/elasticloadbalancing/latest/application/target-group-health-checks.html
• aws_autoscaling_group fails to roll when healthy and unhealthy targets present and min_elb_capacity used #17405

[ewbankkit]

At the API level the matcher is actually structure with 2 fields, GrpcCode and HttpCode. Currently the provider always correlates the matcher attribute with the HttpCode field.
In order not to introduce a breaking change, some logic will have to be introduced to use the correct API field depending on the health_check.protocol value.

[ewbankkit]

Related:

• Add protocol_version to lb target groups #16132
• Use gRPC matcher with gRPC protocol #17534

[ewbankkit]

Closed via #17534.

[ghost]

This has been released in version 3.29.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!