-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
14324 - Fix kafka_versions being a required field #17571
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome @ryan-dyer-sp 👋
It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.
Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.
Thanks again, and welcome to the community! 😃
For updating the changelog do I create a file in the .changelog directory corresponding to the issue ID or PR ID? And then do I do something else to render the CHANGELOG.md? |
Need feedback |
Still need feedback |
@ryan-dyer-sp Thanks for the contribution 👏. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
Commercial
% make testacc TEST=./aws TESTARGS='-run=TestAccAWSMskConfiguration_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSMskConfiguration_ -timeout 120m
=== RUN TestAccAWSMskConfiguration_basic
=== PAUSE TestAccAWSMskConfiguration_basic
=== RUN TestAccAWSMskConfiguration_disappears
=== PAUSE TestAccAWSMskConfiguration_disappears
=== RUN TestAccAWSMskConfiguration_Description
=== PAUSE TestAccAWSMskConfiguration_Description
=== RUN TestAccAWSMskConfiguration_KafkaVersions
=== PAUSE TestAccAWSMskConfiguration_KafkaVersions
=== RUN TestAccAWSMskConfiguration_ServerProperties
=== PAUSE TestAccAWSMskConfiguration_ServerProperties
=== CONT TestAccAWSMskConfiguration_basic
=== CONT TestAccAWSMskConfiguration_KafkaVersions
=== CONT TestAccAWSMskConfiguration_Description
=== CONT TestAccAWSMskConfiguration_ServerProperties
=== CONT TestAccAWSMskConfiguration_disappears
--- PASS: TestAccAWSMskConfiguration_disappears (12.14s)
--- PASS: TestAccAWSMskConfiguration_KafkaVersions (21.48s)
--- PASS: TestAccAWSMskConfiguration_basic (22.88s)
--- PASS: TestAccAWSMskConfiguration_ServerProperties (26.26s)
--- PASS: TestAccAWSMskConfiguration_Description (31.01s)
PASS
ok github.com/terraform-providers/terraform-provider-aws/aws 34.448s
GovCloud
% make testacc TEST=./aws TESTARGS='-run=TestAccAWSMskConfiguration_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSMskConfiguration_ -timeout 120m
=== RUN TestAccAWSMskConfiguration_basic
=== PAUSE TestAccAWSMskConfiguration_basic
=== RUN TestAccAWSMskConfiguration_disappears
=== PAUSE TestAccAWSMskConfiguration_disappears
=== RUN TestAccAWSMskConfiguration_Description
=== PAUSE TestAccAWSMskConfiguration_Description
=== RUN TestAccAWSMskConfiguration_KafkaVersions
=== PAUSE TestAccAWSMskConfiguration_KafkaVersions
=== RUN TestAccAWSMskConfiguration_ServerProperties
=== PAUSE TestAccAWSMskConfiguration_ServerProperties
=== CONT TestAccAWSMskConfiguration_basic
=== CONT TestAccAWSMskConfiguration_KafkaVersions
=== CONT TestAccAWSMskConfiguration_Description
=== CONT TestAccAWSMskConfiguration_ServerProperties
=== CONT TestAccAWSMskConfiguration_disappears
--- PASS: TestAccAWSMskConfiguration_KafkaVersions (35.21s)
--- PASS: TestAccAWSMskConfiguration_ServerProperties (37.94s)
--- PASS: TestAccAWSMskConfiguration_basic (38.60s)
--- PASS: TestAccAWSMskConfiguration_disappears (39.50s)
--- PASS: TestAccAWSMskConfiguration_Description (41.94s)
PASS
ok github.com/terraform-providers/terraform-provider-aws/aws 44.796s
@ryan-dyer-sp I added the CHANGELOG entry in order to get this merged quicker. |
@ewbankkit Thanks! its been a crazy week. |
This has been released in version 3.43.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Community Note
Closes #14324
Output from acceptance testing: