Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

14324 - Fix kafka_versions being a required field #17571

Merged
merged 4 commits into from
May 26, 2021

Conversation

ryan-dyer-sp
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #14324

Output from acceptance testing:

make testacc TESTARGS='-run=TestAccAWSMskConfiguration'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSMskConfiguration -timeout 120m
=== RUN   TestAccAWSMskConfigurationDataSource_Name
=== PAUSE TestAccAWSMskConfigurationDataSource_Name
=== RUN   TestAccAWSMskConfiguration_basic
=== PAUSE TestAccAWSMskConfiguration_basic
=== RUN   TestAccAWSMskConfiguration_disappears
=== PAUSE TestAccAWSMskConfiguration_disappears
=== RUN   TestAccAWSMskConfiguration_Description
=== PAUSE TestAccAWSMskConfiguration_Description
=== RUN   TestAccAWSMskConfiguration_KafkaVersions
=== PAUSE TestAccAWSMskConfiguration_KafkaVersions
=== RUN   TestAccAWSMskConfiguration_ServerProperties
=== PAUSE TestAccAWSMskConfiguration_ServerProperties
=== CONT  TestAccAWSMskConfigurationDataSource_Name
=== CONT  TestAccAWSMskConfiguration_KafkaVersions
=== CONT  TestAccAWSMskConfiguration_ServerProperties
=== CONT  TestAccAWSMskConfiguration_disappears
=== CONT  TestAccAWSMskConfiguration_Description
=== CONT  TestAccAWSMskConfiguration_basic
--- PASS: TestAccAWSMskConfiguration_KafkaVersions (42.42s)
--- PASS: TestAccAWSMskConfigurationDataSource_Name (42.77s)
--- PASS: TestAccAWSMskConfiguration_disappears (50.25s)
--- PASS: TestAccAWSMskConfiguration_basic (50.45s)
--- PASS: TestAccAWSMskConfiguration_Description (54.28s)
--- PASS: TestAccAWSMskConfiguration_ServerProperties (76.16s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       76.265s

@ryan-dyer-sp ryan-dyer-sp requested a review from a team as a code owner February 11, 2021 20:09
@ghost ghost added size/XS Managed by automation to categorize the size of a PR. service/kafka Issues and PRs that pertain to the kafka service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Feb 11, 2021
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Feb 11, 2021
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @ryan-dyer-sp 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@ryan-dyer-sp ryan-dyer-sp changed the title 14324 - Fix kafka_versions being a required field [wip] 14324 - Fix kafka_versions being a required field Feb 11, 2021
@ryan-dyer-sp
Copy link
Contributor Author

ryan-dyer-sp commented Feb 11, 2021

For updating the changelog do I create a file in the .changelog directory corresponding to the issue ID or PR ID? And then do I do something else to render the CHANGELOG.md?

@ryan-dyer-sp
Copy link
Contributor Author

Need feedback

@ryan-dyer-sp
Copy link
Contributor Author

Still need feedback

@ewbankkit
Copy link
Contributor

@ryan-dyer-sp Thanks for the contribution 👏.
The CHANGELOG entry process is documented here.
The actual changes to CHANGELOG.md are performed by a GitHub action.

@ewbankkit ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label May 26, 2021
@ewbankkit ewbankkit changed the title [wip] 14324 - Fix kafka_versions being a required field 14324 - Fix kafka_versions being a required field May 26, 2021
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

Commercial
% make testacc TEST=./aws TESTARGS='-run=TestAccAWSMskConfiguration_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSMskConfiguration_ -timeout 120m
=== RUN   TestAccAWSMskConfiguration_basic
=== PAUSE TestAccAWSMskConfiguration_basic
=== RUN   TestAccAWSMskConfiguration_disappears
=== PAUSE TestAccAWSMskConfiguration_disappears
=== RUN   TestAccAWSMskConfiguration_Description
=== PAUSE TestAccAWSMskConfiguration_Description
=== RUN   TestAccAWSMskConfiguration_KafkaVersions
=== PAUSE TestAccAWSMskConfiguration_KafkaVersions
=== RUN   TestAccAWSMskConfiguration_ServerProperties
=== PAUSE TestAccAWSMskConfiguration_ServerProperties
=== CONT  TestAccAWSMskConfiguration_basic
=== CONT  TestAccAWSMskConfiguration_KafkaVersions
=== CONT  TestAccAWSMskConfiguration_Description
=== CONT  TestAccAWSMskConfiguration_ServerProperties
=== CONT  TestAccAWSMskConfiguration_disappears
--- PASS: TestAccAWSMskConfiguration_disappears (12.14s)
--- PASS: TestAccAWSMskConfiguration_KafkaVersions (21.48s)
--- PASS: TestAccAWSMskConfiguration_basic (22.88s)
--- PASS: TestAccAWSMskConfiguration_ServerProperties (26.26s)
--- PASS: TestAccAWSMskConfiguration_Description (31.01s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	34.448s                          
GovCloud
% make testacc TEST=./aws TESTARGS='-run=TestAccAWSMskConfiguration_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSMskConfiguration_ -timeout 120m
=== RUN   TestAccAWSMskConfiguration_basic
=== PAUSE TestAccAWSMskConfiguration_basic
=== RUN   TestAccAWSMskConfiguration_disappears
=== PAUSE TestAccAWSMskConfiguration_disappears
=== RUN   TestAccAWSMskConfiguration_Description
=== PAUSE TestAccAWSMskConfiguration_Description
=== RUN   TestAccAWSMskConfiguration_KafkaVersions
=== PAUSE TestAccAWSMskConfiguration_KafkaVersions
=== RUN   TestAccAWSMskConfiguration_ServerProperties
=== PAUSE TestAccAWSMskConfiguration_ServerProperties
=== CONT  TestAccAWSMskConfiguration_basic
=== CONT  TestAccAWSMskConfiguration_KafkaVersions
=== CONT  TestAccAWSMskConfiguration_Description
=== CONT  TestAccAWSMskConfiguration_ServerProperties
=== CONT  TestAccAWSMskConfiguration_disappears
--- PASS: TestAccAWSMskConfiguration_KafkaVersions (35.21s)
--- PASS: TestAccAWSMskConfiguration_ServerProperties (37.94s)
--- PASS: TestAccAWSMskConfiguration_basic (38.60s)
--- PASS: TestAccAWSMskConfiguration_disappears (39.50s)
--- PASS: TestAccAWSMskConfiguration_Description (41.94s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	44.796s

@ewbankkit
Copy link
Contributor

ewbankkit commented May 26, 2021

@ryan-dyer-sp I added the CHANGELOG entry in order to get this merged quicker.
Thanks 🎉.

@ewbankkit ewbankkit merged commit 8a4d82b into hashicorp:main May 26, 2021
@github-actions github-actions bot added this to the v3.43.0 milestone May 26, 2021
@ryan-dyer-sp
Copy link
Contributor Author

@ewbankkit Thanks! its been a crazy week.

@ghost
Copy link

ghost commented Jun 1, 2021

This has been released in version 3.43.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@github-actions
Copy link

github-actions bot commented Jul 2, 2021

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
service/kafka Issues and PRs that pertain to the kafka service. size/XS Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to create MSK configuration with no kafka_versions
2 participants