New data source aws_ec2_transit_gateway_route_tables

[mattrobinsonsre]

Greetings. This is my first attempt to contribute to any public terraform provider and go is not even slightly my first language.

This is to resolve issue #12373 which I would like to resolve for selfish reasons as it affects me. It seemed like a good place to start contributing as I'm a heavy user of the really rather excellent provider.

The new data source "aws_ec2_transit_gateway_route_tables" is modelled after "aws_route_tables". The code is shamelessly plagiarised from the aws_route_tables and the aws_transit_gateway_route_table data sources.

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #12373

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSEc2TransitGatewayRouteTablesDataSource_TransitGatewayFilter'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSEc2TransitGatewayRouteTablesDataSource_TransitGatewayFilter -timeout 120m
=== RUN   TestAccAWSEc2TransitGatewayRouteTablesDataSource_TransitGatewayFilter
=== PAUSE TestAccAWSEc2TransitGatewayRouteTablesDataSource_TransitGatewayFilter
=== CONT  TestAccAWSEc2TransitGatewayRouteTablesDataSource_TransitGatewayFilter
--- PASS: TestAccAWSEc2TransitGatewayRouteTablesDataSource_TransitGatewayFilter (347.78s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	349.965s

[anGie44]

Hi @mrobinson-anaplan, thank you for this PR! overall looked in great condition 👍 To get this into an upcoming release, I've gone ahead and made some changes related to the Route Table filtering. In short, since we can use the filter block to filter by transit gateway, i've removed that field from the schema to make the filtering uniform for users. With that said, additional changes in the test and documentation reflect the changes made in the data source filtering.

[anGie44]

Thanks again @mrobinson-anaplan 🚀 !

Output of acceptance tests (commercial):

--- PASS: TestAccDataSourceAwsEc2TransitGatewayRouteTables_Filter (358.86s)
--- PASS: TestAccDataSourceAwsEc2TransitGatewayRouteTables_basic (368.72s)

[mattrobinsonsre]

Thanks @anGie44

[ghost]

This has been released in version 3.33.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!