Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/ses_configuration_set - add reputation and sending options #17608

Merged

Conversation

DrFaust92
Copy link
Collaborator

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #11747

Output from acceptance testing:

$ make testacc TESTARGS='-run=-run=TestAccAWSSESConfigurationSet_'
--- PASS: TestAccAWSSESConfigurationSet_disappears (29.86s)
--- PASS: TestAccAWSSESConfigurationSet_emptyDeliveryOptions (39.73s)
--- PASS: TestAccAWSSESConfigurationSet_basic (40.14s)
--- PASS: TestAccAWSSESConfigurationSet_deliveryOptions (41.44s)
--- PASS: TestAccAWSSESConfigurationSet_sendingEnabled (86.97s)
--- PASS: TestAccAWSSESConfigurationSet_reputationMetricsEnabled (89.50s)
--- PASS: TestAccAWSSESConfigurationSet_update_emptyDeliveryOptions (90.77s)
--- PASS: TestAccAWSSESConfigurationSet_update_deliveryOptions (116.87s)

@DrFaust92 DrFaust92 requested a review from a team as a code owner February 13, 2021 22:47
@ghost ghost added size/L Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/ses Issues and PRs that pertain to the ses service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Feb 13, 2021
@DrFaust92 DrFaust92 added the enhancement Requests to existing resources that expand the functionality or scope. label Feb 13, 2021
@DrFaust92 DrFaust92 changed the title R/ses_configuration_set - add reputation options r/ses_configuration_set - add reputation options Feb 13, 2021
@marns93
Copy link

marns93 commented Mar 2, 2021

@DrFaust92 I'm very interested in this feature. Are there any plans when it will be merged?

@DrFaust92 DrFaust92 changed the title r/ses_configuration_set - add reputation options r/ses_configuration_set - add reputation and sending options Mar 2, 2021
@DrFaust92 DrFaust92 force-pushed the r/ses_confiugration_set_reputation branch from 111391e to 4fbd66b Compare March 27, 2021 16:49
@ewbankkit ewbankkit self-assigned this Apr 27, 2021
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

Commercial
% make testacc TEST=./aws TESTARGS='-run=TestAccAWSSESConfigurationSet_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSSESConfigurationSet_ -timeout 180m
=== RUN   TestAccAWSSESConfigurationSet_basic
=== PAUSE TestAccAWSSESConfigurationSet_basic
=== RUN   TestAccAWSSESConfigurationSet_sendingEnabled
=== PAUSE TestAccAWSSESConfigurationSet_sendingEnabled
=== RUN   TestAccAWSSESConfigurationSet_reputationMetricsEnabled
=== PAUSE TestAccAWSSESConfigurationSet_reputationMetricsEnabled
=== RUN   TestAccAWSSESConfigurationSet_deliveryOptions
=== PAUSE TestAccAWSSESConfigurationSet_deliveryOptions
=== RUN   TestAccAWSSESConfigurationSet_update_deliveryOptions
=== PAUSE TestAccAWSSESConfigurationSet_update_deliveryOptions
=== RUN   TestAccAWSSESConfigurationSet_emptyDeliveryOptions
=== PAUSE TestAccAWSSESConfigurationSet_emptyDeliveryOptions
=== RUN   TestAccAWSSESConfigurationSet_update_emptyDeliveryOptions
=== PAUSE TestAccAWSSESConfigurationSet_update_emptyDeliveryOptions
=== RUN   TestAccAWSSESConfigurationSet_disappears
=== PAUSE TestAccAWSSESConfigurationSet_disappears
=== CONT  TestAccAWSSESConfigurationSet_basic
=== CONT  TestAccAWSSESConfigurationSet_emptyDeliveryOptions
=== CONT  TestAccAWSSESConfigurationSet_update_deliveryOptions
=== CONT  TestAccAWSSESConfigurationSet_update_emptyDeliveryOptions
=== CONT  TestAccAWSSESConfigurationSet_deliveryOptions
=== CONT  TestAccAWSSESConfigurationSet_reputationMetricsEnabled
=== CONT  TestAccAWSSESConfigurationSet_sendingEnabled
=== CONT  TestAccAWSSESConfigurationSet_disappears
--- PASS: TestAccAWSSESConfigurationSet_disappears (14.93s)
--- PASS: TestAccAWSSESConfigurationSet_deliveryOptions (18.93s)
--- PASS: TestAccAWSSESConfigurationSet_emptyDeliveryOptions (20.33s)
--- PASS: TestAccAWSSESConfigurationSet_basic (20.43s)
--- PASS: TestAccAWSSESConfigurationSet_update_emptyDeliveryOptions (35.56s)
--- PASS: TestAccAWSSESConfigurationSet_sendingEnabled (36.42s)
--- PASS: TestAccAWSSESConfigurationSet_reputationMetricsEnabled (36.59s)
--- PASS: TestAccAWSSESConfigurationSet_update_deliveryOptions (47.55s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	50.396s
GovCloud
% make testacc TEST=./aws TESTARGS='-run=TestAccAWSSESConfigurationSet_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSSESConfigurationSet_ -timeout 180m
=== RUN   TestAccAWSSESConfigurationSet_basic
=== PAUSE TestAccAWSSESConfigurationSet_basic
=== RUN   TestAccAWSSESConfigurationSet_sendingEnabled
=== PAUSE TestAccAWSSESConfigurationSet_sendingEnabled
=== RUN   TestAccAWSSESConfigurationSet_reputationMetricsEnabled
=== PAUSE TestAccAWSSESConfigurationSet_reputationMetricsEnabled
=== RUN   TestAccAWSSESConfigurationSet_deliveryOptions
=== PAUSE TestAccAWSSESConfigurationSet_deliveryOptions
=== RUN   TestAccAWSSESConfigurationSet_update_deliveryOptions
=== PAUSE TestAccAWSSESConfigurationSet_update_deliveryOptions
=== RUN   TestAccAWSSESConfigurationSet_emptyDeliveryOptions
=== PAUSE TestAccAWSSESConfigurationSet_emptyDeliveryOptions
=== RUN   TestAccAWSSESConfigurationSet_update_emptyDeliveryOptions
=== PAUSE TestAccAWSSESConfigurationSet_update_emptyDeliveryOptions
=== RUN   TestAccAWSSESConfigurationSet_disappears
=== PAUSE TestAccAWSSESConfigurationSet_disappears
=== CONT  TestAccAWSSESConfigurationSet_basic
=== CONT  TestAccAWSSESConfigurationSet_emptyDeliveryOptions
=== CONT  TestAccAWSSESConfigurationSet_disappears
=== CONT  TestAccAWSSESConfigurationSet_deliveryOptions
=== CONT  TestAccAWSSESConfigurationSet_update_emptyDeliveryOptions
=== CONT  TestAccAWSSESConfigurationSet_update_deliveryOptions
=== CONT  TestAccAWSSESConfigurationSet_reputationMetricsEnabled
=== CONT  TestAccAWSSESConfigurationSet_sendingEnabled
--- PASS: TestAccAWSSESConfigurationSet_disappears (15.66s)
--- PASS: TestAccAWSSESConfigurationSet_basic (19.10s)
--- PASS: TestAccAWSSESConfigurationSet_deliveryOptions (21.92s)
--- PASS: TestAccAWSSESConfigurationSet_emptyDeliveryOptions (22.95s)
--- PASS: TestAccAWSSESConfigurationSet_sendingEnabled (44.70s)
--- PASS: TestAccAWSSESConfigurationSet_reputationMetricsEnabled (44.79s)
--- PASS: TestAccAWSSESConfigurationSet_update_emptyDeliveryOptions (46.04s)
--- PASS: TestAccAWSSESConfigurationSet_update_deliveryOptions (62.06s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	64.901s

@ewbankkit ewbankkit merged commit 38baa6e into hashicorp:main Apr 27, 2021
@ewbankkit ewbankkit added this to the v3.38.0 milestone Apr 27, 2021
@ghost
Copy link

ghost commented Apr 30, 2021

This has been released in version 3.38.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 31, 2021
@DrFaust92 DrFaust92 deleted the r/ses_confiugration_set_reputation branch May 31, 2021 05:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/ses Issues and PRs that pertain to the ses service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for Exporting of Reputation Metrics for a Configuration Set
3 participants