-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
r/ses_configuration_set - add reputation and sending options #17608
r/ses_configuration_set - add reputation and sending options #17608
Conversation
@DrFaust92 I'm very interested in this feature. Are there any plans when it will be merged? |
111391e
to
4fbd66b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
Commercial
% make testacc TEST=./aws TESTARGS='-run=TestAccAWSSESConfigurationSet_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSSESConfigurationSet_ -timeout 180m
=== RUN TestAccAWSSESConfigurationSet_basic
=== PAUSE TestAccAWSSESConfigurationSet_basic
=== RUN TestAccAWSSESConfigurationSet_sendingEnabled
=== PAUSE TestAccAWSSESConfigurationSet_sendingEnabled
=== RUN TestAccAWSSESConfigurationSet_reputationMetricsEnabled
=== PAUSE TestAccAWSSESConfigurationSet_reputationMetricsEnabled
=== RUN TestAccAWSSESConfigurationSet_deliveryOptions
=== PAUSE TestAccAWSSESConfigurationSet_deliveryOptions
=== RUN TestAccAWSSESConfigurationSet_update_deliveryOptions
=== PAUSE TestAccAWSSESConfigurationSet_update_deliveryOptions
=== RUN TestAccAWSSESConfigurationSet_emptyDeliveryOptions
=== PAUSE TestAccAWSSESConfigurationSet_emptyDeliveryOptions
=== RUN TestAccAWSSESConfigurationSet_update_emptyDeliveryOptions
=== PAUSE TestAccAWSSESConfigurationSet_update_emptyDeliveryOptions
=== RUN TestAccAWSSESConfigurationSet_disappears
=== PAUSE TestAccAWSSESConfigurationSet_disappears
=== CONT TestAccAWSSESConfigurationSet_basic
=== CONT TestAccAWSSESConfigurationSet_emptyDeliveryOptions
=== CONT TestAccAWSSESConfigurationSet_update_deliveryOptions
=== CONT TestAccAWSSESConfigurationSet_update_emptyDeliveryOptions
=== CONT TestAccAWSSESConfigurationSet_deliveryOptions
=== CONT TestAccAWSSESConfigurationSet_reputationMetricsEnabled
=== CONT TestAccAWSSESConfigurationSet_sendingEnabled
=== CONT TestAccAWSSESConfigurationSet_disappears
--- PASS: TestAccAWSSESConfigurationSet_disappears (14.93s)
--- PASS: TestAccAWSSESConfigurationSet_deliveryOptions (18.93s)
--- PASS: TestAccAWSSESConfigurationSet_emptyDeliveryOptions (20.33s)
--- PASS: TestAccAWSSESConfigurationSet_basic (20.43s)
--- PASS: TestAccAWSSESConfigurationSet_update_emptyDeliveryOptions (35.56s)
--- PASS: TestAccAWSSESConfigurationSet_sendingEnabled (36.42s)
--- PASS: TestAccAWSSESConfigurationSet_reputationMetricsEnabled (36.59s)
--- PASS: TestAccAWSSESConfigurationSet_update_deliveryOptions (47.55s)
PASS
ok github.com/terraform-providers/terraform-provider-aws/aws 50.396s
GovCloud
% make testacc TEST=./aws TESTARGS='-run=TestAccAWSSESConfigurationSet_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSSESConfigurationSet_ -timeout 180m
=== RUN TestAccAWSSESConfigurationSet_basic
=== PAUSE TestAccAWSSESConfigurationSet_basic
=== RUN TestAccAWSSESConfigurationSet_sendingEnabled
=== PAUSE TestAccAWSSESConfigurationSet_sendingEnabled
=== RUN TestAccAWSSESConfigurationSet_reputationMetricsEnabled
=== PAUSE TestAccAWSSESConfigurationSet_reputationMetricsEnabled
=== RUN TestAccAWSSESConfigurationSet_deliveryOptions
=== PAUSE TestAccAWSSESConfigurationSet_deliveryOptions
=== RUN TestAccAWSSESConfigurationSet_update_deliveryOptions
=== PAUSE TestAccAWSSESConfigurationSet_update_deliveryOptions
=== RUN TestAccAWSSESConfigurationSet_emptyDeliveryOptions
=== PAUSE TestAccAWSSESConfigurationSet_emptyDeliveryOptions
=== RUN TestAccAWSSESConfigurationSet_update_emptyDeliveryOptions
=== PAUSE TestAccAWSSESConfigurationSet_update_emptyDeliveryOptions
=== RUN TestAccAWSSESConfigurationSet_disappears
=== PAUSE TestAccAWSSESConfigurationSet_disappears
=== CONT TestAccAWSSESConfigurationSet_basic
=== CONT TestAccAWSSESConfigurationSet_emptyDeliveryOptions
=== CONT TestAccAWSSESConfigurationSet_disappears
=== CONT TestAccAWSSESConfigurationSet_deliveryOptions
=== CONT TestAccAWSSESConfigurationSet_update_emptyDeliveryOptions
=== CONT TestAccAWSSESConfigurationSet_update_deliveryOptions
=== CONT TestAccAWSSESConfigurationSet_reputationMetricsEnabled
=== CONT TestAccAWSSESConfigurationSet_sendingEnabled
--- PASS: TestAccAWSSESConfigurationSet_disappears (15.66s)
--- PASS: TestAccAWSSESConfigurationSet_basic (19.10s)
--- PASS: TestAccAWSSESConfigurationSet_deliveryOptions (21.92s)
--- PASS: TestAccAWSSESConfigurationSet_emptyDeliveryOptions (22.95s)
--- PASS: TestAccAWSSESConfigurationSet_sendingEnabled (44.70s)
--- PASS: TestAccAWSSESConfigurationSet_reputationMetricsEnabled (44.79s)
--- PASS: TestAccAWSSESConfigurationSet_update_emptyDeliveryOptions (46.04s)
--- PASS: TestAccAWSSESConfigurationSet_update_deliveryOptions (62.06s)
PASS
ok github.com/terraform-providers/terraform-provider-aws/aws 64.901s
This has been released in version 3.38.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Community Note
Closes #11747
Output from acceptance testing: