Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

data-source/aws_vpc_endpoint_service: Switch service_type filtering from client-side to API #17641

Merged
merged 3 commits into from
Mar 18, 2021
Merged

data-source/aws_vpc_endpoint_service: Switch service_type filtering from client-side to API #17641

merged 3 commits into from
Mar 18, 2021

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Feb 16, 2021 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Reference: #17417
Closes #17419

Output from acceptance testing in AWS Commercial:

--- PASS: TestAccDataSourceAwsVpcEndpointService_interface (12.25s)
--- PASS: TestAccDataSourceAwsVpcEndpointService_ServiceType_Interface (12.65s)
--- PASS: TestAccDataSourceAwsVpcEndpointService_ServiceType_Gateway (12.65s)
--- PASS: TestAccDataSourceAwsVpcEndpointService_gateway (12.65s)
--- PASS: TestAccDataSourceAwsVpcEndpointService_custom (217.41s)
--- PASS: TestAccDataSourceAwsVpcEndpointService_custom_filter (219.87s)
--- PASS: TestAccDataSourceAwsVpcEndpointService_custom_filter_tags (228.91s)

Output from acceptance testing in AWS GovCloud (US):

--- PASS: TestAccDataSourceAwsVpcEndpointService_gateway (16.05s)
--- PASS: TestAccDataSourceAwsVpcEndpointService_interface (16.25s)
--- PASS: TestAccDataSourceAwsVpcEndpointService_ServiceType_Interface (16.26s)
--- PASS: TestAccDataSourceAwsVpcEndpointService_ServiceType_Gateway (16.26s)
--- PASS: TestAccDataSourceAwsVpcEndpointService_custom_filter_tags (229.07s)
--- PASS: TestAccDataSourceAwsVpcEndpointService_custom (229.30s)
--- PASS: TestAccDataSourceAwsVpcEndpointService_custom_filter (229.52s)

@bflad
data-soruce/aws_vpc_endpoint_service: Switch service_type filtering f…
4ce56d8 
…rom client-side to API

Reference: #17417

Output from acceptance testing in AWS Commercial:

```
--- PASS: TestAccDataSourceAwsVpcEndpointService_interface (12.25s)
--- PASS: TestAccDataSourceAwsVpcEndpointService_ServiceType_Interface (12.65s)
--- PASS: TestAccDataSourceAwsVpcEndpointService_ServiceType_Gateway (12.65s)
--- PASS: TestAccDataSourceAwsVpcEndpointService_gateway (12.65s)
--- PASS: TestAccDataSourceAwsVpcEndpointService_custom (217.41s)
--- PASS: TestAccDataSourceAwsVpcEndpointService_custom_filter (219.87s)
--- PASS: TestAccDataSourceAwsVpcEndpointService_custom_filter_tags (228.91s)
```

Output from acceptance testing in AWS GovCloud (US):

```
--- PASS: TestAccDataSourceAwsVpcEndpointService_gateway (16.05s)
--- PASS: TestAccDataSourceAwsVpcEndpointService_interface (16.25s)
--- PASS: TestAccDataSourceAwsVpcEndpointService_ServiceType_Interface (16.26s)
--- PASS: TestAccDataSourceAwsVpcEndpointService_ServiceType_Gateway (16.26s)
--- PASS: TestAccDataSourceAwsVpcEndpointService_custom_filter_tags (229.07s)
--- PASS: TestAccDataSourceAwsVpcEndpointService_custom (229.30s)
--- PASS: TestAccDataSourceAwsVpcEndpointService_custom_filter (229.52s)
```
@bflad bflad added the technical-debt Addresses areas of the codebase that need refactoring or redesign. label Feb 16, 2021
@bflad bflad requested a review from a team as a code owner February 16, 2021 17:57
@ghost ghost added size/S Managed by automation to categorize the size of a PR. service/ec2 Issues and PRs that pertain to the ec2 service. labels Feb 16, 2021
@bflad bflad changed the title data-soruce/aws_vpc_endpoint_service: Switch service_type filtering from client-side to API data-source/aws_vpc_endpoint_service: Switch service_type filtering from client-side to API Feb 16, 2021
@ewbankkit
Copy link
Contributor

It looks like this will also fix #17419.

@bflad bflad added bug Addresses a defect in current functionality. crash Results from or addresses a Terraform crash or kernel panic. and removed technical-debt Addresses areas of the codebase that need refactoring or redesign. labels Feb 16, 2021
@bflad
data-source/aws_vpc_endpoint_service: Validate service_type argument,…
03d69c4 
… update CHANGELOG for #17641

Reference: #17419

Output from acceptance testing in AWS Commercial:

```
--- PASS: TestAccDataSourceAwsVpcEndpointService_interface (21.03s)
--- PASS: TestAccDataSourceAwsVpcEndpointService_ServiceType_Interface (22.39s)
--- PASS: TestAccDataSourceAwsVpcEndpointService_ServiceType_Gateway (22.48s)
--- PASS: TestAccDataSourceAwsVpcEndpointService_gateway (23.76s)
--- PASS: TestAccDataSourceAwsVpcEndpointService_custom_filter (230.43s)
--- PASS: TestAccDataSourceAwsVpcEndpointService_custom_filter_tags (235.33s)
--- PASS: TestAccDataSourceAwsVpcEndpointService_custom (238.79s)
```

Output from acceptance testing in AWS GovCloud (US):

```
--- PASS: TestAccDataSourceAwsVpcEndpointService_interface (30.12s)
--- PASS: TestAccDataSourceAwsVpcEndpointService_ServiceType_Interface (30.15s)
--- PASS: TestAccDataSourceAwsVpcEndpointService_gateway (30.16s)
--- PASS: TestAccDataSourceAwsVpcEndpointService_ServiceType_Gateway (30.16s)
--- PASS: TestAccDataSourceAwsVpcEndpointService_custom_filter_tags (249.96s)
--- PASS: TestAccDataSourceAwsVpcEndpointService_custom (259.01s)
--- PASS: TestAccDataSourceAwsVpcEndpointService_custom_filter (261.24s)
```
anGie44
anGie44 approved these changes Mar 18, 2021
View reviewed changes
Copy link
Contributor

@anGie44 anGie44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet, LGTM 👍

@bflad bflad merged commit e1df570 into main Mar 18, 2021
@bflad bflad deleted the td-aws_vpc_endpoint_service-service_type-api branch March 18, 2021 23:09
@github-actions github-actions bot added this to the v3.33.0 milestone Mar 18, 2021
github-actions bot pushed a commit that referenced this pull request Mar 18, 2021
Update CHANGELOG.md for #17641
3f3b22c
@ghost
Copy link

ghost commented Mar 18, 2021

This has been released in version 3.33.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Apr 18, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Apr 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@anGie44 anGie44 anGie44 approved these changes

Assignees
No one assigned
Labels
bug Addresses a defect in current functionality. crash Results from or addresses a Terraform crash or kernel panic. service/ec2 Issues and PRs that pertain to the ec2 service. size/S Managed by automation to categorize the size of a PR.
Projects
None yet
Milestone
v3.33.0
Development

Successfully merging this pull request may close these issues.

Crash with bad service_type in aws_vpc_endpoint_service
3 participants
@bflad @ewbankkit @anGie44