Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

F/destination_outpost_arn support in aws_ami_copy #17735

Merged
merged 4 commits into from
May 11, 2021

Conversation

nikhil-goenka
Copy link
Contributor

@nikhil-goenka nikhil-goenka commented Feb 20, 2021

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #17490.

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSAMICopy_DestinationOutpost'
=== RUN   TestAccAWSAMICopy_DestinationOutpost
=== PAUSE TestAccAWSAMICopy_DestinationOutpost
=== CONT  TestAccAWSAMICopy_DestinationOutpost
    data_source_aws_outposts_outposts_test.go:66: skipping since no Outposts found
--- SKIP: TestAccAWSAMICopy_DestinationOutpost (5.15s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	9.235s
...

@nikhil-goenka nikhil-goenka requested a review from a team as a code owner February 20, 2021 19:59
@ghost ghost added size/M Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/ec2 Issues and PRs that pertain to the ec2 service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Feb 20, 2021
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Feb 20, 2021
@ewbankkit ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label May 11, 2021
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

Commercial
% make testacc TEST=./aws TESTARGS='-run=TestAccAWSAMICopy_'                              
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSAMICopy_ -timeout 180m
=== RUN   TestAccAWSAMICopy_basic
=== PAUSE TestAccAWSAMICopy_basic
=== RUN   TestAccAWSAMICopy_Description
=== PAUSE TestAccAWSAMICopy_Description
=== RUN   TestAccAWSAMICopy_EnaSupport
=== PAUSE TestAccAWSAMICopy_EnaSupport
=== RUN   TestAccAWSAMICopy_DestinationOutpost
=== PAUSE TestAccAWSAMICopy_DestinationOutpost
=== RUN   TestAccAWSAMICopy_tags
=== PAUSE TestAccAWSAMICopy_tags
=== CONT  TestAccAWSAMICopy_basic
=== CONT  TestAccAWSAMICopy_DestinationOutpost
=== CONT  TestAccAWSAMICopy_tags
=== CONT  TestAccAWSAMICopy_EnaSupport
=== CONT  TestAccAWSAMICopy_Description
=== CONT  TestAccAWSAMICopy_DestinationOutpost
    data_source_aws_outposts_outposts_test.go:67: skipping since no Outposts found
--- SKIP: TestAccAWSAMICopy_DestinationOutpost (1.55s)
--- PASS: TestAccAWSAMICopy_EnaSupport (360.32s)
--- PASS: TestAccAWSAMICopy_basic (360.46s)
--- PASS: TestAccAWSAMICopy_Description (386.02s)
--- PASS: TestAccAWSAMICopy_tags (399.09s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	402.185s
GovCloud
% make testacc TEST=./aws TESTARGS='-run=TestAccAWSAMICopy_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSAMICopy_ -timeout 180m
=== RUN   TestAccAWSAMICopy_basic
=== PAUSE TestAccAWSAMICopy_basic
=== RUN   TestAccAWSAMICopy_Description
=== PAUSE TestAccAWSAMICopy_Description
=== RUN   TestAccAWSAMICopy_EnaSupport
=== PAUSE TestAccAWSAMICopy_EnaSupport
=== RUN   TestAccAWSAMICopy_DestinationOutpost
=== PAUSE TestAccAWSAMICopy_DestinationOutpost
=== RUN   TestAccAWSAMICopy_tags
=== PAUSE TestAccAWSAMICopy_tags
=== CONT  TestAccAWSAMICopy_basic
=== CONT  TestAccAWSAMICopy_DestinationOutpost
=== CONT  TestAccAWSAMICopy_tags
=== CONT  TestAccAWSAMICopy_EnaSupport
=== CONT  TestAccAWSAMICopy_Description
=== CONT  TestAccAWSAMICopy_DestinationOutpost
    data_source_aws_outposts_outposts_test.go:67: skipping since no Outposts found
--- SKIP: TestAccAWSAMICopy_DestinationOutpost (2.02s)
--- PASS: TestAccAWSAMICopy_EnaSupport (376.32s)
--- PASS: TestAccAWSAMICopy_basic (377.22s)
--- PASS: TestAccAWSAMICopy_Description (401.43s)
--- PASS: TestAccAWSAMICopy_tags (408.03s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	411.031s

@ewbankkit ewbankkit merged commit 098aacb into hashicorp:main May 11, 2021
@github-actions github-actions bot added this to the v3.40.0 milestone May 11, 2021
@ghost
Copy link

ghost commented May 13, 2021

This has been released in version 3.40.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@nikhil-goenka nikhil-goenka deleted the f/aws_ami_copy branch May 14, 2021 10:08
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. service/ec2 Issues and PRs that pertain to the ec2 service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

outpost_arn support in aws_ami_copy
2 participants