Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for AMAZON_LINUX_2 in the aws_gamelift_build resource #17763

Closed
judgeaxl opened this issue Feb 23, 2021 · 3 comments · Fixed by #17764
Closed

Support for AMAZON_LINUX_2 in the aws_gamelift_build resource #17763

judgeaxl opened this issue Feb 23, 2021 · 3 comments · Fixed by #17764
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/gamelift Issues and PRs that pertain to the gamelift service.
Milestone

Comments

@judgeaxl
Copy link
Contributor

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

aws_gamelift_build doesn't support the AMAZON_LINUX_2 platform, which has been in the AWS SDK since 2019. Are there any known reasons for not adding that as a valid option to the resource? If not, I'm happy to provide a PR. As far as I can tell there are no other changes needed than simply adding the enum to the resource validation logic.

New or Affected Resource(s)

  • aws_gamelift_build
@judgeaxl judgeaxl added the enhancement Requests to existing resources that expand the functionality or scope. label Feb 23, 2021
@ghost ghost added the service/gamelift Issues and PRs that pertain to the gamelift service. label Feb 23, 2021
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Feb 23, 2021
@ewbankkit
Copy link
Contributor

Relates:

Changing

ValidateFunc: validation.StringInSlice([]string{
gamelift.OperatingSystemAmazonLinux,
gamelift.OperatingSystemWindows2012,
}, false),

to

ValidateFunc: validation.StringInSlice(gamelift.OperatingSystem_Values(), false),

will fix this.

@ewbankkit ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label Feb 23, 2021
@anGie44 anGie44 added this to the v3.30.0 milestone Feb 25, 2021
@ghost
Copy link

ghost commented Feb 26, 2021

This has been released in version 3.30.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Mar 27, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Mar 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/gamelift Issues and PRs that pertain to the gamelift service.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants