Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_kinesis_analytics_application: Add 'start_application' attribute #17784

Conversation

ewbankkit
Copy link
Contributor

@ewbankkit ewbankkit commented Feb 23, 2021

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #7383.

Inspired by the aws_synthetics_canary start_canary attribute.

Output from acceptance testing:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSKinesisAnalyticsApplication_' ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 3 -run=TestAccAWSKinesisAnalyticsApplication_ -timeout 120m
=== RUN   TestAccAWSKinesisAnalyticsApplication_basic
=== PAUSE TestAccAWSKinesisAnalyticsApplication_basic
=== RUN   TestAccAWSKinesisAnalyticsApplication_disappears
=== PAUSE TestAccAWSKinesisAnalyticsApplication_disappears
=== RUN   TestAccAWSKinesisAnalyticsApplication_Tags
=== PAUSE TestAccAWSKinesisAnalyticsApplication_Tags
=== RUN   TestAccAWSKinesisAnalyticsApplication_Code_Update
=== PAUSE TestAccAWSKinesisAnalyticsApplication_Code_Update
=== RUN   TestAccAWSKinesisAnalyticsApplication_CloudWatchLoggingOptions_Add
=== PAUSE TestAccAWSKinesisAnalyticsApplication_CloudWatchLoggingOptions_Add
=== RUN   TestAccAWSKinesisAnalyticsApplication_CloudWatchLoggingOptions_Delete
=== PAUSE TestAccAWSKinesisAnalyticsApplication_CloudWatchLoggingOptions_Delete
=== RUN   TestAccAWSKinesisAnalyticsApplication_CloudWatchLoggingOptions_Update
=== PAUSE TestAccAWSKinesisAnalyticsApplication_CloudWatchLoggingOptions_Update
=== RUN   TestAccAWSKinesisAnalyticsApplication_Input_Add
=== PAUSE TestAccAWSKinesisAnalyticsApplication_Input_Add
=== RUN   TestAccAWSKinesisAnalyticsApplication_Input_Update
=== PAUSE TestAccAWSKinesisAnalyticsApplication_Input_Update
=== RUN   TestAccAWSKinesisAnalyticsApplication_InputProcessingConfiguration_Add
=== PAUSE TestAccAWSKinesisAnalyticsApplication_InputProcessingConfiguration_Add
=== RUN   TestAccAWSKinesisAnalyticsApplication_InputProcessingConfiguration_Delete
=== PAUSE TestAccAWSKinesisAnalyticsApplication_InputProcessingConfiguration_Delete
=== RUN   TestAccAWSKinesisAnalyticsApplication_InputProcessingConfiguration_Update
=== PAUSE TestAccAWSKinesisAnalyticsApplication_InputProcessingConfiguration_Update
=== RUN   TestAccAWSKinesisAnalyticsApplication_Multiple_Update
=== PAUSE TestAccAWSKinesisAnalyticsApplication_Multiple_Update
=== RUN   TestAccAWSKinesisAnalyticsApplication_Output_Update
=== PAUSE TestAccAWSKinesisAnalyticsApplication_Output_Update
=== RUN   TestAccAWSKinesisAnalyticsApplication_ReferenceDataSource_Add
=== PAUSE TestAccAWSKinesisAnalyticsApplication_ReferenceDataSource_Add
=== RUN   TestAccAWSKinesisAnalyticsApplication_ReferenceDataSource_Delete
=== PAUSE TestAccAWSKinesisAnalyticsApplication_ReferenceDataSource_Delete
=== RUN   TestAccAWSKinesisAnalyticsApplication_ReferenceDataSource_Update
=== PAUSE TestAccAWSKinesisAnalyticsApplication_ReferenceDataSource_Update
=== RUN   TestAccAWSKinesisAnalyticsApplication_StartApplication_OnCreate
=== PAUSE TestAccAWSKinesisAnalyticsApplication_StartApplication_OnCreate
=== RUN   TestAccAWSKinesisAnalyticsApplication_StartApplication_OnUpdate
=== PAUSE TestAccAWSKinesisAnalyticsApplication_StartApplication_OnUpdate
=== RUN   TestAccAWSKinesisAnalyticsApplication_StartApplication_Update
=== PAUSE TestAccAWSKinesisAnalyticsApplication_StartApplication_Update
=== CONT  TestAccAWSKinesisAnalyticsApplication_basic
=== CONT  TestAccAWSKinesisAnalyticsApplication_InputProcessingConfiguration_Update
=== CONT  TestAccAWSKinesisAnalyticsApplication_StartApplication_Update
--- PASS: TestAccAWSKinesisAnalyticsApplication_basic (16.32s)
=== CONT  TestAccAWSKinesisAnalyticsApplication_StartApplication_OnUpdate
--- PASS: TestAccAWSKinesisAnalyticsApplication_InputProcessingConfiguration_Update (99.93s)
=== CONT  TestAccAWSKinesisAnalyticsApplication_StartApplication_OnCreate
--- PASS: TestAccAWSKinesisAnalyticsApplication_StartApplication_OnUpdate (163.21s)
=== CONT  TestAccAWSKinesisAnalyticsApplication_ReferenceDataSource_Update
--- PASS: TestAccAWSKinesisAnalyticsApplication_ReferenceDataSource_Update (48.88s)
=== CONT  TestAccAWSKinesisAnalyticsApplication_ReferenceDataSource_Delete
--- PASS: TestAccAWSKinesisAnalyticsApplication_StartApplication_OnCreate (147.62s)
=== CONT  TestAccAWSKinesisAnalyticsApplication_ReferenceDataSource_Add
--- PASS: TestAccAWSKinesisAnalyticsApplication_ReferenceDataSource_Delete (41.52s)
=== CONT  TestAccAWSKinesisAnalyticsApplication_Output_Update
--- PASS: TestAccAWSKinesisAnalyticsApplication_ReferenceDataSource_Add (37.80s)
=== CONT  TestAccAWSKinesisAnalyticsApplication_Multiple_Update
--- PASS: TestAccAWSKinesisAnalyticsApplication_StartApplication_Update (377.13s)
=== CONT  TestAccAWSKinesisAnalyticsApplication_CloudWatchLoggingOptions_Update
--- PASS: TestAccAWSKinesisAnalyticsApplication_Multiple_Update (122.81s)
=== CONT  TestAccAWSKinesisAnalyticsApplication_InputProcessingConfiguration_Delete
--- PASS: TestAccAWSKinesisAnalyticsApplication_CloudWatchLoggingOptions_Update (40.96s)
=== CONT  TestAccAWSKinesisAnalyticsApplication_InputProcessingConfiguration_Add
--- PASS: TestAccAWSKinesisAnalyticsApplication_Output_Update (165.73s)
=== CONT  TestAccAWSKinesisAnalyticsApplication_Input_Update
=== CONT  TestAccAWSKinesisAnalyticsApplication_Input_Add
--- PASS: TestAccAWSKinesisAnalyticsApplication_Input_Update (97.37s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_InputProcessingConfiguration_Delete (127.42s)
=== CONT  TestAccAWSKinesisAnalyticsApplication_Code_Update
--- PASS: TestAccAWSKinesisAnalyticsApplication_InputProcessingConfiguration_Add (117.93s)
=== CONT  TestAccAWSKinesisAnalyticsApplication_CloudWatchLoggingOptions_Delete
--- PASS: TestAccAWSKinesisAnalyticsApplication_Code_Update (26.41s)
=== CONT  TestAccAWSKinesisAnalyticsApplication_CloudWatchLoggingOptions_Add
--- PASS: TestAccAWSKinesisAnalyticsApplication_CloudWatchLoggingOptions_Delete (40.00s)
=== CONT  TestAccAWSKinesisAnalyticsApplication_Tags
=== CONT  TestAccAWSKinesisAnalyticsApplication_disappears
--- PASS: TestAccAWSKinesisAnalyticsApplication_CloudWatchLoggingOptions_Add (41.22s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_Tags (34.84s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_disappears (24.64s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_Input_Add (104.83s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	637.969s

…f 'nil' when no application found (hashicorp#15945).

r/aws_kinesis_analytics_application: Implement 'd.IsNewResource()' checks in 'resourceAwsKinesisAnalyticsApplicationRead' (hashicorp#16796).

Acceptance test output:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSKinesisAnalyticsApplication_basic\|TestAccAWSKinesisAnalyticsApplication_disappears'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSKinesisAnalyticsApplication_basic\|TestAccAWSKinesisAnalyticsApplication_disappears -timeout 120m
=== RUN   TestAccAWSKinesisAnalyticsApplication_basic
=== PAUSE TestAccAWSKinesisAnalyticsApplication_basic
=== RUN   TestAccAWSKinesisAnalyticsApplication_disappears
=== PAUSE TestAccAWSKinesisAnalyticsApplication_disappears
=== CONT  TestAccAWSKinesisAnalyticsApplication_basic
=== CONT  TestAccAWSKinesisAnalyticsApplication_disappears
--- PASS: TestAccAWSKinesisAnalyticsApplication_basic (15.29s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_disappears (18.26s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	18.344s
This reverts commit c8e7b5de589ea625c00bfbea9924e24d11d17055.
…e (no new tests yet).

Acceptance test output:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSKinesisAnalyticsApplication_' ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 3 -run=TestAccAWSKinesisAnalyticsApplication_ -timeout 120m
=== RUN   TestAccAWSKinesisAnalyticsApplication_basic
=== PAUSE TestAccAWSKinesisAnalyticsApplication_basic
=== RUN   TestAccAWSKinesisAnalyticsApplication_disappears
=== PAUSE TestAccAWSKinesisAnalyticsApplication_disappears
=== RUN   TestAccAWSKinesisAnalyticsApplication_Tags
=== PAUSE TestAccAWSKinesisAnalyticsApplication_Tags
=== RUN   TestAccAWSKinesisAnalyticsApplication_Code_Update
=== PAUSE TestAccAWSKinesisAnalyticsApplication_Code_Update
=== RUN   TestAccAWSKinesisAnalyticsApplication_CloudWatchLoggingOptions_Add
=== PAUSE TestAccAWSKinesisAnalyticsApplication_CloudWatchLoggingOptions_Add
=== RUN   TestAccAWSKinesisAnalyticsApplication_CloudWatchLoggingOptions_Delete
=== PAUSE TestAccAWSKinesisAnalyticsApplication_CloudWatchLoggingOptions_Delete
=== RUN   TestAccAWSKinesisAnalyticsApplication_CloudWatchLoggingOptions_Update
=== PAUSE TestAccAWSKinesisAnalyticsApplication_CloudWatchLoggingOptions_Update
=== RUN   TestAccAWSKinesisAnalyticsApplication_Input_Add
=== PAUSE TestAccAWSKinesisAnalyticsApplication_Input_Add
=== RUN   TestAccAWSKinesisAnalyticsApplication_Input_Update
=== PAUSE TestAccAWSKinesisAnalyticsApplication_Input_Update
=== RUN   TestAccAWSKinesisAnalyticsApplication_InputProcessingConfiguration_Add
=== PAUSE TestAccAWSKinesisAnalyticsApplication_InputProcessingConfiguration_Add
=== RUN   TestAccAWSKinesisAnalyticsApplication_InputProcessingConfiguration_Delete
=== PAUSE TestAccAWSKinesisAnalyticsApplication_InputProcessingConfiguration_Delete
=== RUN   TestAccAWSKinesisAnalyticsApplication_InputProcessingConfiguration_Update
=== PAUSE TestAccAWSKinesisAnalyticsApplication_InputProcessingConfiguration_Update
=== RUN   TestAccAWSKinesisAnalyticsApplication_Multiple_Update
=== PAUSE TestAccAWSKinesisAnalyticsApplication_Multiple_Update
=== RUN   TestAccAWSKinesisAnalyticsApplication_Output_Update
=== PAUSE TestAccAWSKinesisAnalyticsApplication_Output_Update
=== RUN   TestAccAWSKinesisAnalyticsApplication_ReferenceDataSource_Add
=== PAUSE TestAccAWSKinesisAnalyticsApplication_ReferenceDataSource_Add
=== RUN   TestAccAWSKinesisAnalyticsApplication_ReferenceDataSource_Delete
=== PAUSE TestAccAWSKinesisAnalyticsApplication_ReferenceDataSource_Delete
=== RUN   TestAccAWSKinesisAnalyticsApplication_ReferenceDataSource_Update
=== PAUSE TestAccAWSKinesisAnalyticsApplication_ReferenceDataSource_Update
=== CONT  TestAccAWSKinesisAnalyticsApplication_basic
=== CONT  TestAccAWSKinesisAnalyticsApplication_InputProcessingConfiguration_Add
=== CONT  TestAccAWSKinesisAnalyticsApplication_ReferenceDataSource_Update
=== CONT  TestAccAWSKinesisAnalyticsApplication_ReferenceDataSource_Delete
--- PASS: TestAccAWSKinesisAnalyticsApplication_basic (16.73s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_ReferenceDataSource_Update (50.72s)
=== CONT  TestAccAWSKinesisAnalyticsApplication_ReferenceDataSource_Add
--- PASS: TestAccAWSKinesisAnalyticsApplication_ReferenceDataSource_Delete (42.70s)
=== CONT  TestAccAWSKinesisAnalyticsApplication_Output_Update
--- PASS: TestAccAWSKinesisAnalyticsApplication_ReferenceDataSource_Add (39.66s)
=== CONT  TestAccAWSKinesisAnalyticsApplication_Multiple_Update
--- PASS: TestAccAWSKinesisAnalyticsApplication_InputProcessingConfiguration_Add (119.59s)
=== CONT  TestAccAWSKinesisAnalyticsApplication_InputProcessingConfiguration_Update
--- PASS: TestAccAWSKinesisAnalyticsApplication_Output_Update (115.04s)
=== CONT  TestAccAWSKinesisAnalyticsApplication_InputProcessingConfiguration_Delete
--- PASS: TestAccAWSKinesisAnalyticsApplication_Multiple_Update (119.11s)
=== CONT  TestAccAWSKinesisAnalyticsApplication_CloudWatchLoggingOptions_Delete
=== CONT  TestAccAWSKinesisAnalyticsApplication_Input_Update
--- PASS: TestAccAWSKinesisAnalyticsApplication_InputProcessingConfiguration_Update (100.11s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_CloudWatchLoggingOptions_Delete (37.27s)
=== CONT  TestAccAWSKinesisAnalyticsApplication_Input_Add
--- PASS: TestAccAWSKinesisAnalyticsApplication_InputProcessingConfiguration_Delete (121.42s)
=== CONT  TestAccAWSKinesisAnalyticsApplication_CloudWatchLoggingOptions_Update
--- PASS: TestAccAWSKinesisAnalyticsApplication_Input_Update (103.37s)
=== CONT  TestAccAWSKinesisAnalyticsApplication_Code_Update
=== CONT  TestAccAWSKinesisAnalyticsApplication_CloudWatchLoggingOptions_Add
--- PASS: TestAccAWSKinesisAnalyticsApplication_CloudWatchLoggingOptions_Update (40.41s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_Code_Update (25.41s)
=== CONT  TestAccAWSKinesisAnalyticsApplication_Tags
=== CONT  TestAccAWSKinesisAnalyticsApplication_disappears
--- PASS: TestAccAWSKinesisAnalyticsApplication_Input_Add (114.63s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_disappears (17.98s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_CloudWatchLoggingOptions_Add (46.64s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_Tags (34.88s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	383.470s
…cation.

Acceptance test output:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSKinesisAnalyticsApplication_' ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 3 -run=TestAccAWSKinesisAnalyticsApplication_ -timeout 120m
=== RUN   TestAccAWSKinesisAnalyticsApplication_basic
=== PAUSE TestAccAWSKinesisAnalyticsApplication_basic
=== RUN   TestAccAWSKinesisAnalyticsApplication_disappears
=== PAUSE TestAccAWSKinesisAnalyticsApplication_disappears
=== RUN   TestAccAWSKinesisAnalyticsApplication_Tags
=== PAUSE TestAccAWSKinesisAnalyticsApplication_Tags
=== RUN   TestAccAWSKinesisAnalyticsApplication_Code_Update
=== PAUSE TestAccAWSKinesisAnalyticsApplication_Code_Update
=== RUN   TestAccAWSKinesisAnalyticsApplication_CloudWatchLoggingOptions_Add
=== PAUSE TestAccAWSKinesisAnalyticsApplication_CloudWatchLoggingOptions_Add
=== RUN   TestAccAWSKinesisAnalyticsApplication_CloudWatchLoggingOptions_Delete
=== PAUSE TestAccAWSKinesisAnalyticsApplication_CloudWatchLoggingOptions_Delete
=== RUN   TestAccAWSKinesisAnalyticsApplication_CloudWatchLoggingOptions_Update
=== PAUSE TestAccAWSKinesisAnalyticsApplication_CloudWatchLoggingOptions_Update
=== RUN   TestAccAWSKinesisAnalyticsApplication_Input_Add
=== PAUSE TestAccAWSKinesisAnalyticsApplication_Input_Add
=== RUN   TestAccAWSKinesisAnalyticsApplication_Input_Update
=== PAUSE TestAccAWSKinesisAnalyticsApplication_Input_Update
=== RUN   TestAccAWSKinesisAnalyticsApplication_InputProcessingConfiguration_Add
=== PAUSE TestAccAWSKinesisAnalyticsApplication_InputProcessingConfiguration_Add
=== RUN   TestAccAWSKinesisAnalyticsApplication_InputProcessingConfiguration_Delete
=== PAUSE TestAccAWSKinesisAnalyticsApplication_InputProcessingConfiguration_Delete
=== RUN   TestAccAWSKinesisAnalyticsApplication_InputProcessingConfiguration_Update
=== PAUSE TestAccAWSKinesisAnalyticsApplication_InputProcessingConfiguration_Update
=== RUN   TestAccAWSKinesisAnalyticsApplication_Multiple_Update
=== PAUSE TestAccAWSKinesisAnalyticsApplication_Multiple_Update
=== RUN   TestAccAWSKinesisAnalyticsApplication_Output_Update
=== PAUSE TestAccAWSKinesisAnalyticsApplication_Output_Update
=== RUN   TestAccAWSKinesisAnalyticsApplication_ReferenceDataSource_Add
=== PAUSE TestAccAWSKinesisAnalyticsApplication_ReferenceDataSource_Add
=== RUN   TestAccAWSKinesisAnalyticsApplication_ReferenceDataSource_Delete
=== PAUSE TestAccAWSKinesisAnalyticsApplication_ReferenceDataSource_Delete
=== RUN   TestAccAWSKinesisAnalyticsApplication_ReferenceDataSource_Update
=== PAUSE TestAccAWSKinesisAnalyticsApplication_ReferenceDataSource_Update
=== RUN   TestAccAWSKinesisAnalyticsApplication_StartApplication_OnCreate
=== PAUSE TestAccAWSKinesisAnalyticsApplication_StartApplication_OnCreate
=== CONT  TestAccAWSKinesisAnalyticsApplication_basic
=== CONT  TestAccAWSKinesisAnalyticsApplication_InputProcessingConfiguration_Delete
=== CONT  TestAccAWSKinesisAnalyticsApplication_StartApplication_OnCreate
--- PASS: TestAccAWSKinesisAnalyticsApplication_basic (16.60s)
=== CONT  TestAccAWSKinesisAnalyticsApplication_ReferenceDataSource_Update
--- PASS: TestAccAWSKinesisAnalyticsApplication_ReferenceDataSource_Update (49.46s)
=== CONT  TestAccAWSKinesisAnalyticsApplication_ReferenceDataSource_Delete
--- PASS: TestAccAWSKinesisAnalyticsApplication_InputProcessingConfiguration_Delete (103.73s)
=== CONT  TestAccAWSKinesisAnalyticsApplication_ReferenceDataSource_Add
--- PASS: TestAccAWSKinesisAnalyticsApplication_ReferenceDataSource_Delete (42.86s)
=== CONT  TestAccAWSKinesisAnalyticsApplication_Output_Update
--- PASS: TestAccAWSKinesisAnalyticsApplication_StartApplication_OnCreate (127.20s)
=== CONT  TestAccAWSKinesisAnalyticsApplication_Multiple_Update
--- PASS: TestAccAWSKinesisAnalyticsApplication_ReferenceDataSource_Add (36.41s)
=== CONT  TestAccAWSKinesisAnalyticsApplication_InputProcessingConfiguration_Update
--- PASS: TestAccAWSKinesisAnalyticsApplication_Output_Update (132.44s)
=== CONT  TestAccAWSKinesisAnalyticsApplication_CloudWatchLoggingOptions_Delete
--- PASS: TestAccAWSKinesisAnalyticsApplication_Multiple_Update (122.52s)
=== CONT  TestAccAWSKinesisAnalyticsApplication_InputProcessingConfiguration_Add
--- PASS: TestAccAWSKinesisAnalyticsApplication_InputProcessingConfiguration_Update (119.23s)
=== CONT  TestAccAWSKinesisAnalyticsApplication_Input_Update
--- PASS: TestAccAWSKinesisAnalyticsApplication_CloudWatchLoggingOptions_Delete (37.78s)
=== CONT  TestAccAWSKinesisAnalyticsApplication_Input_Add
--- PASS: TestAccAWSKinesisAnalyticsApplication_Input_Update (97.45s)
=== CONT  TestAccAWSKinesisAnalyticsApplication_CloudWatchLoggingOptions_Update
--- PASS: TestAccAWSKinesisAnalyticsApplication_InputProcessingConfiguration_Add (108.60s)
=== CONT  TestAccAWSKinesisAnalyticsApplication_Code_Update
--- PASS: TestAccAWSKinesisAnalyticsApplication_Input_Add (93.69s)
=== CONT  TestAccAWSKinesisAnalyticsApplication_CloudWatchLoggingOptions_Add
--- PASS: TestAccAWSKinesisAnalyticsApplication_Code_Update (26.72s)
=== CONT  TestAccAWSKinesisAnalyticsApplication_Tags
--- PASS: TestAccAWSKinesisAnalyticsApplication_CloudWatchLoggingOptions_Update (43.06s)
=== CONT  TestAccAWSKinesisAnalyticsApplication_disappears
--- PASS: TestAccAWSKinesisAnalyticsApplication_CloudWatchLoggingOptions_Add (40.93s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_disappears (18.27s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_Tags (36.27s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	421.418s
@ewbankkit ewbankkit requested a review from a team as a code owner February 23, 2021 23:08
@ghost ghost added size/XL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/kinesisanalytics Issues and PRs that pertain to the kinesisanalytics service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Feb 23, 2021
…pplication_StartApplication_OnUpdate'.

Acceptance test output:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSKinesisAnalyticsApplication_StartApplication_OnUpdate'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSKinesisAnalyticsApplication_StartApplication_OnUpdate -timeout 120m
=== RUN   TestAccAWSKinesisAnalyticsApplication_StartApplication_OnUpdate
=== PAUSE TestAccAWSKinesisAnalyticsApplication_StartApplication_OnUpdate
=== CONT  TestAccAWSKinesisAnalyticsApplication_StartApplication_OnUpdate
--- PASS: TestAccAWSKinesisAnalyticsApplication_StartApplication_OnUpdate (165.79s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	165.886s
@ewbankkit ewbankkit changed the title [WIP] r/aws_kinesis_analytics_application: Add 'start_application' attribute r/aws_kinesis_analytics_application: Add 'start_application' attribute Mar 2, 2021
…ating running application.

Acceptance test output:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSKinesisAnalyticsApplication_StartApplication_Update'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSKinesisAnalyticsApplication_StartApplication_Update -timeout 120m
=== RUN   TestAccAWSKinesisAnalyticsApplication_StartApplication_Update
=== PAUSE TestAccAWSKinesisAnalyticsApplication_StartApplication_Update
=== CONT  TestAccAWSKinesisAnalyticsApplication_StartApplication_Update
--- PASS: TestAccAWSKinesisAnalyticsApplication_StartApplication_Update (701.79s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	701.898s
@ewbankkit ewbankkit force-pushed the f-aws_kinesis_analytics_application-start/stop branch from a90e37b to f4c556c Compare March 4, 2021 00:30
Copy link
Collaborator

@DrFaust92 DrFaust92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

--- PASS: TestAccAWSKinesisAnalyticsApplication_basic (38.76s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_CloudWatchLoggingOptions_Update (89.89s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_InputProcessingConfiguration_Update (179.84s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_InputProcessingConfiguration_Add (193.33s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_InputProcessingConfiguration_Delete (191.56s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_ReferenceDataSource_Update (126.82s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_StartApplication_OnCreate (203.46s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_ReferenceDataSource_Delete (111.42s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_StartApplication_OnUpdate (386.28s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_StartApplication_Update (437.57s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_Tags (87.36s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_ReferenceDataSource_Add (99.87s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_Code_Update (69.73s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_CloudWatchLoggingOptions_Delete (80.50s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_Output_Update (246.01s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_CloudWatchLoggingOptions_Add (76.55s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_Input_Update (182.04s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_disappears (25.20s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_Input_Add (158.78s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_Multiple_Update (216.20s)

.changelog/17784.txt Show resolved Hide resolved
@DrFaust92 DrFaust92 removed their assignment Mar 7, 2021
@DrFaust92 DrFaust92 added the enhancement Requests to existing resources that expand the functionality or scope. label Mar 7, 2021
@breathingdust
Copy link
Member

LGTM 🚀 Thanks @ewbankkit

Verified Acceptance Tests in Commercial (us-west-2)

make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSKinesisAnalyticsApplication_' ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 3 -run=TestAccAWSKinesisAnalyticsApplication_ -timeout 120m
=== RUN   TestAccAWSKinesisAnalyticsApplication_basic
=== PAUSE TestAccAWSKinesisAnalyticsApplication_basic
=== RUN   TestAccAWSKinesisAnalyticsApplication_disappears
=== PAUSE TestAccAWSKinesisAnalyticsApplication_disappears
=== RUN   TestAccAWSKinesisAnalyticsApplication_Tags
=== PAUSE TestAccAWSKinesisAnalyticsApplication_Tags
=== RUN   TestAccAWSKinesisAnalyticsApplication_Code_Update
=== PAUSE TestAccAWSKinesisAnalyticsApplication_Code_Update
=== RUN   TestAccAWSKinesisAnalyticsApplication_CloudWatchLoggingOptions_Add
=== PAUSE TestAccAWSKinesisAnalyticsApplication_CloudWatchLoggingOptions_Add
=== RUN   TestAccAWSKinesisAnalyticsApplication_CloudWatchLoggingOptions_Delete
=== PAUSE TestAccAWSKinesisAnalyticsApplication_CloudWatchLoggingOptions_Delete
=== RUN   TestAccAWSKinesisAnalyticsApplication_CloudWatchLoggingOptions_Update
=== PAUSE TestAccAWSKinesisAnalyticsApplication_CloudWatchLoggingOptions_Update
=== RUN   TestAccAWSKinesisAnalyticsApplication_Input_Add
=== PAUSE TestAccAWSKinesisAnalyticsApplication_Input_Add
=== RUN   TestAccAWSKinesisAnalyticsApplication_Input_Update
=== PAUSE TestAccAWSKinesisAnalyticsApplication_Input_Update
=== RUN   TestAccAWSKinesisAnalyticsApplication_InputProcessingConfiguration_Add
=== PAUSE TestAccAWSKinesisAnalyticsApplication_InputProcessingConfiguration_Add
=== RUN   TestAccAWSKinesisAnalyticsApplication_InputProcessingConfiguration_Delete
=== PAUSE TestAccAWSKinesisAnalyticsApplication_InputProcessingConfiguration_Delete
=== RUN   TestAccAWSKinesisAnalyticsApplication_InputProcessingConfiguration_Update
=== PAUSE TestAccAWSKinesisAnalyticsApplication_InputProcessingConfiguration_Update
=== RUN   TestAccAWSKinesisAnalyticsApplication_Multiple_Update
=== PAUSE TestAccAWSKinesisAnalyticsApplication_Multiple_Update
=== RUN   TestAccAWSKinesisAnalyticsApplication_Output_Update
=== PAUSE TestAccAWSKinesisAnalyticsApplication_Output_Update
=== RUN   TestAccAWSKinesisAnalyticsApplication_ReferenceDataSource_Add
=== PAUSE TestAccAWSKinesisAnalyticsApplication_ReferenceDataSource_Add
=== RUN   TestAccAWSKinesisAnalyticsApplication_ReferenceDataSource_Delete
=== PAUSE TestAccAWSKinesisAnalyticsApplication_ReferenceDataSource_Delete
=== RUN   TestAccAWSKinesisAnalyticsApplication_ReferenceDataSource_Update
=== PAUSE TestAccAWSKinesisAnalyticsApplication_ReferenceDataSource_Update
=== RUN   TestAccAWSKinesisAnalyticsApplication_StartApplication_OnCreate
=== PAUSE TestAccAWSKinesisAnalyticsApplication_StartApplication_OnCreate
=== RUN   TestAccAWSKinesisAnalyticsApplication_StartApplication_OnUpdate
=== PAUSE TestAccAWSKinesisAnalyticsApplication_StartApplication_OnUpdate
=== RUN   TestAccAWSKinesisAnalyticsApplication_StartApplication_Update
=== PAUSE TestAccAWSKinesisAnalyticsApplication_StartApplication_Update
=== CONT  TestAccAWSKinesisAnalyticsApplication_basic
=== CONT  TestAccAWSKinesisAnalyticsApplication_StartApplication_Update
=== CONT  TestAccAWSKinesisAnalyticsApplication_StartApplication_OnUpdate
--- PASS: TestAccAWSKinesisAnalyticsApplication_basic (17.47s)
=== CONT  TestAccAWSKinesisAnalyticsApplication_InputProcessingConfiguration_Add
--- PASS: TestAccAWSKinesisAnalyticsApplication_InputProcessingConfiguration_Add (97.75s)
=== CONT  TestAccAWSKinesisAnalyticsApplication_StartApplication_OnCreate
--- PASS: TestAccAWSKinesisAnalyticsApplication_StartApplication_OnUpdate (171.16s)
=== CONT  TestAccAWSKinesisAnalyticsApplication_ReferenceDataSource_Update
--- PASS: TestAccAWSKinesisAnalyticsApplication_ReferenceDataSource_Update (33.90s)
=== CONT  TestAccAWSKinesisAnalyticsApplication_ReferenceDataSource_Delete
--- PASS: TestAccAWSKinesisAnalyticsApplication_StartApplication_OnCreate (121.92s)
=== CONT  TestAccAWSKinesisAnalyticsApplication_ReferenceDataSource_Add
--- PASS: TestAccAWSKinesisAnalyticsApplication_ReferenceDataSource_Delete (32.50s)
=== CONT  TestAccAWSKinesisAnalyticsApplication_Output_Update
--- PASS: TestAccAWSKinesisAnalyticsApplication_ReferenceDataSource_Add (30.17s)
=== CONT  TestAccAWSKinesisAnalyticsApplication_Multiple_Update
--- PASS: TestAccAWSKinesisAnalyticsApplication_StartApplication_Update (306.32s)
=== CONT  TestAccAWSKinesisAnalyticsApplication_InputProcessingConfiguration_Update
--- PASS: TestAccAWSKinesisAnalyticsApplication_Output_Update (102.80s)
=== CONT  TestAccAWSKinesisAnalyticsApplication_InputProcessingConfiguration_Delete
--- PASS: TestAccAWSKinesisAnalyticsApplication_Multiple_Update (107.68s)
=== CONT  TestAccAWSKinesisAnalyticsApplication_CloudWatchLoggingOptions_Delete
--- PASS: TestAccAWSKinesisAnalyticsApplication_InputProcessingConfiguration_Update (106.71s)
=== CONT  TestAccAWSKinesisAnalyticsApplication_Input_Update
--- PASS: TestAccAWSKinesisAnalyticsApplication_CloudWatchLoggingOptions_Delete (47.86s)
=== CONT  TestAccAWSKinesisAnalyticsApplication_Input_Add
--- PASS: TestAccAWSKinesisAnalyticsApplication_InputProcessingConfiguration_Delete (101.57s)
=== CONT  TestAccAWSKinesisAnalyticsApplication_CloudWatchLoggingOptions_Update
--- PASS: TestAccAWSKinesisAnalyticsApplication_CloudWatchLoggingOptions_Update (41.35s)
=== CONT  TestAccAWSKinesisAnalyticsApplication_Code_Update
--- PASS: TestAccAWSKinesisAnalyticsApplication_Input_Update (84.72s)
=== CONT  TestAccAWSKinesisAnalyticsApplication_CloudWatchLoggingOptions_Add
--- PASS: TestAccAWSKinesisAnalyticsApplication_Input_Add (83.78s)
=== CONT  TestAccAWSKinesisAnalyticsApplication_Tags
--- PASS: TestAccAWSKinesisAnalyticsApplication_Code_Update (24.94s)
=== CONT  TestAccAWSKinesisAnalyticsApplication_disappears
--- PASS: TestAccAWSKinesisAnalyticsApplication_disappears (16.46s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_CloudWatchLoggingOptions_Add (36.22s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_Tags (34.10s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	544.190s

Verified Acceptance Tests in GovCloud (us-gov-west-1)

make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSKinesisAnalyticsApplication_' ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 3 -run=TestAccAWSKinesisAnalyticsApplication_ -timeout 120m
=== RUN   TestAccAWSKinesisAnalyticsApplication_basic
=== PAUSE TestAccAWSKinesisAnalyticsApplication_basic
=== RUN   TestAccAWSKinesisAnalyticsApplication_disappears
=== PAUSE TestAccAWSKinesisAnalyticsApplication_disappears
=== RUN   TestAccAWSKinesisAnalyticsApplication_Tags
=== PAUSE TestAccAWSKinesisAnalyticsApplication_Tags
=== RUN   TestAccAWSKinesisAnalyticsApplication_Code_Update
=== PAUSE TestAccAWSKinesisAnalyticsApplication_Code_Update
=== RUN   TestAccAWSKinesisAnalyticsApplication_CloudWatchLoggingOptions_Add
=== PAUSE TestAccAWSKinesisAnalyticsApplication_CloudWatchLoggingOptions_Add
=== RUN   TestAccAWSKinesisAnalyticsApplication_CloudWatchLoggingOptions_Delete
=== PAUSE TestAccAWSKinesisAnalyticsApplication_CloudWatchLoggingOptions_Delete
=== RUN   TestAccAWSKinesisAnalyticsApplication_CloudWatchLoggingOptions_Update
=== PAUSE TestAccAWSKinesisAnalyticsApplication_CloudWatchLoggingOptions_Update
=== RUN   TestAccAWSKinesisAnalyticsApplication_Input_Add
=== PAUSE TestAccAWSKinesisAnalyticsApplication_Input_Add
=== RUN   TestAccAWSKinesisAnalyticsApplication_Input_Update
=== PAUSE TestAccAWSKinesisAnalyticsApplication_Input_Update
=== RUN   TestAccAWSKinesisAnalyticsApplication_InputProcessingConfiguration_Add
=== PAUSE TestAccAWSKinesisAnalyticsApplication_InputProcessingConfiguration_Add
=== RUN   TestAccAWSKinesisAnalyticsApplication_InputProcessingConfiguration_Delete
=== PAUSE TestAccAWSKinesisAnalyticsApplication_InputProcessingConfiguration_Delete
=== RUN   TestAccAWSKinesisAnalyticsApplication_InputProcessingConfiguration_Update
=== PAUSE TestAccAWSKinesisAnalyticsApplication_InputProcessingConfiguration_Update
=== RUN   TestAccAWSKinesisAnalyticsApplication_Multiple_Update
=== PAUSE TestAccAWSKinesisAnalyticsApplication_Multiple_Update
=== RUN   TestAccAWSKinesisAnalyticsApplication_Output_Update
=== PAUSE TestAccAWSKinesisAnalyticsApplication_Output_Update
=== RUN   TestAccAWSKinesisAnalyticsApplication_ReferenceDataSource_Add
=== PAUSE TestAccAWSKinesisAnalyticsApplication_ReferenceDataSource_Add
=== RUN   TestAccAWSKinesisAnalyticsApplication_ReferenceDataSource_Delete
=== PAUSE TestAccAWSKinesisAnalyticsApplication_ReferenceDataSource_Delete
=== RUN   TestAccAWSKinesisAnalyticsApplication_ReferenceDataSource_Update
=== PAUSE TestAccAWSKinesisAnalyticsApplication_ReferenceDataSource_Update
=== RUN   TestAccAWSKinesisAnalyticsApplication_StartApplication_OnCreate
=== PAUSE TestAccAWSKinesisAnalyticsApplication_StartApplication_OnCreate
=== RUN   TestAccAWSKinesisAnalyticsApplication_StartApplication_OnUpdate
=== PAUSE TestAccAWSKinesisAnalyticsApplication_StartApplication_OnUpdate
=== RUN   TestAccAWSKinesisAnalyticsApplication_StartApplication_Update
=== PAUSE TestAccAWSKinesisAnalyticsApplication_StartApplication_Update
=== CONT  TestAccAWSKinesisAnalyticsApplication_basic
=== CONT  TestAccAWSKinesisAnalyticsApplication_InputProcessingConfiguration_Update
=== CONT  TestAccAWSKinesisAnalyticsApplication_CloudWatchLoggingOptions_Update
--- PASS: TestAccAWSKinesisAnalyticsApplication_basic (24.02s)
=== CONT  TestAccAWSKinesisAnalyticsApplication_InputProcessingConfiguration_Delete
--- PASS: TestAccAWSKinesisAnalyticsApplication_CloudWatchLoggingOptions_Update (29.96s)
=== CONT  TestAccAWSKinesisAnalyticsApplication_InputProcessingConfiguration_Add
--- PASS: TestAccAWSKinesisAnalyticsApplication_InputProcessingConfiguration_Update (67.19s)
=== CONT  TestAccAWSKinesisAnalyticsApplication_Input_Update
--- PASS: TestAccAWSKinesisAnalyticsApplication_InputProcessingConfiguration_Delete (66.88s)
=== CONT  TestAccAWSKinesisAnalyticsApplication_Input_Add
--- PASS: TestAccAWSKinesisAnalyticsApplication_InputProcessingConfiguration_Add (72.57s)
=== CONT  TestAccAWSKinesisAnalyticsApplication_ReferenceDataSource_Update
--- PASS: TestAccAWSKinesisAnalyticsApplication_ReferenceDataSource_Update (26.20s)
=== CONT  TestAccAWSKinesisAnalyticsApplication_StartApplication_Update
--- PASS: TestAccAWSKinesisAnalyticsApplication_Input_Update (84.85s)
=== CONT  TestAccAWSKinesisAnalyticsApplication_StartApplication_OnUpdate
--- PASS: TestAccAWSKinesisAnalyticsApplication_Input_Add (77.84s)
=== CONT  TestAccAWSKinesisAnalyticsApplication_StartApplication_OnCreate
--- PASS: TestAccAWSKinesisAnalyticsApplication_StartApplication_OnCreate (119.92s)
=== CONT  TestAccAWSKinesisAnalyticsApplication_ReferenceDataSource_Add
--- PASS: TestAccAWSKinesisAnalyticsApplication_StartApplication_OnUpdate (136.82s)
=== CONT  TestAccAWSKinesisAnalyticsApplication_Code_Update
--- PASS: TestAccAWSKinesisAnalyticsApplication_Code_Update (17.95s)
=== CONT  TestAccAWSKinesisAnalyticsApplication_CloudWatchLoggingOptions_Delete
--- PASS: TestAccAWSKinesisAnalyticsApplication_ReferenceDataSource_Add (23.50s)
=== CONT  TestAccAWSKinesisAnalyticsApplication_CloudWatchLoggingOptions_Add
--- PASS: TestAccAWSKinesisAnalyticsApplication_CloudWatchLoggingOptions_Delete (31.32s)
=== CONT  TestAccAWSKinesisAnalyticsApplication_Output_Update
--- PASS: TestAccAWSKinesisAnalyticsApplication_CloudWatchLoggingOptions_Add (30.07s)
=== CONT  TestAccAWSKinesisAnalyticsApplication_Multiple_Update
--- PASS: TestAccAWSKinesisAnalyticsApplication_Multiple_Update (72.17s)
=== CONT  TestAccAWSKinesisAnalyticsApplication_Tags
--- PASS: TestAccAWSKinesisAnalyticsApplication_Output_Update (94.33s)
=== CONT  TestAccAWSKinesisAnalyticsApplication_disappears
--- PASS: TestAccAWSKinesisAnalyticsApplication_Tags (24.53s)
=== CONT  TestAccAWSKinesisAnalyticsApplication_ReferenceDataSource_Delete
--- PASS: TestAccAWSKinesisAnalyticsApplication_StartApplication_Update (318.88s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_disappears (20.96s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_ReferenceDataSource_Delete (25.86s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	467.936s

@breathingdust breathingdust merged commit 825fbe1 into hashicorp:main Mar 11, 2021
@github-actions github-actions bot added this to the v3.32.0 milestone Mar 11, 2021
@ghost
Copy link

ghost commented Mar 12, 2021

This has been released in version 3.32.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ewbankkit ewbankkit deleted the f-aws_kinesis_analytics_application-start/stop branch March 12, 2021 13:04
@ghost
Copy link

ghost commented Apr 11, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Apr 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/kinesisanalytics Issues and PRs that pertain to the kinesisanalytics service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: Kinesis Data Analytics StartApplication
3 participants