Support network-interface in launch template tag_specifications

[xabinapal]

Community Note

• Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
• If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

In #17253 and #17467 it was suggested that launch template resources should support more tag_specification resource types. They were rejected due to AWS console only supporting instances, volumes, elastic graphics and spot instance requests. But now (don't know when this changed), it also supports network interfaces, so I think this should be reconsidered:

New or Affected Resource(s)

• aws_launch_template

Potential Terraform Configuration

tag_specifications {
  resource_type = "network-interface"
  tags          = var.tags
}

References

• Support other launch template tag_specifications #17253
• aws_launch_template don't support tags for "spot-instances-request" and "elastic-gpu" #14558
• aws_launch_template tag_specifications missing network-interface resource_type #17467

[xabinapal]

Just tested it and it works, so official AWS documentation is indeed obsolete 😕. I have already submitted a PR.

[gordonbondon]

This should be fixed by #20409

[github-actions]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.