support filters on aws_efs_file_system data source

[earchibald-lv]

Community Note

• Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
• If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

Per #2563 the AWS API at the time did not provide Tags in its response, so applying a client-side filter to the provider was infeasible.

We can potentially do client-side filtering of the DescribeFileSystems result to achieve more advanced filters than the server supports, but the tag information is not included in this response so it is unfortunately impossible to implement filtering by tag in a reasonable way (we'd need to do serial calls to DescribeTags for all filesystems in your account).

Since then, the API has been updated and Tags are now included in the response to EFS.DescribeFileSystems.

Can this be re-assessed for feature inclusion?

New or Affected Resource(s)

• data aws_efs_file_system (or potentially new data aws_efs_file_systems.)

Potential Terraform Configuration

data "aws_efs_file_systems" "proddata" {
  instance_tags = {
    State = "prod"
    Type = "data"
  }
}

References

• support filters on aws_efs_file_system data source #2563

[ghost]

I would personally prefer both aws_efs_file_system be updated and a new aws_efs_file_systems data source. Similar to aws_instance and aws_instances (and many other resource types)

[jakauppila]

If one were to work on this issue, what would be desired from the maintainers perspective?

This one is clear:

• Add additional tag filters to aws_efs_file_system

Would you also accept:

• Add an additional aws_efs_file_systems that allows tag filtering and can return multiple file systems

[github-actions]

This functionality has been released in v3.56.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.