-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding support for app cookie stickiness #18102
adding support for app cookie stickiness #18102
Conversation
d90d341
to
e873f35
Compare
9f94247
to
ac7cdab
Compare
ac7cdab
to
ca1d2fa
Compare
ca1d2fa
to
41f781b
Compare
Hi, Need help from maintainer on why the below check is failing.
Br, |
@sunilkumarmohanty could you resolve the conflicts? That may speed up the process :) |
96f2645
to
8fafcf6
Compare
86686f3
to
1b183c3
Compare
1b183c3
to
ee96787
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSLBTargetGroup_ -timeout 180m
=== RUN TestAccAWSLBTargetGroup_basic
=== PAUSE TestAccAWSLBTargetGroup_basic
=== RUN TestAccAWSLBTargetGroup_basicUdp
=== PAUSE TestAccAWSLBTargetGroup_basicUdp
=== RUN TestAccAWSLBTargetGroup_ProtocolVersion
=== PAUSE TestAccAWSLBTargetGroup_ProtocolVersion
=== RUN TestAccAWSLBTargetGroup_withoutHealthcheck
=== PAUSE TestAccAWSLBTargetGroup_withoutHealthcheck
=== RUN TestAccAWSLBTargetGroup_networkLB_TargetGroup
=== PAUSE TestAccAWSLBTargetGroup_networkLB_TargetGroup
=== RUN TestAccAWSLBTargetGroup_Protocol_Geneve
=== PAUSE TestAccAWSLBTargetGroup_Protocol_Geneve
=== RUN TestAccAWSLBTargetGroup_Protocol_Tcp_HealthCheck_Protocol
=== PAUSE TestAccAWSLBTargetGroup_Protocol_Tcp_HealthCheck_Protocol
=== RUN TestAccAWSLBTargetGroup_Protocol_Tls
=== PAUSE TestAccAWSLBTargetGroup_Protocol_Tls
=== RUN TestAccAWSLBTargetGroup_ProtocolVersion_GRPC_HealthCheck
=== PAUSE TestAccAWSLBTargetGroup_ProtocolVersion_GRPC_HealthCheck
=== RUN TestAccAWSLBTargetGroup_ProtocolVersion_HTTP_GRPC_Update
=== PAUSE TestAccAWSLBTargetGroup_ProtocolVersion_HTTP_GRPC_Update
=== RUN TestAccAWSLBTargetGroup_networkLB_TargetGroupWithProxy
=== PAUSE TestAccAWSLBTargetGroup_networkLB_TargetGroupWithProxy
=== RUN TestAccAWSLBTargetGroup_TCP_HTTPHealthCheck
=== PAUSE TestAccAWSLBTargetGroup_TCP_HTTPHealthCheck
=== RUN TestAccAWSLBTargetGroup_BackwardsCompatibility
=== PAUSE TestAccAWSLBTargetGroup_BackwardsCompatibility
=== RUN TestAccAWSLBTargetGroup_namePrefix
=== PAUSE TestAccAWSLBTargetGroup_namePrefix
=== RUN TestAccAWSLBTargetGroup_generatedName
=== PAUSE TestAccAWSLBTargetGroup_generatedName
=== RUN TestAccAWSLBTargetGroup_changeNameForceNew
=== PAUSE TestAccAWSLBTargetGroup_changeNameForceNew
=== RUN TestAccAWSLBTargetGroup_changeProtocolForceNew
=== PAUSE TestAccAWSLBTargetGroup_changeProtocolForceNew
=== RUN TestAccAWSLBTargetGroup_changePortForceNew
=== PAUSE TestAccAWSLBTargetGroup_changePortForceNew
=== RUN TestAccAWSLBTargetGroup_changeVpcForceNew
=== PAUSE TestAccAWSLBTargetGroup_changeVpcForceNew
=== RUN TestAccAWSLBTargetGroup_tags
=== PAUSE TestAccAWSLBTargetGroup_tags
=== RUN TestAccAWSLBTargetGroup_enableHealthCheck
=== PAUSE TestAccAWSLBTargetGroup_enableHealthCheck
=== RUN TestAccAWSLBTargetGroup_updateHealthCheck
=== PAUSE TestAccAWSLBTargetGroup_updateHealthCheck
=== RUN TestAccAWSLBTargetGroup_updateSticknessEnabled
=== PAUSE TestAccAWSLBTargetGroup_updateSticknessEnabled
=== RUN TestAccAWSLBTargetGroup_updateAppSticknessEnabled
=== PAUSE TestAccAWSLBTargetGroup_updateAppSticknessEnabled
=== RUN TestAccAWSLBTargetGroup_defaults_application
=== PAUSE TestAccAWSLBTargetGroup_defaults_application
=== RUN TestAccAWSLBTargetGroup_defaults_network
=== PAUSE TestAccAWSLBTargetGroup_defaults_network
=== RUN TestAccAWSLBTargetGroup_stickinessDefaultNLB
=== PAUSE TestAccAWSLBTargetGroup_stickinessDefaultNLB
=== RUN TestAccAWSLBTargetGroup_stickinessDefaultALB
=== PAUSE TestAccAWSLBTargetGroup_stickinessDefaultALB
=== RUN TestAccAWSLBTargetGroup_stickinessValidNLB
=== PAUSE TestAccAWSLBTargetGroup_stickinessValidNLB
=== RUN TestAccAWSLBTargetGroup_stickinessValidALB
=== PAUSE TestAccAWSLBTargetGroup_stickinessValidALB
=== RUN TestAccAWSLBTargetGroup_stickinessInvalidNLB
=== PAUSE TestAccAWSLBTargetGroup_stickinessInvalidNLB
=== RUN TestAccAWSLBTargetGroup_stickinessInvalidALB
=== PAUSE TestAccAWSLBTargetGroup_stickinessInvalidALB
=== RUN TestAccAWSLBTargetGroup_preserveClientIPValid
=== PAUSE TestAccAWSLBTargetGroup_preserveClientIPValid
=== CONT TestAccAWSLBTargetGroup_basic
=== CONT TestAccAWSLBTargetGroup_defaults_network
=== CONT TestAccAWSLBTargetGroup_changeVpcForceNew
=== CONT TestAccAWSLBTargetGroup_changeNameForceNew
=== CONT TestAccAWSLBTargetGroup_changePortForceNew
=== CONT TestAccAWSLBTargetGroup_defaults_application
=== CONT TestAccAWSLBTargetGroup_updateAppSticknessEnabled
=== CONT TestAccAWSLBTargetGroup_updateSticknessEnabled
=== CONT TestAccAWSLBTargetGroup_updateHealthCheck
=== CONT TestAccAWSLBTargetGroup_enableHealthCheck
=== CONT TestAccAWSLBTargetGroup_tags
=== CONT TestAccAWSLBTargetGroup_ProtocolVersion_HTTP_GRPC_Update
=== CONT TestAccAWSLBTargetGroup_BackwardsCompatibility
=== CONT TestAccAWSLBTargetGroup_TCP_HTTPHealthCheck
=== CONT TestAccAWSLBTargetGroup_networkLB_TargetGroupWithProxy
=== CONT TestAccAWSLBTargetGroup_generatedName
=== CONT TestAccAWSLBTargetGroup_Protocol_Geneve
=== CONT TestAccAWSLBTargetGroup_ProtocolVersion_GRPC_HealthCheck
=== CONT TestAccAWSLBTargetGroup_Protocol_Tls
=== CONT TestAccAWSLBTargetGroup_namePrefix
--- PASS: TestAccAWSLBTargetGroup_generatedName (32.99s)
=== CONT TestAccAWSLBTargetGroup_preserveClientIPValid
--- PASS: TestAccAWSLBTargetGroup_namePrefix (36.74s)
=== CONT TestAccAWSLBTargetGroup_Protocol_Tcp_HealthCheck_Protocol
--- PASS: TestAccAWSLBTargetGroup_Protocol_Tls (40.95s)
=== CONT TestAccAWSLBTargetGroup_withoutHealthcheck
--- PASS: TestAccAWSLBTargetGroup_BackwardsCompatibility (42.97s)
=== CONT TestAccAWSLBTargetGroup_stickinessInvalidALB
--- PASS: TestAccAWSLBTargetGroup_enableHealthCheck (45.41s)
=== CONT TestAccAWSLBTargetGroup_stickinessInvalidNLB
--- PASS: TestAccAWSLBTargetGroup_defaults_network (48.30s)
=== CONT TestAccAWSLBTargetGroup_stickinessValidALB
--- PASS: TestAccAWSLBTargetGroup_basic (49.48s)
=== CONT TestAccAWSLBTargetGroup_stickinessValidNLB
--- PASS: TestAccAWSLBTargetGroup_ProtocolVersion_GRPC_HealthCheck (55.44s)
=== CONT TestAccAWSLBTargetGroup_stickinessDefaultALB
--- PASS: TestAccAWSLBTargetGroup_withoutHealthcheck (27.69s)
=== CONT TestAccAWSLBTargetGroup_stickinessDefaultNLB
--- PASS: TestAccAWSLBTargetGroup_Protocol_Geneve (69.02s)
=== CONT TestAccAWSLBTargetGroup_networkLB_TargetGroup
--- PASS: TestAccAWSLBTargetGroup_updateHealthCheck (74.32s)
=== CONT TestAccAWSLBTargetGroup_ProtocolVersion
--- PASS: TestAccAWSLBTargetGroup_defaults_application (74.50s)
=== CONT TestAccAWSLBTargetGroup_basicUdp
--- PASS: TestAccAWSLBTargetGroup_networkLB_TargetGroupWithProxy (74.92s)
=== CONT TestAccAWSLBTargetGroup_changeProtocolForceNew
--- PASS: TestAccAWSLBTargetGroup_changePortForceNew (88.05s)
--- PASS: TestAccAWSLBTargetGroup_preserveClientIPValid (55.57s)
--- PASS: TestAccAWSLBTargetGroup_updateAppSticknessEnabled (88.90s)
--- PASS: TestAccAWSLBTargetGroup_stickinessInvalidNLB (46.95s)
--- PASS: TestAccAWSLBTargetGroup_changeVpcForceNew (93.89s)
--- PASS: TestAccAWSLBTargetGroup_ProtocolVersion_HTTP_GRPC_Update (95.93s)
--- PASS: TestAccAWSLBTargetGroup_TCP_HTTPHealthCheck (98.51s)
--- PASS: TestAccAWSLBTargetGroup_tags (99.59s)
--- PASS: TestAccAWSLBTargetGroup_stickinessDefaultALB (44.22s)
--- PASS: TestAccAWSLBTargetGroup_changeNameForceNew (101.05s)
--- PASS: TestAccAWSLBTargetGroup_basicUdp (28.08s)
--- PASS: TestAccAWSLBTargetGroup_ProtocolVersion (29.30s)
--- PASS: TestAccAWSLBTargetGroup_stickinessInvalidALB (61.57s)
--- PASS: TestAccAWSLBTargetGroup_updateSticknessEnabled (105.82s)
--- PASS: TestAccAWSLBTargetGroup_stickinessValidALB (58.88s)
--- PASS: TestAccAWSLBTargetGroup_Protocol_Tcp_HealthCheck_Protocol (75.05s)
--- PASS: TestAccAWSLBTargetGroup_changeProtocolForceNew (51.28s)
--- PASS: TestAccAWSLBTargetGroup_networkLB_TargetGroup (68.69s)
--- PASS: TestAccAWSLBTargetGroup_stickinessDefaultNLB (83.62s)
--- PASS: TestAccAWSLBTargetGroup_stickinessValidNLB (113.70s)
PASS
ok github.com/terraform-providers/terraform-provider-aws/aws 163.227s
This functionality has been released in v3.47.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Community Note
Relates OR Closes #17617
Output from acceptance testing: