r/aws apigatewayv2 route: Add request_parameters attribute
#18410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
size/XL
ewbankkit
force-pushed
the
f-r/aws_apigatewayv2_route-add-request_parameters
branch
from
d6c413d to
1a082f7
Compare
Acceptance test output: $ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSAPIGatewayV2Route_' ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSAPIGatewayV2Route_ -timeout 180m === RUN TestAccAWSAPIGatewayV2Route_basic === PAUSE TestAccAWSAPIGatewayV2Route_basic === RUN TestAccAWSAPIGatewayV2Route_disappears === PAUSE TestAccAWSAPIGatewayV2Route_disappears === RUN TestAccAWSAPIGatewayV2Route_Authorizer === PAUSE TestAccAWSAPIGatewayV2Route_Authorizer === RUN TestAccAWSAPIGatewayV2Route_JwtAuthorization === PAUSE TestAccAWSAPIGatewayV2Route_JwtAuthorization === RUN TestAccAWSAPIGatewayV2Route_Model === PAUSE TestAccAWSAPIGatewayV2Route_Model === RUN TestAccAWSAPIGatewayV2Route_SimpleAttributes === PAUSE TestAccAWSAPIGatewayV2Route_SimpleAttributes === RUN TestAccAWSAPIGatewayV2Route_Target === PAUSE TestAccAWSAPIGatewayV2Route_Target === RUN TestAccAWSAPIGatewayV2Route_UpdateRouteKey === PAUSE TestAccAWSAPIGatewayV2Route_UpdateRouteKey === CONT TestAccAWSAPIGatewayV2Route_basic === CONT TestAccAWSAPIGatewayV2Route_SimpleAttributes === CONT TestAccAWSAPIGatewayV2Route_UpdateRouteKey === CONT TestAccAWSAPIGatewayV2Route_Target === CONT TestAccAWSAPIGatewayV2Route_JwtAuthorization === CONT TestAccAWSAPIGatewayV2Route_Model === CONT TestAccAWSAPIGatewayV2Route_Authorizer === CONT TestAccAWSAPIGatewayV2Route_disappears --- PASS: TestAccAWSAPIGatewayV2Route_disappears (26.14s) --- PASS: TestAccAWSAPIGatewayV2Route_basic (29.35s) --- PASS: TestAccAWSAPIGatewayV2Route_Model (31.10s) --- PASS: TestAccAWSAPIGatewayV2Route_Target (31.49s) --- PASS: TestAccAWSAPIGatewayV2Route_UpdateRouteKey (41.19s) --- PASS: TestAccAWSAPIGatewayV2Route_SimpleAttributes (51.22s) --- PASS: TestAccAWSAPIGatewayV2Route_Authorizer (69.92s) --- PASS: TestAccAWSAPIGatewayV2Route_JwtAuthorization (75.50s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 75.587s
Acceptance test output: $ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSAPIGatewayV2Route_' ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSAPIGatewayV2Route_ -timeout 180m === RUN TestAccAWSAPIGatewayV2Route_basic === PAUSE TestAccAWSAPIGatewayV2Route_basic === RUN TestAccAWSAPIGatewayV2Route_disappears === PAUSE TestAccAWSAPIGatewayV2Route_disappears === RUN TestAccAWSAPIGatewayV2Route_Authorizer === PAUSE TestAccAWSAPIGatewayV2Route_Authorizer === RUN TestAccAWSAPIGatewayV2Route_JwtAuthorization === PAUSE TestAccAWSAPIGatewayV2Route_JwtAuthorization === RUN TestAccAWSAPIGatewayV2Route_Model === PAUSE TestAccAWSAPIGatewayV2Route_Model === RUN TestAccAWSAPIGatewayV2Route_RequestParameters === PAUSE TestAccAWSAPIGatewayV2Route_RequestParameters === RUN TestAccAWSAPIGatewayV2Route_SimpleAttributes === PAUSE TestAccAWSAPIGatewayV2Route_SimpleAttributes === RUN TestAccAWSAPIGatewayV2Route_Target === PAUSE TestAccAWSAPIGatewayV2Route_Target === RUN TestAccAWSAPIGatewayV2Route_UpdateRouteKey === PAUSE TestAccAWSAPIGatewayV2Route_UpdateRouteKey === CONT TestAccAWSAPIGatewayV2Route_basic === CONT TestAccAWSAPIGatewayV2Route_RequestParameters === CONT TestAccAWSAPIGatewayV2Route_UpdateRouteKey === CONT TestAccAWSAPIGatewayV2Route_Target === CONT TestAccAWSAPIGatewayV2Route_SimpleAttributes === CONT TestAccAWSAPIGatewayV2Route_JwtAuthorization === CONT TestAccAWSAPIGatewayV2Route_Model === CONT TestAccAWSAPIGatewayV2Route_Authorizer === CONT TestAccAWSAPIGatewayV2Route_disappears --- PASS: TestAccAWSAPIGatewayV2Route_disappears (27.57s) --- PASS: TestAccAWSAPIGatewayV2Route_basic (31.98s) --- PASS: TestAccAWSAPIGatewayV2Route_Model (32.60s) --- PASS: TestAccAWSAPIGatewayV2Route_Target (32.61s) --- PASS: TestAccAWSAPIGatewayV2Route_UpdateRouteKey (41.37s) --- PASS: TestAccAWSAPIGatewayV2Route_RequestParameters (56.66s) --- PASS: TestAccAWSAPIGatewayV2Route_Authorizer (72.94s) --- PASS: TestAccAWSAPIGatewayV2Route_JwtAuthorization (79.44s) --- PASS: TestAccAWSAPIGatewayV2Route_SimpleAttributes (82.78s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 82.905s
ewbankkit
force-pushed
the
f-r/aws_apigatewayv2_route-add-request_parameters
branch
from
1a082f7 to
79598c7
Compare
ewbankkit
changed the title
request_parameters attributerequest_parameters attribute
DrFaust92
added
the
enhancement
DrFaust92
approved these changes
Mar 26, 2021
There was a problem hiding this comment.
LGTM
--- PASS: TestAccAWSAPIGatewayV2Route_disappears (40.55s)
--- PASS: TestAccAWSAPIGatewayV2Route_basic (48.34s)
--- PASS: TestAccAWSAPIGatewayV2Route_Model (53.74s)
--- PASS: TestAccAWSAPIGatewayV2Route_Target (53.98s)
--- PASS: TestAccAWSAPIGatewayV2Route_UpdateRouteKey (76.10s)
--- PASS: TestAccAWSAPIGatewayV2Route_SimpleAttributes (101.49s)
--- PASS: TestAccAWSAPIGatewayV2Route_RequestParameters (104.10s)
--- PASS: TestAccAWSAPIGatewayV2Route_JwtAuthorization (121.86s)
--- PASS: TestAccAWSAPIGatewayV2Route_Authorizer (136.37s)
|
LGTM 🚀 Thanks @ewbankkit! Verified Acceptance Tests in Commercial (us-west-2) make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSAPIGatewayV2Route_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSAPIGatewayV2Route_ -timeout 180m
=== RUN TestAccAWSAPIGatewayV2Route_basic
=== PAUSE TestAccAWSAPIGatewayV2Route_basic
=== RUN TestAccAWSAPIGatewayV2Route_disappears
=== PAUSE TestAccAWSAPIGatewayV2Route_disappears
=== RUN TestAccAWSAPIGatewayV2Route_Authorizer
=== PAUSE TestAccAWSAPIGatewayV2Route_Authorizer
=== RUN TestAccAWSAPIGatewayV2Route_JwtAuthorization
=== PAUSE TestAccAWSAPIGatewayV2Route_JwtAuthorization
=== RUN TestAccAWSAPIGatewayV2Route_Model
=== PAUSE TestAccAWSAPIGatewayV2Route_Model
=== RUN TestAccAWSAPIGatewayV2Route_RequestParameters
=== PAUSE TestAccAWSAPIGatewayV2Route_RequestParameters
=== RUN TestAccAWSAPIGatewayV2Route_SimpleAttributes
=== PAUSE TestAccAWSAPIGatewayV2Route_SimpleAttributes
=== RUN TestAccAWSAPIGatewayV2Route_Target
=== PAUSE TestAccAWSAPIGatewayV2Route_Target
=== RUN TestAccAWSAPIGatewayV2Route_UpdateRouteKey
=== PAUSE TestAccAWSAPIGatewayV2Route_UpdateRouteKey
=== CONT TestAccAWSAPIGatewayV2Route_basic
=== CONT TestAccAWSAPIGatewayV2Route_RequestParameters
=== CONT TestAccAWSAPIGatewayV2Route_JwtAuthorization
=== CONT TestAccAWSAPIGatewayV2Route_Model
=== CONT TestAccAWSAPIGatewayV2Route_UpdateRouteKey
=== CONT TestAccAWSAPIGatewayV2Route_Target
=== CONT TestAccAWSAPIGatewayV2Route_Authorizer
=== CONT TestAccAWSAPIGatewayV2Route_SimpleAttributes
=== CONT TestAccAWSAPIGatewayV2Route_disappears
--- PASS: TestAccAWSAPIGatewayV2Route_disappears (18.14s)
--- PASS: TestAccAWSAPIGatewayV2Route_basic (21.05s)
--- PASS: TestAccAWSAPIGatewayV2Route_Model (21.74s)
--- PASS: TestAccAWSAPIGatewayV2Route_Target (22.63s)
--- PASS: TestAccAWSAPIGatewayV2Route_UpdateRouteKey (32.72s)
--- PASS: TestAccAWSAPIGatewayV2Route_RequestParameters (44.94s)
--- PASS: TestAccAWSAPIGatewayV2Route_SimpleAttributes (45.74s)
--- PASS: TestAccAWSAPIGatewayV2Route_JwtAuthorization (55.81s)
--- PASS: TestAccAWSAPIGatewayV2Route_Authorizer (66.27s)
PASS
ok github.com/terraform-providers/terraform-provider-aws/aws 69.322sVerified Acceptance Tests in GovCloud (us-gov-west-1) make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSAPIGatewayV2Route_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSAPIGatewayV2Route_ -timeout 180m
=== RUN TestAccAWSAPIGatewayV2Route_basic
=== PAUSE TestAccAWSAPIGatewayV2Route_basic
=== RUN TestAccAWSAPIGatewayV2Route_disappears
=== PAUSE TestAccAWSAPIGatewayV2Route_disappears
=== RUN TestAccAWSAPIGatewayV2Route_Authorizer
=== PAUSE TestAccAWSAPIGatewayV2Route_Authorizer
=== RUN TestAccAWSAPIGatewayV2Route_JwtAuthorization
=== PAUSE TestAccAWSAPIGatewayV2Route_JwtAuthorization
=== RUN TestAccAWSAPIGatewayV2Route_Model
=== PAUSE TestAccAWSAPIGatewayV2Route_Model
=== RUN TestAccAWSAPIGatewayV2Route_RequestParameters
=== PAUSE TestAccAWSAPIGatewayV2Route_RequestParameters
=== RUN TestAccAWSAPIGatewayV2Route_SimpleAttributes
=== PAUSE TestAccAWSAPIGatewayV2Route_SimpleAttributes
=== RUN TestAccAWSAPIGatewayV2Route_Target
=== PAUSE TestAccAWSAPIGatewayV2Route_Target
=== RUN TestAccAWSAPIGatewayV2Route_UpdateRouteKey
=== PAUSE TestAccAWSAPIGatewayV2Route_UpdateRouteKey
=== CONT TestAccAWSAPIGatewayV2Route_basic
=== CONT TestAccAWSAPIGatewayV2Route_RequestParameters
=== CONT TestAccAWSAPIGatewayV2Route_UpdateRouteKey
=== CONT TestAccAWSAPIGatewayV2Route_JwtAuthorization
=== CONT TestAccAWSAPIGatewayV2Route_Target
=== CONT TestAccAWSAPIGatewayV2Route_SimpleAttributes
=== CONT TestAccAWSAPIGatewayV2Route_disappears
=== CONT TestAccAWSAPIGatewayV2Route_Model
=== CONT TestAccAWSAPIGatewayV2Route_Authorizer
--- PASS: TestAccAWSAPIGatewayV2Route_Target (17.15s)
--- PASS: TestAccAWSAPIGatewayV2Route_disappears (19.72s)
--- PASS: TestAccAWSAPIGatewayV2Route_UpdateRouteKey (26.05s)
--- PASS: TestAccAWSAPIGatewayV2Route_Model (39.26s)
--- PASS: TestAccAWSAPIGatewayV2Route_RequestParameters (39.27s)
--- PASS: TestAccAWSAPIGatewayV2Route_SimpleAttributes (39.68s)
--- PASS: TestAccAWSAPIGatewayV2Route_basic (46.59s)
--- PASS: TestAccAWSAPIGatewayV2Route_Authorizer (59.05s)
--- PASS: TestAccAWSAPIGatewayV2Route_JwtAuthorization (64.01s)
PASS
ok github.com/terraform-providers/terraform-provider-aws/aws 66.805s |
|
This has been released in version 3.35.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks! |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Community Note
Closes #18387.
Output from acceptance testing: