Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for enabling cluster debugging to EMR #1866

Closed
gudlyf opened this issue Oct 11, 2017 · 5 comments · Fixed by #3673
Closed

Add support for enabling cluster debugging to EMR #1866

gudlyf opened this issue Oct 11, 2017 · 5 comments · Fixed by #3673
Assignees
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/emr Issues and PRs that pertain to the emr service.
Milestone

Comments

@gudlyf
Copy link

gudlyf commented Oct 11, 2017

The option to enable debugging to an EMR cluster is currently not present in the 'aws_emr_cluster' resource. This option cannot be added after the cluster is created and must be done at time of cluster creation.

Reference: https://docs.aws.amazon.com/emr/latest/ManagementGuide/emr-plan-debugging.html
Reference: http://docs.aws.amazon.com/cli/latest/reference/emr/create-cluster.html (NOTE: --enable-debugging flag)

@radeksimko radeksimko added the enhancement Requests to existing resources that expand the functionality or scope. label Oct 15, 2017
@radeksimko radeksimko added the service/emr Issues and PRs that pertain to the emr service. label Jan 28, 2018
@bflad bflad self-assigned this Mar 7, 2018
@bflad bflad added this to the v1.11.0 milestone Mar 7, 2018
@bflad
Copy link
Contributor

bflad commented Mar 7, 2018

The AWS CLI option --enable-debugging is a customization in the CLI that wraps adding a step:

https://github.com/aws/aws-cli/blob/c172027fc12b9709f4082825469adc3a66a73652/awscli/customizations/emr/createcluster.py#L462-L476

Theoretically we should be able to provide the functionality and also enable other use cases by supporting a step list for the aws_emr_cluster resource:

# Not implemented - interface could change
step {
  action = "TERMINATE_CLUSTER"
  name   = "Setup Hadoop Debugging"

  hadoop_jar_step {
    jar  = "command-runner.jar"
    args = ["state-pusher-script"]
  }
}

I'll work on creating a PR for this right now. Related issues: #1593 and #1714

@bflad
Copy link
Contributor

bflad commented Mar 15, 2018

Support for configuring steps during cluster creation has been merged into master via #3673 and will release with v1.12.0 of the AWS provider, likely in about a week.

@bflad
Copy link
Contributor

bflad commented Mar 23, 2018

This has been released in version 1.12.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@dpnova
Copy link

dpnova commented Jun 5, 2019

Anyone actually managed to get this to work. Where do you specify the s3 uri as a destination for the log files?

@ghost
Copy link

ghost commented Mar 29, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/emr Issues and PRs that pertain to the emr service.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants