Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate EKS update waiter function #18805

Closed
gdavison opened this issue Apr 12, 2021 · 2 comments
Closed

Consolidate EKS update waiter function #18805

gdavison opened this issue Apr 12, 2021 · 2 comments
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/eks Issues and PRs that pertain to the eks service. technical-debt Addresses areas of the codebase that need refactoring or redesign.

Comments

@gdavison
Copy link
Contributor

The EKS service has a central function, DescribeUpdate (or DescribeUpdateWithContext) to track updates to clusters, add-ons, and node groups. This can use a centralized waiter function, but is currently implemented separately for each resource.

The PR #16972 adds the waiter function EksAddonUpdateSuccessful. This can be adapted for clusters and node groups.

Affected Resource

  • aws_eks_cluster
  • aws_eks_node_group
@gdavison gdavison added enhancement Requests to existing resources that expand the functionality or scope. technical-debt Addresses areas of the codebase that need refactoring or redesign. labels Apr 12, 2021
@ghost ghost added the service/eks Issues and PRs that pertain to the eks service. label Apr 12, 2021
@ewbankkit
Copy link
Contributor

Because each call to DescribeUpdate is slightly different (NodegroupName must be passed for node group updates, AddonName must be passed for add-on updates, etc.), attempting to centralize the waiter will lead to more complex code.

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/eks Issues and PRs that pertain to the eks service. technical-debt Addresses areas of the codebase that need refactoring or redesign.
Projects
None yet
Development

No branches or pull requests

2 participants