Allow "/" in aws_glue_crawler name

[SeanKilleen]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #19159

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

[SeanKilleen]

I'm brand new to this repo and while I'm pretty confident of this change given the nature of the issue, I'd love some guidance on updating tests or other steps necessary to get this merged. I'll run with any minimal help.

[github-actions]

Welcome @SeanKilleen 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

[DrFaust92]

LGTM

--- PASS: TestAccAWSGlueCrawler_Role_Name_Path (62.24s)
--- PASS: TestAccAWSGlueCrawler_disappears (63.26s)
--- PASS: TestAccAWSGlueCrawler_Role_ARN_NoPath (66.88s)
--- PASS: TestAccAWSGlueCrawler_Role_ARN_Path (67.30s)
--- PASS: TestAccAWSGlueCrawler_SchemaChangePolicy (102.53s)
--- PASS: TestAccAWSGlueCrawler_DynamodbTarget (102.94s)
--- PASS: TestAccAWSGlueCrawler_RemoveTablePrefix (104.40s)
--- PASS: TestAccAWSGlueCrawler_Description (104.94s)
--- PASS: TestAccAWSGlueCrawler_TablePrefix (105.50s)
--- PASS: TestAccAWSGlueCrawler_mongoDBTarget (106.41s)
--- PASS: TestAccAWSGlueCrawler_SecurityConfiguration (106.94s)
--- PASS: TestAccAWSGlueCrawler_Configuration (107.70s)
--- PASS: TestAccAWSGlueCrawler_Classifiers (131.46s)
--- PASS: TestAccAWSGlueCrawler_lineageConfig (137.58s)
--- PASS: TestAccAWSGlueCrawler_S3Target_Multiple (137.81s)
--- PASS: TestAccAWSGlueCrawler_Tags (143.57s)
--- PASS: TestAccAWSGlueCrawler_Schedule (144.32s)
--- PASS: TestAccAWSGlueCrawler_recrawlPolicy (145.38s)
--- PASS: TestAccAWSGlueCrawler_S3Target_ConnectionName (88.33s)
--- PASS: TestAccAWSGlueCrawler_S3Target (97.16s)
--- PASS: TestAccAWSGlueCrawler_CatalogTarget (159.95s)
--- PASS: TestAccAWSGlueCrawler_DynamodbTarget_scanRate (122.54s)
--- PASS: TestAccAWSGlueCrawler_mongoDBTarget_scan_all (129.35s)
--- PASS: TestAccAWSGlueCrawler_JdbcTarget (93.15s)
--- PASS: TestAccAWSGlueCrawler_S3Target_Exclusions (89.41s)
--- PASS: TestAccAWSGlueCrawler_JdbcTarget_Exclusions (90.79s)
--- PASS: TestAccAWSGlueCrawler_DynamodbTarget_scanAll (123.02s)
--- PASS: TestAccAWSGlueCrawler_mongoDBTarget_multiple (124.25s)
--- PASS: TestAccAWSGlueCrawler_JdbcTarget_Multiple (125.44s)
--- PASS: TestAccAWSGlueCrawler_CatalogTarget_Multiple (236.85s)

[SeanKilleen]

@DrFaust92 Thanks for the speedy review!

Do you have any insight on how long it typically takes from PR approval to provider release? Any amount of time is fine, but I'd like to set my team's expectations for when this change will become available. I'll look in the release logs / FAQ as well but your insight is appreciated.

[github-actions]

Thank you for your contribution! 🚀

Please note that the CHANGELOG.md file contents are handled by the maintainers during merge. This is to prevent pull request merge conflicts, especially for contributions which may not be merged immediately. Please see the Contributing Guide for additional pull request review items.

Remove any changes to the CHANGELOG.md file and commit them in this pull request to prevent delays with reviewing and potentially merging this pull request.

[SeanKilleen]

Hi @ewbankkit, not sure if this is the intended behavior, but your force push of my PR branch with the changelog modification now seems to have GitHub thinking that 3,000+ files were modified.

[ewbankkit]

@SeanKilleen I see what the problem is - You need to change the PR to be against main, not master (the default branch changed a while back).
I rebased onto the latest main and those 3000+ files are all new on the old master 😄.

It may be simpler just to create a new PR and close this one.
I can get it reviewed pretty quickly right now.

[SeanKilleen]

Hi @ewbankkit I updated the PR. Odd because I did it by editing the file on GitHub and creating the PR which I assume would have gone against the default branch by, well, default. 😆 Not sure why it wound up on the old name.

You may need to add your changelog commit one more time -- apologies!

[ewbankkit]

LGTM 🚀.

[ghost]

This has been released in version 3.38.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.