Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add plugins_s3_object_version to resourceAwsMwaaEnvironmentUpdate #19266

Conversation

jaceksztandera
Copy link

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #19265

Output from acceptance testing:

There are no acceptance tests for aws_mwaa_environment

@jaceksztandera jaceksztandera requested a review from a team as a code owner May 6, 2021 12:01
@ghost ghost added size/XS Managed by automation to categorize the size of a PR. service/mwaa Issues and PRs that pertain to the mwaa service. labels May 6, 2021
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label May 6, 2021
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @jaceksztandera 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@anGie44 anGie44 self-assigned this May 6, 2021
@anGie44 anGie44 added bug Addresses a defect in current functionality. and removed needs-triage Waiting for first response or review from a maintainer. labels May 6, 2021
@ghost ghost added size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. and removed size/XS Managed by automation to categorize the size of a PR. labels May 6, 2021
Copy link
Contributor

@anGie44 anGie44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this PR @jaceksztandera , changes look great! I've added an acceptance test to verify the update behavior 👍

Output of acceptance test:

--- PASS: TestAccAWSMwaaEnvironment_PluginsS3ObjectVersion (2707.67s)

@anGie44 anGie44 added this to the v3.39.0 milestone May 6, 2021
@anGie44 anGie44 merged commit 55b16fd into hashicorp:main May 6, 2021
@jaceksztandera jaceksztandera deleted the b-aws_mwaa_environment-plugins_s3_object_version-issue_19265 branch May 6, 2021 18:38
@jaceksztandera
Copy link
Author

Thanks @anGie44, I am looking forward for the next release! :)

@ghost
Copy link

ghost commented May 7, 2021

This has been released in version 3.39.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@github-actions
Copy link

github-actions bot commented Jun 6, 2021

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/mwaa Issues and PRs that pertain to the mwaa service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Resource aws_mwaa_environment configuration change of plugins_s3_object_version is not applied
2 participants