Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/servicecatalog_tag_option: New resource #19300

Merged
merged 12 commits into from
May 13, 2021
Merged

Conversation

YakDriver
Copy link
Member

@YakDriver YakDriver commented May 10, 2021

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #15369
Relates #18074
Relates #19122

Output from acceptance testing (us-west-2):

--- PASS: TestAccAWSServiceCatalogTagOption_disappears (11.33s)
--- PASS: TestAccAWSServiceCatalogTagOption_notActive (13.42s)
--- PASS: TestAccAWSServiceCatalogTagOption_basic (14.49s)
--- PASS: TestAccAWSServiceCatalogTagOption_update (47.60s)

Output from acceptance testing (GovCloud):

--- PASS: TestAccAWSServiceCatalogTagOption_disappears (14.15s)
--- PASS: TestAccAWSServiceCatalogTagOption_notActive (16.09s)
--- PASS: TestAccAWSServiceCatalogTagOption_basic (18.25s)
--- PASS: TestAccAWSServiceCatalogTagOption_update (60.28s)

Note: I'm not sure an AWS Organizations tests can ever run in GovCloud. GovCloud accounts are always tied to an existing commercial account so may not have the capacity of being a "payer" account.

@YakDriver YakDriver requested a review from a team as a code owner May 10, 2021 19:34
@ghost ghost added size/XL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/servicecatalog Issues and PRs that pertain to the servicecatalog service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels May 10, 2021
@ewbankkit ewbankkit self-assigned this May 11, 2021
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

Commercial
% make testacc TEST=./aws TESTARGS='-run=TestAccAWSServiceCatalogTagOption_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSServiceCatalogTagOption_ -timeout 180m
=== RUN   TestAccAWSServiceCatalogTagOption_basic
=== PAUSE TestAccAWSServiceCatalogTagOption_basic
=== RUN   TestAccAWSServiceCatalogTagOption_disappears
=== PAUSE TestAccAWSServiceCatalogTagOption_disappears
=== RUN   TestAccAWSServiceCatalogTagOption_update
=== PAUSE TestAccAWSServiceCatalogTagOption_update
=== RUN   TestAccAWSServiceCatalogTagOption_notActive
=== PAUSE TestAccAWSServiceCatalogTagOption_notActive
=== CONT  TestAccAWSServiceCatalogTagOption_basic
=== CONT  TestAccAWSServiceCatalogTagOption_notActive
=== CONT  TestAccAWSServiceCatalogTagOption_update
=== CONT  TestAccAWSServiceCatalogTagOption_disappears
--- PASS: TestAccAWSServiceCatalogTagOption_disappears (11.62s)
--- PASS: TestAccAWSServiceCatalogTagOption_notActive (13.20s)
--- PASS: TestAccAWSServiceCatalogTagOption_basic (15.93s)
--- PASS: TestAccAWSServiceCatalogTagOption_update (47.09s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	50.096s
GovCloud
% make testacc TEST=./aws TESTARGS='-run=TestAccAWSServiceCatalogTagOption_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSServiceCatalogTagOption_ -timeout 180m
=== RUN   TestAccAWSServiceCatalogTagOption_basic
=== PAUSE TestAccAWSServiceCatalogTagOption_basic
=== RUN   TestAccAWSServiceCatalogTagOption_disappears
=== PAUSE TestAccAWSServiceCatalogTagOption_disappears
=== RUN   TestAccAWSServiceCatalogTagOption_update
=== PAUSE TestAccAWSServiceCatalogTagOption_update
=== RUN   TestAccAWSServiceCatalogTagOption_notActive
=== PAUSE TestAccAWSServiceCatalogTagOption_notActive
=== CONT  TestAccAWSServiceCatalogTagOption_basic
=== CONT  TestAccAWSServiceCatalogTagOption_notActive
=== CONT  TestAccAWSServiceCatalogTagOption_update
=== CONT  TestAccAWSServiceCatalogTagOption_disappears
--- PASS: TestAccAWSServiceCatalogTagOption_disappears (13.84s)
--- PASS: TestAccAWSServiceCatalogTagOption_notActive (15.82s)
--- PASS: TestAccAWSServiceCatalogTagOption_basic (22.73s)
--- PASS: TestAccAWSServiceCatalogTagOption_update (63.14s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	66.314s

@ewbankkit ewbankkit removed their assignment May 11, 2021
@YakDriver YakDriver added this to the v3.40.0 milestone May 13, 2021
@YakDriver YakDriver merged commit d25da92 into main May 13, 2021
@YakDriver YakDriver deleted the f-servicecat-tag-option branch May 13, 2021 00:36
github-actions bot pushed a commit that referenced this pull request May 13, 2021
@ghost
Copy link

ghost commented May 13, 2021

This has been released in version 3.40.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/servicecatalog Issues and PRs that pertain to the servicecatalog service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants