Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resource/timestreamwrite_table: new resource #19354

Merged
merged 6 commits into from
May 13, 2021
Merged

resource/timestreamwrite_table: new resource #19354

merged 6 commits into from
May 13, 2021

Conversation

anGie44
Copy link
Contributor

@anGie44 anGie44 commented May 13, 2021 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #15422

Output from acceptance testing (Commercial):

--- PASS: TestAccAWSTimestreamWriteTable_disappears (19.57s)
--- PASS: TestAccAWSTimestreamWriteTable_basic (23.45s)
--- PASS: TestAccAWSTimestreamWriteTable_Tags (50.81s)
--- PASS: TestAccAWSTimestreamWriteTable_RetentionProperties (50.93s)

Output from acceptance testing (GovCloud):

--- SKIP: TestAccAWSTimestreamWriteTable_Tags (18.75s)
--- SKIP: TestAccAWSTimestreamWriteTable_disappears (22.40s)
--- SKIP: TestAccAWSTimestreamWriteTable_basic (24.45s)
--- SKIP: TestAccAWSTimestreamWriteTable_RetentionProperties (26.34s)

@anGie44 anGie44 requested a review from a team as a code owner May 13, 2021 06:24
@ghost ghost added size/XL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/timestreamwrite Issues and PRs that pertain to the timestreamwrite service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels May 13, 2021
@anGie44 anGie44 added the new-resource Introduces a new resource. label May 13, 2021
ewbankkit
ewbankkit reviewed May 13, 2021
View reviewed changes
aws/resource_aws_timestreamwrite_table.go
TableName: aws.String(tableName),
}

_, err = conn.DeleteTableWithContext(ctx, input)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add line

log.Printf("[DEBUG] Deleting Timestream Table (%s)", d.Id())

so that the sweeper reports the deletion.

ewbankkit
ewbankkit approved these changes May 13, 2021
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

Commercial
% make testacc TEST=./aws TESTARGS='-run=TestAccAWSTimestreamWriteTable_'                
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSTimestreamWriteTable_ -timeout 180m
=== RUN   TestAccAWSTimestreamWriteTable_basic
=== PAUSE TestAccAWSTimestreamWriteTable_basic
=== RUN   TestAccAWSTimestreamWriteTable_disappears
=== PAUSE TestAccAWSTimestreamWriteTable_disappears
=== RUN   TestAccAWSTimestreamWriteTable_RetentionProperties
=== PAUSE TestAccAWSTimestreamWriteTable_RetentionProperties
=== RUN   TestAccAWSTimestreamWriteTable_Tags
=== PAUSE TestAccAWSTimestreamWriteTable_Tags
=== CONT  TestAccAWSTimestreamWriteTable_basic
=== CONT  TestAccAWSTimestreamWriteTable_Tags
=== CONT  TestAccAWSTimestreamWriteTable_RetentionProperties
=== CONT  TestAccAWSTimestreamWriteTable_disappears
--- PASS: TestAccAWSTimestreamWriteTable_disappears (21.54s)
--- PASS: TestAccAWSTimestreamWriteTable_basic (27.19s)
--- PASS: TestAccAWSTimestreamWriteTable_Tags (55.98s)
--- PASS: TestAccAWSTimestreamWriteTable_RetentionProperties (57.08s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	60.072s
GovCloud
 % make testacc TEST=./aws TESTARGS='-run=TestAccAWSTimestreamWriteTable_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSTimestreamWriteTable_ -timeout 180m
=== RUN   TestAccAWSTimestreamWriteTable_basic
=== PAUSE TestAccAWSTimestreamWriteTable_basic
=== RUN   TestAccAWSTimestreamWriteTable_disappears
=== PAUSE TestAccAWSTimestreamWriteTable_disappears
=== RUN   TestAccAWSTimestreamWriteTable_RetentionProperties
=== PAUSE TestAccAWSTimestreamWriteTable_RetentionProperties
=== RUN   TestAccAWSTimestreamWriteTable_Tags
=== PAUSE TestAccAWSTimestreamWriteTable_Tags
=== CONT  TestAccAWSTimestreamWriteTable_basic
=== CONT  TestAccAWSTimestreamWriteTable_Tags
=== CONT  TestAccAWSTimestreamWriteTable_disappears
=== CONT  TestAccAWSTimestreamWriteTable_RetentionProperties
^CFAIL	github.com/terraform-providers/terraform-provider-aws/aws	134.323s
make: *** [testacc] Error 1

If I run aws --debug timestream-write list-databases it hangs at

2021-05-13 11:00:41,332 - MainThread - urllib3.connectionpool - DEBUG - Starting new HTTPS connection (1): ingest.timestream.us-gov-west-1.amazonaws.com:443

@anGie44
Copy link
Contributor Author

anGie44 commented May 13, 2021 •
edited
Loading

If I run aws --debug timestream-write list-databases it hangs a

🤔 maybe there was some downtime in GovCloud? I just re-ran again in us-gov-west-1 in case and seeing the tests skipped but no hanging atm

    resource_aws_timestreamwrite_database_test.go:321: skipping acceptance testing: RequestError: send request failed
        caused by: Post "https://ingest.timestream.us-gov-west-1.amazonaws.com/": dial tcp: lookup ingest.timestream.us-gov-west-1.amazonaws.com: no such host
--- SKIP: TestAccAWSTimestreamWriteTable_disappears (21.31s)
=== CONT  TestAccAWSTimestreamWriteTable_Tags
    resource_aws_timestreamwrite_database_test.go:321: skipping acceptance testing: RequestError: send request failed
        caused by: Post "https://ingest.timestream.us-gov-west-1.amazonaws.com/": dial tcp: lookup ingest.timestream.us-gov-west-1.amazonaws.com: no such host
--- SKIP: TestAccAWSTimestreamWriteTable_Tags (27.50s)
=== CONT  TestAccAWSTimestreamWriteTable_basic
    resource_aws_timestreamwrite_database_test.go:321: skipping acceptance testing: RequestError: send request failed
        caused by: Post "https://ingest.timestream.us-gov-west-1.amazonaws.com/": dial tcp: lookup ingest.timestream.us-gov-west-1.amazonaws.com: no such host
--- SKIP: TestAccAWSTimestreamWriteTable_basic (27.65s)
=== CONT  TestAccAWSTimestreamWriteTable_RetentionProperties
    resource_aws_timestreamwrite_database_test.go:321: skipping acceptance testing: RequestError: send request failed
        caused by: Post "https://ingest.timestream.us-gov-west-1.amazonaws.com/": dial tcp: lookup ingest.timestream.us-gov-west-1.amazonaws.com: no such host
--- SKIP: TestAccAWSTimestreamWriteTable_RetentionProperties (28.12s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	30.907s

@anGie44 anGie44 added this to the v3.40.0 milestone May 13, 2021
@anGie44 anGie44 merged commit 4ff6793 into main May 13, 2021
@anGie44 anGie44 deleted the f-timestreamwrite-table branch May 13, 2021 20:47
github-actions bot pushed a commit that referenced this pull request May 13, 2021
Update CHANGELOG.md for #19354
583b82d
@ghost
Copy link

ghost commented May 13, 2021

This has been released in version 3.40.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. new-resource Introduces a new resource. provider Pertains to the provider itself, rather than any interaction with AWS. service/timestreamwrite Issues and PRs that pertain to the timestreamwrite service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.40.0
Development

Successfully merging this pull request may close these issues.

New Resource: aws_timestreamwrite_table
2 participants
@anGie44 @ewbankkit