Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New resource for Delegated Administrators for Organizations and datasources for Delegated Administrators and Services #19389

Merged
merged 7 commits into from
May 18, 2021
Merged

New resource for Delegated Administrators for Organizations and datasources for Delegated Administrators and Services #19389

merged 7 commits into from
May 18, 2021

Conversation

coderGo93
Copy link
Contributor

@coderGo93 coderGo93 commented May 15, 2021 •
edited by gdavison
Loading

  • Added a new resource, docs and tests for AWS Organizations Delegated Administrator called aws_organizations_delegated_administrator
  • Added datasources for AWS Organizations Delegated Administrators called aws_organizations_delegated_administrators
  • Added datasources for AWS Organizations Delegated Services called aws_organizations_delegated_services

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #14932

Output from acceptance testing:

$  make testacc TESTARGS='-run=TestAccAWSOrganizations_serial/DelegatedAdministrator'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSOrganizations_serial/DelegatedAdministrator -timeout 180m
=== RUN   TestAccAWSOrganizations_serial
=== RUN   TestAccAWSOrganizations_serial/DelegatedAdministrator
=== RUN   TestAccAWSOrganizations_serial/DelegatedAdministrator/basic
=== RUN   TestAccAWSOrganizations_serial/DelegatedAdministrator/disappears
--- PASS: TestAccAWSOrganizations_serial (50.31s)
    --- PASS: TestAccAWSOrganizations_serial/DelegatedAdministrator (50.31s)
        --- PASS: TestAccAWSOrganizations_serial/DelegatedAdministrator/basic (28.50s)
        --- PASS: TestAccAWSOrganizations_serial/DelegatedAdministrator/disappears (21.81s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       50.370s

...

$  make testacc TESTARGS='-run=TestAccDataSourceAwsOrganizationsDelegatedAdministrators_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccDataSourceAwsOrganizationsDelegatedAdministrators_basic -timeout 180m
=== RUN   TestAccDataSourceAwsOrganizationsDelegatedAdministrators_basic
=== PAUSE TestAccDataSourceAwsOrganizationsDelegatedAdministrators_basic
=== CONT  TestAccDataSourceAwsOrganizationsDelegatedAdministrators_basic
--- PASS: TestAccDataSourceAwsOrganizationsDelegatedAdministrators_basic (24.67s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       24.721s

...

$  make testacc TESTARGS='-run=TestAccDataSourceAwsOrganizationsDelegatedServices_basic'      
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccDataSourceAwsOrganizationsDelegatedServices_basic -timeout 180m
=== RUN   TestAccDataSourceAwsOrganizationsDelegatedServices_basic
=== PAUSE TestAccDataSourceAwsOrganizationsDelegatedServices_basic
=== CONT  TestAccDataSourceAwsOrganizationsDelegatedServices_basic
--- PASS: TestAccDataSourceAwsOrganizationsDelegatedServices_basic (21.35s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       21.404s

...

@coderGo93 coderGo93 requested a review from a team as a code owner May 15, 2021 00:53
@ghost ghost added size/XL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/organizations Issues and PRs that pertain to the organizations service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels May 15, 2021
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label May 15, 2021
gdavison
gdavison requested changes May 17, 2021
View reviewed changes
Copy link
Contributor

@gdavison gdavison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. I have a number of suggestions

aws/data_source_aws_organizations_delegated_administrators.go Outdated Show resolved Hide resolved
aws/data_source_aws_organizations_delegated_administrators.go Outdated Show resolved Hide resolved
aws/data_source_aws_organizations_delegated_administrators_test.go Show resolved Hide resolved
aws/data_source_aws_organizations_delegated_services.go Outdated Show resolved Hide resolved
aws/data_source_aws_organizations_delegated_services.go Outdated Show resolved Hide resolved
aws/resource_aws_organizations_delegated_administrator.go Outdated Show resolved Hide resolved
aws/data_source_aws_organizations_delegated_administrators_test.go Outdated Show resolved Hide resolved
aws/data_source_aws_organizations_delegated_services_test.go Outdated Show resolved Hide resolved
aws/data_source_aws_organizations_delegated_administrators_test.go Show resolved Hide resolved
website/docs/r/organizations_delegated_administrator.html.markdown Outdated Show resolved Hide resolved
@gdavison gdavison removed the needs-triage Waiting for first response or review from a maintainer. label May 18, 2021
@coderGo93 coderGo93 force-pushed the delegated-admin-org branch from 272371a to 25880de Compare May 18, 2021 18:03
@coderGo93 coderGo93 requested a review from gdavison May 18, 2021 18:07
gdavison
gdavison requested changes May 18, 2021
View reviewed changes
Copy link
Contributor

@gdavison gdavison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few more changes

aws/data_source_aws_organizations_delegated_administrators.go Outdated Show resolved Hide resolved
aws/data_source_aws_organizations_delegated_administrators_test.go Show resolved Hide resolved
aws/data_source_aws_organizations_delegated_administrators_test.go Show resolved Hide resolved
aws/data_source_aws_organizations_delegated_services.go Outdated Show resolved Hide resolved
aws/data_source_aws_organizations_delegated_services_test.go Show resolved Hide resolved
aws/data_source_aws_organizations_delegated_administrators_test.go Outdated Show resolved Hide resolved
@coderGo93 coderGo93 requested a review from gdavison May 18, 2021 22:47
@gdavison gdavison merged commit b9a95df into hashicorp:main May 18, 2021
@github-actions github-actions bot added this to the v3.41.0 milestone May 18, 2021
gdavison
gdavison reviewed May 18, 2021
View reviewed changes
Copy link
Contributor

@gdavison gdavison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 🚀

@ghost
Copy link

ghost commented May 19, 2021

This has been released in version 3.41.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@sbldevnet sbldevnet mentioned this pull request Jun 17, 2021
Closed
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gdavison gdavison gdavison requested changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/organizations Issues and PRs that pertain to the organizations service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.41.0
Development

Successfully merging this pull request may close these issues.

Support Delegated Administrators for Organizations
2 participants
@coderGo93 @gdavison