Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creating aws_ec2_managed_prefix_list_entry resource #19394

Merged
merged 6 commits into from
Sep 23, 2021
Merged

Creating aws_ec2_managed_prefix_list_entry resource #19394

merged 6 commits into from
Sep 23, 2021

Conversation

missingcharacter
Copy link
Contributor

@missingcharacter missingcharacter commented May 15, 2021

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

It does not relate to an open issue or Pull Request

Note: I'm changing the entry field in aws_ec2_managed_prefix_list to be Computed: true,, this way if no entry is specified we can use aws_ec2_managed_prefix_list_entry to create them. Also, this change does not break tests for aws_ec2_managed_prefix_list as shown below.

Output from acceptance testing:

$ AWS_DEFAULT_REGION=us-west-2 AWS_PROFILE=my-testing-profile make testacc TESTARGS='-run=TestAccAwsEc2ManagedPrefixList'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAwsEc2ManagedPrefixList -timeout 180m
=== RUN   TestAccAwsEc2ManagedPrefixListEntry_ipv4
=== PAUSE TestAccAwsEc2ManagedPrefixListEntry_ipv4
=== RUN   TestAccAwsEc2ManagedPrefixListEntry_ipv6
=== PAUSE TestAccAwsEc2ManagedPrefixListEntry_ipv6
=== RUN   TestAccAwsEc2ManagedPrefixListEntry_expectInvalidTypeError
=== PAUSE TestAccAwsEc2ManagedPrefixListEntry_expectInvalidTypeError
=== RUN   TestAccAwsEc2ManagedPrefixListEntry_expectInvalidCIDR
=== PAUSE TestAccAwsEc2ManagedPrefixListEntry_expectInvalidCIDR
=== RUN   TestAccAwsEc2ManagedPrefixListEntry_description
=== PAUSE TestAccAwsEc2ManagedPrefixListEntry_description
=== RUN   TestAccAwsEc2ManagedPrefixListEntry_disappears
=== PAUSE TestAccAwsEc2ManagedPrefixListEntry_disappears
=== RUN   TestAccAwsEc2ManagedPrefixList_basic
=== PAUSE TestAccAwsEc2ManagedPrefixList_basic
=== RUN   TestAccAwsEc2ManagedPrefixList_disappears
=== PAUSE TestAccAwsEc2ManagedPrefixList_disappears
=== RUN   TestAccAwsEc2ManagedPrefixList_AddressFamily_IPv6
=== PAUSE TestAccAwsEc2ManagedPrefixList_AddressFamily_IPv6
=== RUN   TestAccAwsEc2ManagedPrefixList_Entry_Cidr
=== PAUSE TestAccAwsEc2ManagedPrefixList_Entry_Cidr
=== RUN   TestAccAwsEc2ManagedPrefixList_Entry_Description
=== PAUSE TestAccAwsEc2ManagedPrefixList_Entry_Description
=== RUN   TestAccAwsEc2ManagedPrefixList_Name
=== PAUSE TestAccAwsEc2ManagedPrefixList_Name
=== RUN   TestAccAwsEc2ManagedPrefixList_Tags
=== PAUSE TestAccAwsEc2ManagedPrefixList_Tags
=== CONT  TestAccAwsEc2ManagedPrefixListEntry_ipv4
=== CONT  TestAccAwsEc2ManagedPrefixList_disappears
=== CONT  TestAccAwsEc2ManagedPrefixList_Tags
=== CONT  TestAccAwsEc2ManagedPrefixList_Name
=== CONT  TestAccAwsEc2ManagedPrefixListEntry_description
=== CONT  TestAccAwsEc2ManagedPrefixListEntry_disappears
=== CONT  TestAccAwsEc2ManagedPrefixListEntry_expectInvalidCIDR
=== CONT  TestAccAwsEc2ManagedPrefixListEntry_ipv6
=== CONT  TestAccAwsEc2ManagedPrefixList_Entry_Description
=== CONT  TestAccAwsEc2ManagedPrefixList_Entry_Cidr
=== CONT  TestAccAwsEc2ManagedPrefixList_AddressFamily_IPv6
=== CONT  TestAccAwsEc2ManagedPrefixList_basic
=== CONT  TestAccAwsEc2ManagedPrefixListEntry_expectInvalidTypeError
--- PASS: TestAccAwsEc2ManagedPrefixListEntry_expectInvalidTypeError (5.42s)
--- PASS: TestAccAwsEc2ManagedPrefixListEntry_expectInvalidCIDR (6.12s)
--- PASS: TestAccAwsEc2ManagedPrefixList_disappears (27.20s)
--- PASS: TestAccAwsEc2ManagedPrefixList_AddressFamily_IPv6 (32.60s)
--- PASS: TestAccAwsEc2ManagedPrefixList_basic (32.64s)
--- PASS: TestAccAwsEc2ManagedPrefixListEntry_ipv6 (34.40s)
--- PASS: TestAccAwsEc2ManagedPrefixListEntry_disappears (34.69s)
--- PASS: TestAccAwsEc2ManagedPrefixListEntry_description (34.70s)
--- PASS: TestAccAwsEc2ManagedPrefixList_Name (44.52s)
--- PASS: TestAccAwsEc2ManagedPrefixList_Entry_Description (46.54s)
--- PASS: TestAccAwsEc2ManagedPrefixList_Entry_Cidr (48.49s)
--- PASS: TestAccAwsEc2ManagedPrefixList_Tags (55.49s)
--- PASS: TestAccAwsEc2ManagedPrefixListEntry_ipv4 (61.09s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	61.218s

@missingcharacter missingcharacter requested a review from a team as a code owner May 15, 2021 22:56
@ghost ghost added size/XL Managed by automation to categorize the size of a PR. provider Pertains to the provider itself, rather than any interaction with AWS. service/ec2 Issues and PRs that pertain to the ec2 service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels May 15, 2021
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label May 15, 2021
@ghost ghost added the documentation Introduces or discusses updates to documentation. label May 15, 2021
Copy link
Member

@YakDriver YakDriver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@missingcharacter Thank for this PR! I performed a quick review on this and noted some items to fix. If you are able to fix these, that would be great. If not, please let us know so that we can either find someone in the community or take it on ourselves. Also, make sure to check "allow edit from maintainers" to expedite merging.

Unfortunately, we aren't able to get everything done we'd like so you may not hear back from us immediately. Hopefully, we'll be able to get to this in the near future.

aws/resource_aws_ec2_managed_prefix_list_entry.go Outdated Show resolved Hide resolved
aws/resource_aws_ec2_managed_prefix_list_entry.go Outdated Show resolved Hide resolved
aws/resource_aws_ec2_managed_prefix_list_entry.go Outdated Show resolved Hide resolved
aws/resource_aws_ec2_managed_prefix_list_entry.go Outdated Show resolved Hide resolved
aws/resource_aws_ec2_managed_prefix_list_entry_test.go Outdated Show resolved Hide resolved
aws/resource_aws_ec2_managed_prefix_list_entry_test.go Outdated Show resolved Hide resolved
aws/resource_aws_ec2_managed_prefix_list_entry_test.go Outdated Show resolved Hide resolved
aws/resource_aws_ec2_managed_prefix_list_entry_test.go Outdated Show resolved Hide resolved
aws/resource_aws_ec2_managed_prefix_list_entry_test.go Outdated Show resolved Hide resolved
@YakDriver YakDriver self-assigned this May 18, 2021
@YakDriver YakDriver removed the needs-triage Waiting for first response or review from a maintainer. label May 18, 2021
@missingcharacter
Copy link
Contributor Author

@YakDriver I will take care of these

@missingcharacter
Copy link
Contributor Author

@YakDriver I made the improvements you suggested, acceptance tests still pass and all checks are green

@missingcharacter
Copy link
Contributor Author

Hi @YakDriver am I missing something?

@missingcharacter
Copy link
Contributor Author

@YakDriver Hi, this is been here for a while now, is there something else I should do?

@ewbankkit ewbankkit assigned ewbankkit and unassigned YakDriver Sep 22, 2021
@missingcharacter
Copy link
Contributor Author

@ewbankkit The only lint errors I found were related to secrets manager

image

image

if fixing them would help get this merged, I'll do it

@ewbankkit
Copy link
Contributor

@missingcharacter No worries; I can make changes and push to your fork.

missingcharacter and others added 6 commits September 23, 2021 08:51
Acceptance test output:

% make testacc TESTARGS='-run=TestAccAwsEc2ManagedPrefixListEntry_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAwsEc2ManagedPrefixListEntry_ -timeout 180m
=== RUN   TestAccAwsEc2ManagedPrefixListEntry_ipv4
=== PAUSE TestAccAwsEc2ManagedPrefixListEntry_ipv4
=== RUN   TestAccAwsEc2ManagedPrefixListEntry_ipv6
=== PAUSE TestAccAwsEc2ManagedPrefixListEntry_ipv6
=== RUN   TestAccAwsEc2ManagedPrefixListEntry_expectInvalidTypeError
=== PAUSE TestAccAwsEc2ManagedPrefixListEntry_expectInvalidTypeError
=== RUN   TestAccAwsEc2ManagedPrefixListEntry_expectInvalidCIDR
=== PAUSE TestAccAwsEc2ManagedPrefixListEntry_expectInvalidCIDR
=== RUN   TestAccAwsEc2ManagedPrefixListEntry_description
=== PAUSE TestAccAwsEc2ManagedPrefixListEntry_description
=== RUN   TestAccAwsEc2ManagedPrefixListEntry_disappears
=== PAUSE TestAccAwsEc2ManagedPrefixListEntry_disappears
=== CONT  TestAccAwsEc2ManagedPrefixListEntry_ipv4
=== CONT  TestAccAwsEc2ManagedPrefixListEntry_description
=== CONT  TestAccAwsEc2ManagedPrefixListEntry_expectInvalidCIDR
=== CONT  TestAccAwsEc2ManagedPrefixListEntry_expectInvalidTypeError
=== CONT  TestAccAwsEc2ManagedPrefixListEntry_ipv6
=== CONT  TestAccAwsEc2ManagedPrefixListEntry_disappears
--- PASS: TestAccAwsEc2ManagedPrefixListEntry_expectInvalidTypeError (3.42s)
--- PASS: TestAccAwsEc2ManagedPrefixListEntry_expectInvalidCIDR (3.82s)
--- PASS: TestAccAwsEc2ManagedPrefixListEntry_disappears (29.57s)
--- PASS: TestAccAwsEc2ManagedPrefixListEntry_description (33.29s)
--- PASS: TestAccAwsEc2ManagedPrefixListEntry_ipv4 (33.90s)
--- PASS: TestAccAwsEc2ManagedPrefixListEntry_ipv6 (57.92s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	61.445s
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

Commercial
% make testacc TESTARGS='-run=TestAccAwsEc2ManagedPrefixListEntry_\|TestAccAwsEc2ManagedPrefixList_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAwsEc2ManagedPrefixListEntry_\|TestAccAwsEc2ManagedPrefixList_ -timeout 180m
=== RUN   TestAccAwsEc2ManagedPrefixListEntry_ipv4
=== PAUSE TestAccAwsEc2ManagedPrefixListEntry_ipv4
=== RUN   TestAccAwsEc2ManagedPrefixListEntry_ipv6
=== PAUSE TestAccAwsEc2ManagedPrefixListEntry_ipv6
=== RUN   TestAccAwsEc2ManagedPrefixListEntry_expectInvalidTypeError
=== PAUSE TestAccAwsEc2ManagedPrefixListEntry_expectInvalidTypeError
=== RUN   TestAccAwsEc2ManagedPrefixListEntry_expectInvalidCIDR
=== PAUSE TestAccAwsEc2ManagedPrefixListEntry_expectInvalidCIDR
=== RUN   TestAccAwsEc2ManagedPrefixListEntry_description
=== PAUSE TestAccAwsEc2ManagedPrefixListEntry_description
=== RUN   TestAccAwsEc2ManagedPrefixListEntry_disappears
=== PAUSE TestAccAwsEc2ManagedPrefixListEntry_disappears
=== RUN   TestAccAwsEc2ManagedPrefixList_basic
=== PAUSE TestAccAwsEc2ManagedPrefixList_basic
=== RUN   TestAccAwsEc2ManagedPrefixList_disappears
=== PAUSE TestAccAwsEc2ManagedPrefixList_disappears
=== RUN   TestAccAwsEc2ManagedPrefixList_AddressFamily_IPv6
=== PAUSE TestAccAwsEc2ManagedPrefixList_AddressFamily_IPv6
=== RUN   TestAccAwsEc2ManagedPrefixList_Entry_Cidr
=== PAUSE TestAccAwsEc2ManagedPrefixList_Entry_Cidr
=== RUN   TestAccAwsEc2ManagedPrefixList_Entry_Description
=== PAUSE TestAccAwsEc2ManagedPrefixList_Entry_Description
=== RUN   TestAccAwsEc2ManagedPrefixList_Name
=== PAUSE TestAccAwsEc2ManagedPrefixList_Name
=== RUN   TestAccAwsEc2ManagedPrefixList_Tags
=== PAUSE TestAccAwsEc2ManagedPrefixList_Tags
=== CONT  TestAccAwsEc2ManagedPrefixListEntry_ipv4
=== CONT  TestAccAwsEc2ManagedPrefixList_disappears
=== CONT  TestAccAwsEc2ManagedPrefixList_AddressFamily_IPv6
=== CONT  TestAccAwsEc2ManagedPrefixListEntry_description
=== CONT  TestAccAwsEc2ManagedPrefixListEntry_disappears
=== CONT  TestAccAwsEc2ManagedPrefixListEntry_expectInvalidTypeError
=== CONT  TestAccAwsEc2ManagedPrefixListEntry_expectInvalidCIDR
=== CONT  TestAccAwsEc2ManagedPrefixList_Name
=== CONT  TestAccAwsEc2ManagedPrefixList_Tags
=== CONT  TestAccAwsEc2ManagedPrefixListEntry_ipv6
=== CONT  TestAccAwsEc2ManagedPrefixList_Entry_Cidr
=== CONT  TestAccAwsEc2ManagedPrefixList_basic
=== CONT  TestAccAwsEc2ManagedPrefixList_Entry_Description
--- PASS: TestAccAwsEc2ManagedPrefixListEntry_expectInvalidTypeError (4.91s)
--- PASS: TestAccAwsEc2ManagedPrefixListEntry_expectInvalidCIDR (6.28s)
--- PASS: TestAccAwsEc2ManagedPrefixList_disappears (28.27s)
--- PASS: TestAccAwsEc2ManagedPrefixListEntry_disappears (40.10s)
--- PASS: TestAccAwsEc2ManagedPrefixListEntry_ipv4 (40.50s)
--- PASS: TestAccAwsEc2ManagedPrefixList_AddressFamily_IPv6 (40.59s)
--- PASS: TestAccAwsEc2ManagedPrefixListEntry_ipv6 (43.28s)
--- PASS: TestAccAwsEc2ManagedPrefixList_Entry_Cidr (52.83s)
--- PASS: TestAccAwsEc2ManagedPrefixList_Name (53.17s)
--- PASS: TestAccAwsEc2ManagedPrefixList_Entry_Description (54.53s)
--- PASS: TestAccAwsEc2ManagedPrefixList_basic (61.02s)
--- PASS: TestAccAwsEc2ManagedPrefixListEntry_description (62.49s)
--- PASS: TestAccAwsEc2ManagedPrefixList_Tags (64.05s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	68.051s
GovCloud
% make testacc TESTARGS='-run=TestAccAwsEc2ManagedPrefixListEntry_\|TestAccAwsEc2ManagedPrefixList_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAwsEc2ManagedPrefixListEntry_\|TestAccAwsEc2ManagedPrefixList_ -timeout 180m
=== RUN   TestAccAwsEc2ManagedPrefixListEntry_ipv4
=== PAUSE TestAccAwsEc2ManagedPrefixListEntry_ipv4
=== RUN   TestAccAwsEc2ManagedPrefixListEntry_ipv6
=== PAUSE TestAccAwsEc2ManagedPrefixListEntry_ipv6
=== RUN   TestAccAwsEc2ManagedPrefixListEntry_expectInvalidTypeError
=== PAUSE TestAccAwsEc2ManagedPrefixListEntry_expectInvalidTypeError
=== RUN   TestAccAwsEc2ManagedPrefixListEntry_expectInvalidCIDR
=== PAUSE TestAccAwsEc2ManagedPrefixListEntry_expectInvalidCIDR
=== RUN   TestAccAwsEc2ManagedPrefixListEntry_description
=== PAUSE TestAccAwsEc2ManagedPrefixListEntry_description
=== RUN   TestAccAwsEc2ManagedPrefixListEntry_disappears
=== PAUSE TestAccAwsEc2ManagedPrefixListEntry_disappears
=== RUN   TestAccAwsEc2ManagedPrefixList_basic
=== PAUSE TestAccAwsEc2ManagedPrefixList_basic
=== RUN   TestAccAwsEc2ManagedPrefixList_disappears
=== PAUSE TestAccAwsEc2ManagedPrefixList_disappears
=== RUN   TestAccAwsEc2ManagedPrefixList_AddressFamily_IPv6
=== PAUSE TestAccAwsEc2ManagedPrefixList_AddressFamily_IPv6
=== RUN   TestAccAwsEc2ManagedPrefixList_Entry_Cidr
=== PAUSE TestAccAwsEc2ManagedPrefixList_Entry_Cidr
=== RUN   TestAccAwsEc2ManagedPrefixList_Entry_Description
=== PAUSE TestAccAwsEc2ManagedPrefixList_Entry_Description
=== RUN   TestAccAwsEc2ManagedPrefixList_Name
=== PAUSE TestAccAwsEc2ManagedPrefixList_Name
=== RUN   TestAccAwsEc2ManagedPrefixList_Tags
=== PAUSE TestAccAwsEc2ManagedPrefixList_Tags
=== CONT  TestAccAwsEc2ManagedPrefixListEntry_ipv4
=== CONT  TestAccAwsEc2ManagedPrefixList_Tags
=== CONT  TestAccAwsEc2ManagedPrefixList_Entry_Description
=== CONT  TestAccAwsEc2ManagedPrefixListEntry_disappears
=== CONT  TestAccAwsEc2ManagedPrefixList_basic
=== CONT  TestAccAwsEc2ManagedPrefixList_Entry_Cidr
=== CONT  TestAccAwsEc2ManagedPrefixList_AddressFamily_IPv6
=== CONT  TestAccAwsEc2ManagedPrefixList_Name
=== CONT  TestAccAwsEc2ManagedPrefixListEntry_description
=== CONT  TestAccAwsEc2ManagedPrefixListEntry_expectInvalidTypeError
=== CONT  TestAccAwsEc2ManagedPrefixListEntry_expectInvalidCIDR
=== CONT  TestAccAwsEc2ManagedPrefixListEntry_ipv6
=== CONT  TestAccAwsEc2ManagedPrefixList_disappears
=== CONT  TestAccAwsEc2ManagedPrefixList_basic
    resource_aws_ec2_managed_prefix_list_test.go:358: skipping acceptance testing: InvalidAction: The action DescribeManagedPrefixLists is not valid for this web service.
        	status code: 400, request id: 13046c9e-bdca-40aa-9f49-fa9b4add5380
--- SKIP: TestAccAwsEc2ManagedPrefixList_basic (1.88s)
=== CONT  TestAccAwsEc2ManagedPrefixList_Name
    resource_aws_ec2_managed_prefix_list_test.go:358: skipping acceptance testing: InvalidAction: The action DescribeManagedPrefixLists is not valid for this web service.
        	status code: 400, request id: 961bc4bd-f38c-404c-b7d4-979cf51c17fd
--- SKIP: TestAccAwsEc2ManagedPrefixList_Name (1.89s)
=== CONT  TestAccAwsEc2ManagedPrefixListEntry_expectInvalidCIDR
    resource_aws_ec2_managed_prefix_list_test.go:358: skipping acceptance testing: InvalidAction: The action DescribeManagedPrefixLists is not valid for this web service.
        	status code: 400, request id: ac12e0d5-2498-4cf6-bc3a-7f70463c5798
--- SKIP: TestAccAwsEc2ManagedPrefixListEntry_expectInvalidCIDR (1.89s)
=== CONT  TestAccAwsEc2ManagedPrefixList_Entry_Cidr
    resource_aws_ec2_managed_prefix_list_test.go:358: skipping acceptance testing: InvalidAction: The action DescribeManagedPrefixLists is not valid for this web service.
        	status code: 400, request id: 4b815dd2-a685-4a01-8207-5dd29fd0d0c0
--- SKIP: TestAccAwsEc2ManagedPrefixList_Entry_Cidr (1.89s)
=== CONT  TestAccAwsEc2ManagedPrefixListEntry_expectInvalidTypeError
    resource_aws_ec2_managed_prefix_list_test.go:358: skipping acceptance testing: InvalidAction: The action DescribeManagedPrefixLists is not valid for this web service.
        	status code: 400, request id: dcd3fd5e-0d61-4e51-8849-0ec720d7bd42
--- SKIP: TestAccAwsEc2ManagedPrefixListEntry_expectInvalidTypeError (1.89s)
=== CONT  TestAccAwsEc2ManagedPrefixList_Entry_Description
    resource_aws_ec2_managed_prefix_list_test.go:358: skipping acceptance testing: InvalidAction: The action DescribeManagedPrefixLists is not valid for this web service.
        	status code: 400, request id: 8fb46be3-4fc1-4028-82a0-e425b2606e6b
--- SKIP: TestAccAwsEc2ManagedPrefixList_Entry_Description (1.90s)
=== CONT  TestAccAwsEc2ManagedPrefixList_Tags
    resource_aws_ec2_managed_prefix_list_test.go:358: skipping acceptance testing: InvalidAction: The action DescribeManagedPrefixLists is not valid for this web service.
        	status code: 400, request id: 2c9fc8ad-1cb8-44d1-b352-ae7fc1af1282
--- SKIP: TestAccAwsEc2ManagedPrefixList_Tags (1.90s)
=== CONT  TestAccAwsEc2ManagedPrefixList_AddressFamily_IPv6
    resource_aws_ec2_managed_prefix_list_test.go:358: skipping acceptance testing: InvalidAction: The action DescribeManagedPrefixLists is not valid for this web service.
        	status code: 400, request id: adf15578-6414-425c-ab7e-a1204e4767c1
--- SKIP: TestAccAwsEc2ManagedPrefixList_AddressFamily_IPv6 (1.90s)
=== CONT  TestAccAwsEc2ManagedPrefixListEntry_ipv4
    resource_aws_ec2_managed_prefix_list_test.go:358: skipping acceptance testing: InvalidAction: The action DescribeManagedPrefixLists is not valid for this web service.
        	status code: 400, request id: 5151a445-f13b-4d35-9109-7abc87b9ade2
--- SKIP: TestAccAwsEc2ManagedPrefixListEntry_ipv4 (1.90s)
=== CONT  TestAccAwsEc2ManagedPrefixListEntry_description
    resource_aws_ec2_managed_prefix_list_test.go:358: skipping acceptance testing: InvalidAction: The action DescribeManagedPrefixLists is not valid for this web service.
        	status code: 400, request id: e4058b22-1c5e-4de4-8ba2-4e04b9b09997
--- SKIP: TestAccAwsEc2ManagedPrefixListEntry_description (1.91s)
=== CONT  TestAccAwsEc2ManagedPrefixListEntry_disappears
    resource_aws_ec2_managed_prefix_list_test.go:358: skipping acceptance testing: InvalidAction: The action DescribeManagedPrefixLists is not valid for this web service.
        	status code: 400, request id: 024427c2-8789-43f9-a6f8-791defd80399
--- SKIP: TestAccAwsEc2ManagedPrefixListEntry_disappears (1.91s)
=== CONT  TestAccAwsEc2ManagedPrefixListEntry_ipv6
    resource_aws_ec2_managed_prefix_list_test.go:358: skipping acceptance testing: InvalidAction: The action DescribeManagedPrefixLists is not valid for this web service.
        	status code: 400, request id: 9861f174-8ef5-4a5c-91b6-9b63c5d45c6e
--- SKIP: TestAccAwsEc2ManagedPrefixListEntry_ipv6 (1.91s)
=== CONT  TestAccAwsEc2ManagedPrefixList_disappears
    resource_aws_ec2_managed_prefix_list_test.go:358: skipping acceptance testing: InvalidAction: The action DescribeManagedPrefixLists is not valid for this web service.
        	status code: 400, request id: 677e867c-ee3f-4dee-86d5-3bcbc8ff17a6
--- SKIP: TestAccAwsEc2ManagedPrefixList_disappears (1.91s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	6.656s

@ewbankkit
Copy link
Contributor

@missingcharacter Thanks for the contribution 🎉 👏.

@ewbankkit
Copy link
Contributor

Relates: #20991.

@missingcharacter
Copy link
Contributor Author

Thanks @ewbankkit 🙇🏼

@ewbankkit ewbankkit merged commit cd62a45 into hashicorp:main Sep 23, 2021
@github-actions github-actions bot added this to the v3.60.0 milestone Sep 23, 2021
@missingcharacter missingcharacter deleted the prefix-list branch September 23, 2021 14:05
@github-actions
Copy link

This functionality has been released in v3.60.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/ec2 Issues and PRs that pertain to the ec2 service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants