Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide support for security group rules description. #1940

Closed
hashibot opened this issue Oct 17, 2017 · 9 comments
Closed

Provide support for security group rules description. #1940

hashibot opened this issue Oct 17, 2017 · 9 comments
Labels
enhancement Requests to existing resources that expand the functionality or scope.

Comments

@hashibot
Copy link

This issue was originally opened by @ssala7 as hashicorp/terraform#16372. It was migrated here as a result of the provider split. The original body of the issue is below.


#https://www.terraform.io/docs/providers/aws/d/security_group.html

Add a description/comment for ingress and egress rules.

Example:

resource "aws_security_group" "my_sg" {
name = "my_sg"
description = "my_sg"
vpc_id = "vpc-xxxxxxx"

ingress {
from_port = 443
to_port = 443
protocol = "tcp"
cidr_blocks = ["0.0.0.0/0"]
description = "Open to internet"
}

@hashibot hashibot added the enhancement Requests to existing resources that expand the functionality or scope. label Oct 17, 2017
@Ninir
Copy link
Contributor

Ninir commented Oct 18, 2017

Hi @ssala7,

This was already added and has been released in 1.1.0 🚀

Closing! :)

@takeda-joao
Copy link

Hi,

is this only available in v1.1.0?
I am using v0.10.8 which is the last release.
Thanks.

@Ninir
Copy link
Contributor

Ninir commented Oct 26, 2017

Hi @takeda-joao

Indeed, only in the 1.1.0 of the AWS Provider, which is different from the 0.10.8 of Terraform.
Providers (AWS, Google, ...) now have their own repository, issues & semantic versioning.

Tell us how it goes :)

@takeda-joao
Copy link

Hi,

how do i get release 1.1.0?
Thanks.

@takeda-joao
Copy link

I guess I need to build it.
Will try.

@Ninir
Copy link
Contributor

Ninir commented Oct 26, 2017

You don't need to build it: just remove the .terraform/plugins directory in every stack you want to have it, and then run terraform init again :)

@takeda-joao
Copy link

oh, ok.
Thanks.

@takeda-joao
Copy link

It worked. But I am getting an error when I try to apply again (with no updates to be applied).
This does not happen if the SG does not have rules with description set.

  • aws_security_group.*****-sg-devops: Error revoking security group ingress rules: InvalidPermission.NotFound: The specified rule does not exist in this security group.
    status code: 400, request id: 47f1cec5-aebd-4043-a889-368ca394b8a5

@ghost
Copy link

ghost commented Apr 10, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope.
Projects
None yet
Development

No branches or pull requests

3 participants