Initial implementation of self_managed_event_source for aws_lambda_event_source_mapping #19425

delbaeth · 2021-05-18T16:12:38Z

Community Note

Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #16785.
Closes #17825.
Closes #16786.
Closes #16787.
Closes #14042.
Closes #16074.
Closes #18099.

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

make testacc TESTARGS='-run=TestAccAWSLambdaEventSourceMapping_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSLambdaEventSourceMapping_ -timeout 180m
=== RUN   TestAccAWSLambdaEventSourceMapping_Kinesis_basic
=== PAUSE TestAccAWSLambdaEventSourceMapping_Kinesis_basic
=== RUN   TestAccAWSLambdaEventSourceMapping_SQS_basic
=== PAUSE TestAccAWSLambdaEventSourceMapping_SQS_basic
=== RUN   TestAccAWSLambdaEventSourceMapping_DynamoDB_basic
=== PAUSE TestAccAWSLambdaEventSourceMapping_DynamoDB_basic
=== RUN   TestAccAWSLambdaEventSourceMapping_SQS_BatchWindow
=== PAUSE TestAccAWSLambdaEventSourceMapping_SQS_BatchWindow
=== RUN   TestAccAWSLambdaEventSourceMapping_disappears
=== PAUSE TestAccAWSLambdaEventSourceMapping_disappears
=== RUN   TestAccAWSLambdaEventSourceMapping_SQS_changesInEnabledAreDetected
=== PAUSE TestAccAWSLambdaEventSourceMapping_SQS_changesInEnabledAreDetected
=== RUN   TestAccAWSLambdaEventSourceMapping_Kinesis_StartingPositionTimestamp
=== PAUSE TestAccAWSLambdaEventSourceMapping_Kinesis_StartingPositionTimestamp
=== RUN   TestAccAWSLambdaEventSourceMapping_Kinesis_BatchWindow
=== PAUSE TestAccAWSLambdaEventSourceMapping_Kinesis_BatchWindow
=== RUN   TestAccAWSLambdaEventSourceMapping_Kinesis_ParallelizationFactor
=== PAUSE TestAccAWSLambdaEventSourceMapping_Kinesis_ParallelizationFactor
=== RUN   TestAccAWSLambdaEventSourceMapping_Kinesis_MaximumRetryAttempts
=== PAUSE TestAccAWSLambdaEventSourceMapping_Kinesis_MaximumRetryAttempts
=== RUN   TestAccAWSLambdaEventSourceMapping_Kinesis_MaximumRetryAttemptsZero
=== PAUSE TestAccAWSLambdaEventSourceMapping_Kinesis_MaximumRetryAttemptsZero
=== RUN   TestAccAWSLambdaEventSourceMapping_Kinesis_MaximumRetryAttemptsNegativeOne
=== PAUSE TestAccAWSLambdaEventSourceMapping_Kinesis_MaximumRetryAttemptsNegativeOne
=== RUN   TestAccAWSLambdaEventSourceMapping_Kinesis_MaximumRecordAgeInSeconds
=== PAUSE TestAccAWSLambdaEventSourceMapping_Kinesis_MaximumRecordAgeInSeconds
=== RUN   TestAccAWSLambdaEventSourceMapping_Kinesis_MaximumRecordAgeInSecondsNegativeOne
=== PAUSE TestAccAWSLambdaEventSourceMapping_Kinesis_MaximumRecordAgeInSecondsNegativeOne
=== RUN   TestAccAWSLambdaEventSourceMapping_Kinesis_BisectBatch
=== PAUSE TestAccAWSLambdaEventSourceMapping_Kinesis_BisectBatch
=== RUN   TestAccAWSLambdaEventSourceMapping_Kinesis_DestinationConfig
=== PAUSE TestAccAWSLambdaEventSourceMapping_Kinesis_DestinationConfig
=== RUN   TestAccAWSLambdaEventSourceMapping_MSK
=== PAUSE TestAccAWSLambdaEventSourceMapping_MSK
=== RUN   TestAccAWSLambdaEventSourceMapping_SelfManagedKafka
=== PAUSE TestAccAWSLambdaEventSourceMapping_SelfManagedKafka
=== CONT  TestAccAWSLambdaEventSourceMapping_Kinesis_basic
=== CONT  TestAccAWSLambdaEventSourceMapping_Kinesis_MaximumRetryAttemptsZero
=== CONT  TestAccAWSLambdaEventSourceMapping_Kinesis_DestinationConfig
=== CONT  TestAccAWSLambdaEventSourceMapping_Kinesis_MaximumRetryAttempts
=== CONT  TestAccAWSLambdaEventSourceMapping_Kinesis_ParallelizationFactor
=== CONT  TestAccAWSLambdaEventSourceMapping_Kinesis_BatchWindow
=== CONT  TestAccAWSLambdaEventSourceMapping_Kinesis_StartingPositionTimestamp
=== CONT  TestAccAWSLambdaEventSourceMapping_Kinesis_BisectBatch
=== CONT  TestAccAWSLambdaEventSourceMapping_Kinesis_MaximumRecordAgeInSecondsNegativeOne
=== CONT  TestAccAWSLambdaEventSourceMapping_disappears
=== CONT  TestAccAWSLambdaEventSourceMapping_Kinesis_MaximumRecordAgeInSeconds
=== CONT  TestAccAWSLambdaEventSourceMapping_Kinesis_MaximumRetryAttemptsNegativeOne
=== CONT  TestAccAWSLambdaEventSourceMapping_SQS_basic
=== CONT  TestAccAWSLambdaEventSourceMapping_SelfManagedKafka
=== CONT  TestAccAWSLambdaEventSourceMapping_MSK
=== CONT  TestAccAWSLambdaEventSourceMapping_SQS_changesInEnabledAreDetected
=== CONT  TestAccAWSLambdaEventSourceMapping_SQS_BatchWindow
=== CONT  TestAccAWSLambdaEventSourceMapping_DynamoDB_basic
--- PASS: TestAccAWSLambdaEventSourceMapping_Kinesis_StartingPositionTimestamp (70.50s)
--- PASS: TestAccAWSLambdaEventSourceMapping_Kinesis_MaximumRetryAttempts (84.91s)
--- PASS: TestAccAWSLambdaEventSourceMapping_Kinesis_BatchWindow (86.73s)
--- PASS: TestAccAWSLambdaEventSourceMapping_Kinesis_BisectBatch (101.49s)
--- PASS: TestAccAWSLambdaEventSourceMapping_Kinesis_DestinationConfig (109.31s)
--- PASS: TestAccAWSLambdaEventSourceMapping_SQS_changesInEnabledAreDetected (114.31s)
--- PASS: TestAccAWSLambdaEventSourceMapping_DynamoDB_basic (116.90s)
--- PASS: TestAccAWSLambdaEventSourceMapping_Kinesis_MaximumRetryAttemptsNegativeOne (118.53s)
--- PASS: TestAccAWSLambdaEventSourceMapping_Kinesis_MaximumRecordAgeInSecondsNegativeOne (120.56s)
--- PASS: TestAccAWSLambdaEventSourceMapping_Kinesis_MaximumRecordAgeInSeconds (131.24s)
--- PASS: TestAccAWSLambdaEventSourceMapping_Kinesis_MaximumRetryAttemptsZero (131.27s)
--- PASS: TestAccAWSLambdaEventSourceMapping_SQS_BatchWindow (133.67s)
--- PASS: TestAccAWSLambdaEventSourceMapping_Kinesis_ParallelizationFactor (148.18s)
--- PASS: TestAccAWSLambdaEventSourceMapping_disappears (157.83s)
--- PASS: TestAccAWSLambdaEventSourceMapping_Kinesis_basic (175.54s)
--- PASS: TestAccAWSLambdaEventSourceMapping_SQS_basic (220.19s)
--- PASS: TestAccAWSLambdaEventSourceMapping_SelfManagedKafka (391.35s)
--- PASS: TestAccAWSLambdaEventSourceMapping_MSK (1083.75s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	1085.614s

aws/resource_aws_lambda_event_source_mapping.go

aws/resource_aws_lambda_event_source_mapping_test.go

github-actions

Welcome @delbaeth 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

aws/resource_aws_lambda_event_source_mapping.go

delbaeth · 2021-05-19T23:08:43Z

Anything else I should modify before opening this for review?

ewbankkit · 2021-05-20T12:39:52Z

@delbaeth This is looking great.
The only comment I have for now is to move the new flatten and expand functions from structure.go into resource_aws_lambda_event_source_mapping.go (we want to avoid adding new code to that file).

…ent_source_mapping.

…. Add some documentation updates.

…ource_mapping.go from structure.go. Add RequiredWith schema constraing to self_managed_event_source and source_access_configuration.

…t_source and source_acccess_configuration must be set together.

…n' to TypeSet and add DiffSuppressFunc for 'self_managed_event_source.endpoints.KAFKA_BOOTSTRAP_SERVERS'.

…ion errors only (hashicorp#14042).

…rgument. Acceptance test output: % make testacc TEST=./aws TESTARGS='-run=TestAccAWSLambdaEventSourceMapping_Kinesis_TumblingWindowInSeconds' ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSLambdaEventSourceMapping_Kinesis_TumblingWindowInSeconds -timeout 180m === RUN TestAccAWSLambdaEventSourceMapping_Kinesis_TumblingWindowInSeconds === PAUSE TestAccAWSLambdaEventSourceMapping_Kinesis_TumblingWindowInSeconds === CONT TestAccAWSLambdaEventSourceMapping_Kinesis_TumblingWindowInSeconds --- PASS: TestAccAWSLambdaEventSourceMapping_Kinesis_TumblingWindowInSeconds (71.47s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 74.769s

…ment. Acceptance test output: % make testacc TEST=./aws TESTARGS='-run=TestAccAWSLambdaEventSourceMapping_Kinesis_basic\|TestAccAWSLambdaEventSourceMapping_DynamoDB_FunctionResponseTypes\|TestAccAWSLambdaEventSourceMapping_DynamoDB_basic' ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSLambdaEventSourceMapping_Kinesis_basic\|TestAccAWSLambdaEventSourceMapping_DynamoDB_FunctionResponseTypes\|TestAccAWSLambdaEventSourceMapping_DynamoDB_basic -timeout 180m === RUN TestAccAWSLambdaEventSourceMapping_Kinesis_basic === PAUSE TestAccAWSLambdaEventSourceMapping_Kinesis_basic === RUN TestAccAWSLambdaEventSourceMapping_DynamoDB_basic === PAUSE TestAccAWSLambdaEventSourceMapping_DynamoDB_basic === RUN TestAccAWSLambdaEventSourceMapping_DynamoDB_FunctionResponseTypes === PAUSE TestAccAWSLambdaEventSourceMapping_DynamoDB_FunctionResponseTypes === CONT TestAccAWSLambdaEventSourceMapping_Kinesis_basic === CONT TestAccAWSLambdaEventSourceMapping_DynamoDB_FunctionResponseTypes === CONT TestAccAWSLambdaEventSourceMapping_DynamoDB_basic --- PASS: TestAccAWSLambdaEventSourceMapping_DynamoDB_FunctionResponseTypes (70.67s) --- PASS: TestAccAWSLambdaEventSourceMapping_DynamoDB_basic (76.45s) --- PASS: TestAccAWSLambdaEventSourceMapping_Kinesis_basic (89.09s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 93.336s

delbaeth · 2021-05-27T21:10:25Z

Anything on this waiting on me? I understand if it is just waiting for someone to get time to look at it but I wouldn't want it to be blocked waiting for me.

ewbankkit · 2021-06-01T15:31:23Z

@delbaeth No, everything is great from your side.
I added some additional commits to address some other new features in this resource.

…ination_config'.

ewbankkit

LGTM 🚀.

Commercial

% make testacc TEST=./aws TESTARGS='-run=TestAccAWSLambdaEventSourceMapping_'                          
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSLambdaEventSourceMapping_ -timeout 180m
=== RUN   TestAccAWSLambdaEventSourceMapping_Kinesis_basic
=== PAUSE TestAccAWSLambdaEventSourceMapping_Kinesis_basic
=== RUN   TestAccAWSLambdaEventSourceMapping_SQS_basic
=== PAUSE TestAccAWSLambdaEventSourceMapping_SQS_basic
=== RUN   TestAccAWSLambdaEventSourceMapping_DynamoDB_basic
=== PAUSE TestAccAWSLambdaEventSourceMapping_DynamoDB_basic
=== RUN   TestAccAWSLambdaEventSourceMapping_DynamoDB_FunctionResponseTypes
=== PAUSE TestAccAWSLambdaEventSourceMapping_DynamoDB_FunctionResponseTypes
=== RUN   TestAccAWSLambdaEventSourceMapping_SQS_BatchWindow
=== PAUSE TestAccAWSLambdaEventSourceMapping_SQS_BatchWindow
=== RUN   TestAccAWSLambdaEventSourceMapping_disappears
=== PAUSE TestAccAWSLambdaEventSourceMapping_disappears
=== RUN   TestAccAWSLambdaEventSourceMapping_SQS_changesInEnabledAreDetected
=== PAUSE TestAccAWSLambdaEventSourceMapping_SQS_changesInEnabledAreDetected
=== RUN   TestAccAWSLambdaEventSourceMapping_Kinesis_StartingPositionTimestamp
=== PAUSE TestAccAWSLambdaEventSourceMapping_Kinesis_StartingPositionTimestamp
=== RUN   TestAccAWSLambdaEventSourceMapping_Kinesis_BatchWindow
=== PAUSE TestAccAWSLambdaEventSourceMapping_Kinesis_BatchWindow
=== RUN   TestAccAWSLambdaEventSourceMapping_Kinesis_ParallelizationFactor
=== PAUSE TestAccAWSLambdaEventSourceMapping_Kinesis_ParallelizationFactor
=== RUN   TestAccAWSLambdaEventSourceMapping_Kinesis_TumblingWindowInSeconds
=== PAUSE TestAccAWSLambdaEventSourceMapping_Kinesis_TumblingWindowInSeconds
=== RUN   TestAccAWSLambdaEventSourceMapping_Kinesis_MaximumRetryAttempts
=== PAUSE TestAccAWSLambdaEventSourceMapping_Kinesis_MaximumRetryAttempts
=== RUN   TestAccAWSLambdaEventSourceMapping_Kinesis_MaximumRetryAttemptsZero
=== PAUSE TestAccAWSLambdaEventSourceMapping_Kinesis_MaximumRetryAttemptsZero
=== RUN   TestAccAWSLambdaEventSourceMapping_Kinesis_MaximumRetryAttemptsNegativeOne
=== PAUSE TestAccAWSLambdaEventSourceMapping_Kinesis_MaximumRetryAttemptsNegativeOne
=== RUN   TestAccAWSLambdaEventSourceMapping_Kinesis_MaximumRecordAgeInSeconds
=== PAUSE TestAccAWSLambdaEventSourceMapping_Kinesis_MaximumRecordAgeInSeconds
=== RUN   TestAccAWSLambdaEventSourceMapping_Kinesis_MaximumRecordAgeInSecondsNegativeOne
=== PAUSE TestAccAWSLambdaEventSourceMapping_Kinesis_MaximumRecordAgeInSecondsNegativeOne
=== RUN   TestAccAWSLambdaEventSourceMapping_Kinesis_BisectBatch
=== PAUSE TestAccAWSLambdaEventSourceMapping_Kinesis_BisectBatch
=== RUN   TestAccAWSLambdaEventSourceMapping_Kinesis_DestinationConfig
=== PAUSE TestAccAWSLambdaEventSourceMapping_Kinesis_DestinationConfig
=== RUN   TestAccAWSLambdaEventSourceMapping_MSK
=== PAUSE TestAccAWSLambdaEventSourceMapping_MSK
=== RUN   TestAccAWSLambdaEventSourceMapping_SelfManagedKafka
=== PAUSE TestAccAWSLambdaEventSourceMapping_SelfManagedKafka
=== RUN   TestAccAWSLambdaEventSourceMapping_ActiveMQ
=== PAUSE TestAccAWSLambdaEventSourceMapping_ActiveMQ
=== CONT  TestAccAWSLambdaEventSourceMapping_Kinesis_basic
=== CONT  TestAccAWSLambdaEventSourceMapping_Kinesis_MaximumRetryAttempts
=== CONT  TestAccAWSLambdaEventSourceMapping_Kinesis_TumblingWindowInSeconds
=== CONT  TestAccAWSLambdaEventSourceMapping_DynamoDB_basic
=== CONT  TestAccAWSLambdaEventSourceMapping_SQS_changesInEnabledAreDetected
=== CONT  TestAccAWSLambdaEventSourceMapping_Kinesis_BisectBatch
=== CONT  TestAccAWSLambdaEventSourceMapping_Kinesis_MaximumRecordAgeInSecondsNegativeOne
=== CONT  TestAccAWSLambdaEventSourceMapping_Kinesis_MaximumRecordAgeInSeconds
=== CONT  TestAccAWSLambdaEventSourceMapping_Kinesis_MaximumRetryAttemptsNegativeOne
=== CONT  TestAccAWSLambdaEventSourceMapping_Kinesis_DestinationConfig
=== CONT  TestAccAWSLambdaEventSourceMapping_Kinesis_MaximumRetryAttemptsZero
=== CONT  TestAccAWSLambdaEventSourceMapping_ActiveMQ
=== CONT  TestAccAWSLambdaEventSourceMapping_SelfManagedKafka
=== CONT  TestAccAWSLambdaEventSourceMapping_Kinesis_ParallelizationFactor
=== CONT  TestAccAWSLambdaEventSourceMapping_MSK
=== CONT  TestAccAWSLambdaEventSourceMapping_DynamoDB_FunctionResponseTypes
=== CONT  TestAccAWSLambdaEventSourceMapping_Kinesis_BatchWindow
=== CONT  TestAccAWSLambdaEventSourceMapping_Kinesis_StartingPositionTimestamp
=== CONT  TestAccAWSLambdaEventSourceMapping_disappears
=== CONT  TestAccAWSLambdaEventSourceMapping_SQS_basic
--- PASS: TestAccAWSLambdaEventSourceMapping_SQS_changesInEnabledAreDetected (93.20s)
=== CONT  TestAccAWSLambdaEventSourceMapping_SQS_BatchWindow
--- PASS: TestAccAWSLambdaEventSourceMapping_Kinesis_TumblingWindowInSeconds (96.02s)
--- PASS: TestAccAWSLambdaEventSourceMapping_Kinesis_BisectBatch (96.89s)
--- PASS: TestAccAWSLambdaEventSourceMapping_DynamoDB_FunctionResponseTypes (105.36s)
--- PASS: TestAccAWSLambdaEventSourceMapping_Kinesis_BatchWindow (107.82s)
--- PASS: TestAccAWSLambdaEventSourceMapping_disappears (117.07s)
--- PASS: TestAccAWSLambdaEventSourceMapping_Kinesis_MaximumRecordAgeInSecondsNegativeOne (120.79s)
--- PASS: TestAccAWSLambdaEventSourceMapping_Kinesis_MaximumRetryAttemptsZero (128.37s)
--- PASS: TestAccAWSLambdaEventSourceMapping_Kinesis_MaximumRecordAgeInSeconds (128.51s)
--- PASS: TestAccAWSLambdaEventSourceMapping_DynamoDB_basic (133.70s)
--- PASS: TestAccAWSLambdaEventSourceMapping_Kinesis_StartingPositionTimestamp (136.19s)
--- PASS: TestAccAWSLambdaEventSourceMapping_Kinesis_DestinationConfig (137.43s)
--- PASS: TestAccAWSLambdaEventSourceMapping_Kinesis_ParallelizationFactor (156.26s)
--- PASS: TestAccAWSLambdaEventSourceMapping_Kinesis_MaximumRetryAttemptsNegativeOne (175.02s)
--- PASS: TestAccAWSLambdaEventSourceMapping_Kinesis_MaximumRetryAttempts (183.74s)
--- PASS: TestAccAWSLambdaEventSourceMapping_SelfManagedKafka (185.37s)
--- PASS: TestAccAWSLambdaEventSourceMapping_Kinesis_basic (189.29s)
--- PASS: TestAccAWSLambdaEventSourceMapping_SQS_BatchWindow (111.32s)
--- PASS: TestAccAWSLambdaEventSourceMapping_SQS_basic (229.18s)
--- PASS: TestAccAWSLambdaEventSourceMapping_ActiveMQ (1300.75s)
--- PASS: TestAccAWSLambdaEventSourceMapping_MSK (2011.24s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	2014.715s

GovCloud

% make testacc TEST=./aws TESTARGS='-run=TestAccAWSLambdaEventSourceMapping_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSLambdaEventSourceMapping_ -timeout 180m
=== RUN   TestAccAWSLambdaEventSourceMapping_Kinesis_basic
=== PAUSE TestAccAWSLambdaEventSourceMapping_Kinesis_basic
=== RUN   TestAccAWSLambdaEventSourceMapping_SQS_basic
=== PAUSE TestAccAWSLambdaEventSourceMapping_SQS_basic
=== RUN   TestAccAWSLambdaEventSourceMapping_DynamoDB_basic
=== PAUSE TestAccAWSLambdaEventSourceMapping_DynamoDB_basic
=== RUN   TestAccAWSLambdaEventSourceMapping_DynamoDB_FunctionResponseTypes
=== PAUSE TestAccAWSLambdaEventSourceMapping_DynamoDB_FunctionResponseTypes
=== RUN   TestAccAWSLambdaEventSourceMapping_SQS_BatchWindow
=== PAUSE TestAccAWSLambdaEventSourceMapping_SQS_BatchWindow
=== RUN   TestAccAWSLambdaEventSourceMapping_disappears
=== PAUSE TestAccAWSLambdaEventSourceMapping_disappears
=== RUN   TestAccAWSLambdaEventSourceMapping_SQS_changesInEnabledAreDetected
=== PAUSE TestAccAWSLambdaEventSourceMapping_SQS_changesInEnabledAreDetected
=== RUN   TestAccAWSLambdaEventSourceMapping_Kinesis_StartingPositionTimestamp
=== PAUSE TestAccAWSLambdaEventSourceMapping_Kinesis_StartingPositionTimestamp
=== RUN   TestAccAWSLambdaEventSourceMapping_Kinesis_BatchWindow
=== PAUSE TestAccAWSLambdaEventSourceMapping_Kinesis_BatchWindow
=== RUN   TestAccAWSLambdaEventSourceMapping_Kinesis_ParallelizationFactor
=== PAUSE TestAccAWSLambdaEventSourceMapping_Kinesis_ParallelizationFactor
=== RUN   TestAccAWSLambdaEventSourceMapping_Kinesis_TumblingWindowInSeconds
=== PAUSE TestAccAWSLambdaEventSourceMapping_Kinesis_TumblingWindowInSeconds
=== RUN   TestAccAWSLambdaEventSourceMapping_Kinesis_MaximumRetryAttempts
=== PAUSE TestAccAWSLambdaEventSourceMapping_Kinesis_MaximumRetryAttempts
=== RUN   TestAccAWSLambdaEventSourceMapping_Kinesis_MaximumRetryAttemptsZero
=== PAUSE TestAccAWSLambdaEventSourceMapping_Kinesis_MaximumRetryAttemptsZero
=== RUN   TestAccAWSLambdaEventSourceMapping_Kinesis_MaximumRetryAttemptsNegativeOne
=== PAUSE TestAccAWSLambdaEventSourceMapping_Kinesis_MaximumRetryAttemptsNegativeOne
=== RUN   TestAccAWSLambdaEventSourceMapping_Kinesis_MaximumRecordAgeInSeconds
=== PAUSE TestAccAWSLambdaEventSourceMapping_Kinesis_MaximumRecordAgeInSeconds
=== RUN   TestAccAWSLambdaEventSourceMapping_Kinesis_MaximumRecordAgeInSecondsNegativeOne
=== PAUSE TestAccAWSLambdaEventSourceMapping_Kinesis_MaximumRecordAgeInSecondsNegativeOne
=== RUN   TestAccAWSLambdaEventSourceMapping_Kinesis_BisectBatch
=== PAUSE TestAccAWSLambdaEventSourceMapping_Kinesis_BisectBatch
=== RUN   TestAccAWSLambdaEventSourceMapping_Kinesis_DestinationConfig
=== PAUSE TestAccAWSLambdaEventSourceMapping_Kinesis_DestinationConfig
=== RUN   TestAccAWSLambdaEventSourceMapping_MSK
=== PAUSE TestAccAWSLambdaEventSourceMapping_MSK
=== RUN   TestAccAWSLambdaEventSourceMapping_SelfManagedKafka
=== PAUSE TestAccAWSLambdaEventSourceMapping_SelfManagedKafka
=== RUN   TestAccAWSLambdaEventSourceMapping_ActiveMQ
=== PAUSE TestAccAWSLambdaEventSourceMapping_ActiveMQ
=== CONT  TestAccAWSLambdaEventSourceMapping_Kinesis_basic
=== CONT  TestAccAWSLambdaEventSourceMapping_Kinesis_MaximumRetryAttemptsNegativeOne
=== CONT  TestAccAWSLambdaEventSourceMapping_SelfManagedKafka
=== CONT  TestAccAWSLambdaEventSourceMapping_disappears
=== CONT  TestAccAWSLambdaEventSourceMapping_Kinesis_BatchWindow
=== CONT  TestAccAWSLambdaEventSourceMapping_SQS_changesInEnabledAreDetected
=== CONT  TestAccAWSLambdaEventSourceMapping_MSK
=== CONT  TestAccAWSLambdaEventSourceMapping_ActiveMQ
=== CONT  TestAccAWSLambdaEventSourceMapping_Kinesis_DestinationConfig
=== CONT  TestAccAWSLambdaEventSourceMapping_Kinesis_BisectBatch
=== CONT  TestAccAWSLambdaEventSourceMapping_Kinesis_MaximumRecordAgeInSecondsNegativeOne
=== CONT  TestAccAWSLambdaEventSourceMapping_Kinesis_MaximumRecordAgeInSeconds
=== CONT  TestAccAWSLambdaEventSourceMapping_Kinesis_StartingPositionTimestamp
=== CONT  TestAccAWSLambdaEventSourceMapping_Kinesis_ParallelizationFactor
=== CONT  TestAccAWSLambdaEventSourceMapping_SQS_BatchWindow
=== CONT  TestAccAWSLambdaEventSourceMapping_Kinesis_MaximumRetryAttemptsZero
=== CONT  TestAccAWSLambdaEventSourceMapping_Kinesis_TumblingWindowInSeconds
=== CONT  TestAccAWSLambdaEventSourceMapping_DynamoDB_basic
=== CONT  TestAccAWSLambdaEventSourceMapping_DynamoDB_FunctionResponseTypes
=== CONT  TestAccAWSLambdaEventSourceMapping_Kinesis_MaximumRetryAttempts
=== CONT  TestAccAWSLambdaEventSourceMapping_ActiveMQ
    provider_test.go:734: skipping tests; partition aws-us-gov does not support mq service
--- SKIP: TestAccAWSLambdaEventSourceMapping_ActiveMQ (1.85s)
=== CONT  TestAccAWSLambdaEventSourceMapping_SQS_basic
--- PASS: TestAccAWSLambdaEventSourceMapping_SQS_BatchWindow (67.60s)
--- PASS: TestAccAWSLambdaEventSourceMapping_SQS_changesInEnabledAreDetected (95.02s)
--- PASS: TestAccAWSLambdaEventSourceMapping_Kinesis_MaximumRecordAgeInSecondsNegativeOne (95.93s)
--- PASS: TestAccAWSLambdaEventSourceMapping_Kinesis_StartingPositionTimestamp (97.94s)
=== CONT  TestAccAWSLambdaEventSourceMapping_SelfManagedKafka
    provider_test.go:1103: skipping test for aws-us-gov/us-gov-west-1: Error running apply: exit status 1
        2021/06/01 12:01:42 [DEBUG] Using modified User-Agent: Terraform/0.12.31 HashiCorp-terraform-exec/0.13.3
        
        Error: error creating Lambda Event Source Mapping (Self-Managed Apache Kafka): InvalidParameterValueException: Unsupported source arn : null
        {
          RespMetadata: {
            StatusCode: 400,
            RequestID: "97da7f44-b272-445b-aeea-f80fc9f5a82f"
          },
          Message_: "Unsupported source arn : null",
          Type: "User"
        }
        
          on terraform_plugin_test.tf line 100, in resource "aws_lambda_event_source_mapping" "test":
         100: resource "aws_lambda_event_source_mapping" "test" {
        
        
--- SKIP: TestAccAWSLambdaEventSourceMapping_SelfManagedKafka (114.89s)
--- PASS: TestAccAWSLambdaEventSourceMapping_Kinesis_DestinationConfig (124.12s)
--- PASS: TestAccAWSLambdaEventSourceMapping_Kinesis_MaximumRetryAttemptsZero (127.48s)
--- PASS: TestAccAWSLambdaEventSourceMapping_Kinesis_BatchWindow (129.25s)
--- PASS: TestAccAWSLambdaEventSourceMapping_Kinesis_ParallelizationFactor (136.89s)
--- PASS: TestAccAWSLambdaEventSourceMapping_Kinesis_MaximumRetryAttempts (150.24s)
--- PASS: TestAccAWSLambdaEventSourceMapping_DynamoDB_basic (152.62s)
--- PASS: TestAccAWSLambdaEventSourceMapping_Kinesis_MaximumRecordAgeInSeconds (163.46s)
--- PASS: TestAccAWSLambdaEventSourceMapping_Kinesis_MaximumRetryAttemptsNegativeOne (186.47s)
--- PASS: TestAccAWSLambdaEventSourceMapping_Kinesis_BisectBatch (188.61s)
--- PASS: TestAccAWSLambdaEventSourceMapping_DynamoDB_FunctionResponseTypes (191.33s)
--- PASS: TestAccAWSLambdaEventSourceMapping_Kinesis_basic (195.31s)
--- PASS: TestAccAWSLambdaEventSourceMapping_Kinesis_TumblingWindowInSeconds (200.92s)
--- PASS: TestAccAWSLambdaEventSourceMapping_disappears (204.50s)
--- PASS: TestAccAWSLambdaEventSourceMapping_SQS_basic (207.21s)
=== CONT  TestAccAWSLambdaEventSourceMapping_MSK
    provider_test.go:1103: skipping test for aws-us-gov/us-gov-west-1: Error running apply: exit status 1
        2021/06/01 12:01:44 [DEBUG] Using modified User-Agent: Terraform/0.12.31 HashiCorp-terraform-exec/0.13.3
        
        Error: error creating Lambda Event Source Mapping (arn:aws-us-gov:kafka:us-gov-west-1:357342307427:cluster/tf-acc-test-6080387929156384694/a3bfd034-c62a-445c-b83e-69ccde4b4d12-3): InvalidParameterValueException: Unsupported source arn : arn:aws-us-gov:kafka:us-gov-west-1:357342307427:cluster/tf-acc-test-6080387929156384694/a3bfd034-c62a-445c-b83e-69ccde4b4d12-3
        {
          RespMetadata: {
            StatusCode: 400,
            RequestID: "bad9817d-d774-44e2-ac06-d6a0fa834949"
          },
          Message_: "Unsupported source arn : arn:aws-us-gov:kafka:us-gov-west-1:357342307427:cluster/tf-acc-test-6080387929156384694/a3bfd034-c62a-445c-b83e-69ccde4b4d12-3",
          Type: "User"
        }
        
          on terraform_plugin_test.tf line 113, in resource "aws_lambda_event_source_mapping" "test":
         113: resource "aws_lambda_event_source_mapping" "test" {
        
        
--- SKIP: TestAccAWSLambdaEventSourceMapping_MSK (1398.58s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	1402.177s

ghost · 2021-06-01T17:42:07Z

This has been released in version 3.43.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

delbaeth · 2021-06-01T17:56:32Z

@ewbankkit Thanks for all of your help with this.

github-actions · 2021-07-02T02:08:45Z

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

ghost added size/XL Managed by automation to categorize the size of a PR. service/lambda Issues and PRs that pertain to the lambda service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels May 18, 2021

delbaeth commented May 18, 2021

View reviewed changes

aws/resource_aws_lambda_event_source_mapping.go Outdated Show resolved Hide resolved

delbaeth commented May 18, 2021

View reviewed changes

aws/resource_aws_lambda_event_source_mapping_test.go Outdated Show resolved Hide resolved

github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label May 18, 2021

github-actions bot reviewed May 18, 2021

View reviewed changes

ghost added the documentation Introduces or discusses updates to documentation. label May 19, 2021

delbaeth commented May 19, 2021

View reviewed changes

aws/resource_aws_lambda_event_source_mapping.go Outdated Show resolved Hide resolved

ewbankkit added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels May 20, 2021

delbaeth marked this pull request as ready for review May 20, 2021 18:01

delbaeth requested a review from a team as a code owner May 20, 2021 18:01

ewbankkit self-assigned this May 22, 2021

delbaeth and others added 13 commits May 26, 2021 17:03

Initial implementation of self_managed_event_source for aws_lambda_ev…

f69c0d7

…ent_source_mapping.

Remove the import test for the moment.

baa30db

Add changelog entry for PR#19425

0926eee

Switch the self_managed_event_source endpoints to a map[string]string…

37007a3

…. Add some documentation updates.

Add ExactlyOneOf to both event_source_arn and self_managed_event_source.

b6266c1

Move the expands and flatten functions to resource_aws_lambda_event_s…

bfe1b73

…ource_mapping.go from structure.go. Add RequiredWith schema constraing to self_managed_event_source and source_access_configuration.

Update document to indicate schema requirement that self_managed_even…

76d894a

…t_source and source_acccess_configuration must be set together.

Documentation formatting.

9f16299

Documentation word ordering.

4a42925

r/aws_lambda_event_source_mapping: Change 'source_access_configuratio…

31540bf

…n' to TypeSet and add DiffSuppressFunc for 'self_managed_event_source.endpoints.KAFKA_BOOTSTRAP_SERVERS'.

r/aws_lambda_event_source_mapping: Focus Create retry on IAM propagat…

64c6e05

…ion errors only (hashicorp#14042).

ewbankkit changed the title ~~Initial implementation of self_managed_event_source for aws_lambda_ev…~~ Initial implementation of self_managed_event_source for aws_lambda_event_source_mapping Jun 1, 2021

r/aws_lambda_event_source_mapping: Add queues argument.

c406bbf

ewbankkit force-pushed the f-aws_lambda_event_source_mapping-self_managed_event_source branch from d70b89a to c406bbf Compare June 1, 2021 15:27

ghost added size/XXL Managed by automation to categorize the size of a PR. and removed size/XL Managed by automation to categorize the size of a PR. labels Jun 1, 2021

ewbankkit added 4 commits June 1, 2021 11:36

Fix terrafmt errors.

7b9e30e

r/aws_lambda_event_source_mapping: Correctly handle deletion of 'dest…

89e5895

…ination_config'.

Fix awsproviderlint errors.

2e077d9

No MQ in GovCloud.

7c9c511

ewbankkit approved these changes Jun 1, 2021

View reviewed changes

ewbankkit merged commit 286552c into hashicorp:main Jun 1, 2021

github-actions bot added this to the v3.43.0 milestone Jun 1, 2021

github-actions bot locked as resolved and limited conversation to collaborators Jul 2, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Initial implementation of self_managed_event_source for aws_lambda_event_source_mapping #19425

Initial implementation of self_managed_event_source for aws_lambda_event_source_mapping #19425

delbaeth commented May 18, 2021 •

edited by ewbankkit

Loading

github-actions bot left a comment

delbaeth commented May 19, 2021

ewbankkit commented May 20, 2021

delbaeth commented May 27, 2021

ewbankkit commented Jun 1, 2021

ewbankkit left a comment

ghost commented Jun 1, 2021

delbaeth commented Jun 1, 2021

github-actions bot commented Jul 2, 2021

Initial implementation of self_managed_event_source for aws_lambda_event_source_mapping #19425

Initial implementation of self_managed_event_source for aws_lambda_event_source_mapping #19425

Conversation

delbaeth commented May 18, 2021 • edited by ewbankkit Loading

Community Note

github-actions bot left a comment

Choose a reason for hiding this comment

delbaeth commented May 19, 2021

ewbankkit commented May 20, 2021

delbaeth commented May 27, 2021

ewbankkit commented Jun 1, 2021

ewbankkit left a comment

Choose a reason for hiding this comment

Commercial

GovCloud

ghost commented Jun 1, 2021

delbaeth commented Jun 1, 2021

github-actions bot commented Jul 2, 2021

delbaeth commented May 18, 2021 •

edited by ewbankkit

Loading