Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

d/aws_mq_broker: logs.audit is TypeString (NullableBool) #19502

Merged
merged 2 commits into from
May 24, 2021

Conversation

ewbankkit
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #19494.

Output from acceptance testing:

Commercial

% make testacc TEST=./aws TESTARGS='-run=TestAccDataSourceAWSMqBroker_'     
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccDataSourceAWSMqBroker_ -timeout 180m
=== RUN   TestAccDataSourceAWSMqBroker_basic
=== PAUSE TestAccDataSourceAWSMqBroker_basic
=== CONT  TestAccDataSourceAWSMqBroker_basic
--- PASS: TestAccDataSourceAWSMqBroker_basic (1180.32s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	1183.527s

GovCloud

% make testacc TEST=./aws TESTARGS='-run=TestAccDataSourceAWSMqBroker_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccDataSourceAWSMqBroker_ -timeout 180m
=== RUN   TestAccDataSourceAWSMqBroker_basic
=== PAUSE TestAccDataSourceAWSMqBroker_basic
=== CONT  TestAccDataSourceAWSMqBroker_basic
    provider_test.go:734: skipping tests; partition aws-us-gov does not support mq service
--- SKIP: TestAccDataSourceAWSMqBroker_basic (1.36s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	4.399s

@ewbankkit ewbankkit requested a review from a team as a code owner May 24, 2021 17:14
@ghost ghost added the size/XS Managed by automation to categorize the size of a PR. label May 24, 2021
@github-actions github-actions bot added the service/mq Issues and PRs that pertain to the mq service. label May 24, 2021
@anGie44 anGie44 self-assigned this May 24, 2021
@anGie44 anGie44 added the bug Addresses a defect in current functionality. label May 24, 2021
Copy link
Contributor

@anGie44 anGie44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Comment on lines -165 to -173
Optional: true,
MaxItems: 1,
// Ignore missing configuration block
DiffSuppressFunc: func(k, old, new string, d *schema.ResourceData) bool {
if old == "1" && new == "0" {
return true
}
return false
},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@ewbankkit ewbankkit merged commit 3268631 into main May 24, 2021
@ewbankkit ewbankkit deleted the b-data.aws_mq_broker-logs.audit-nullable-bool branch May 24, 2021 20:01
@github-actions github-actions bot added this to the v3.43.0 milestone May 24, 2021
github-actions bot pushed a commit that referenced this pull request May 24, 2021
@ghost
Copy link

ghost commented Jun 1, 2021

This has been released in version 3.43.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@github-actions
Copy link

github-actions bot commented Jul 2, 2021

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/mq Issues and PRs that pertain to the mq service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
2 participants