Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new aws_chime_voice_connector resource #19504

Merged
merged 7 commits into from
Aug 11, 2021
Merged

Add new aws_chime_voice_connector resource #19504

merged 7 commits into from
Aug 11, 2021

Conversation

aleks1001
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSChimeVoiceConnector_basic -timeout 180m
=== RUN   TestAccAWSChimeVoiceConnector_basic
=== PAUSE TestAccAWSChimeVoiceConnector_basic
=== CONT  TestAccAWSChimeVoiceConnector_basic
--- PASS: TestAccAWSChimeVoiceConnector_basic (17.85s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       20.496s
...

@aleks1001 aleks1001 requested a review from a team as a code owner May 24, 2021 19:59
@ghost ghost added the size/L Managed by automation to categorize the size of a PR. label May 24, 2021
@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/chime Issues and PRs that pertain to the chime service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels May 24, 2021
@aleks1001 aleks1001 requested a review from ewbankkit as a code owner May 24, 2021 20:07
@github-actions github-actions bot added service/autoscaling Issues and PRs that pertain to the autoscaling service. service/codebuild Issues and PRs that pertain to the codebuild service. service/ec2 Issues and PRs that pertain to the ec2 service. service/glue Issues and PRs that pertain to the glue service. service/route53resolver Issues and PRs that pertain to the route53resolver service. service/s3control Issues and PRs that pertain to the s3control service. service/securityhub Issues and PRs that pertain to the securityhub service. labels May 24, 2021
@github-actions github-actions bot removed service/codebuild Issues and PRs that pertain to the codebuild service. service/glue Issues and PRs that pertain to the glue service. service/route53resolver Issues and PRs that pertain to the route53resolver service. service/ec2 Issues and PRs that pertain to the ec2 service. service/securityhub Issues and PRs that pertain to the securityhub service. service/s3control Issues and PRs that pertain to the s3control service. service/autoscaling Issues and PRs that pertain to the autoscaling service. labels May 24, 2021
@tylersmith34
Copy link
Contributor

@aleks1001 You have a merge conflict to fix.

bill-rich
bill-rich suggested changes Aug 3, 2021
View reviewed changes
Copy link
Contributor

@bill-rich bill-rich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just a few comments to get the resource in sync with other resources in the provider.

aws/resource_aws_chime_voice_connector.go Outdated Show resolved Hide resolved
aws/resource_aws_chime_voice_connector.go Show resolved Hide resolved
aws/resource_aws_chime_voice_connector.go Outdated Show resolved Hide resolved
aws/resource_aws_chime_voice_connector.go Show resolved Hide resolved
aws/resource_aws_chime_voice_connector_test.go Show resolved Hide resolved
@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. and removed size/L Managed by automation to categorize the size of a PR. labels Aug 4, 2021
aleks1001
aleks1001 commented Aug 5, 2021
View reviewed changes
Copy link
Contributor Author

@aleks1001 aleks1001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comments addressed

bill-rich
bill-rich approved these changes Aug 11, 2021
View reviewed changes
Copy link
Contributor

@bill-rich bill-rich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for addressing the comments!

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSChimeVoiceConnector_ -timeout 180m
=== RUN   TestAccAWSChimeVoiceConnector_basic
=== PAUSE TestAccAWSChimeVoiceConnector_basic
=== RUN   TestAccAWSChimeVoiceConnector_disappears
=== PAUSE TestAccAWSChimeVoiceConnector_disappears
=== RUN   TestAccAWSChimeVoiceConnector_update
=== PAUSE TestAccAWSChimeVoiceConnector_update
=== CONT  TestAccAWSChimeVoiceConnector_basic
=== CONT  TestAccAWSChimeVoiceConnector_update
=== CONT  TestAccAWSChimeVoiceConnector_disappears
--- PASS: TestAccAWSChimeVoiceConnector_disappears (21.15s)
--- PASS: TestAccAWSChimeVoiceConnector_basic (27.43s)
--- PASS: TestAccAWSChimeVoiceConnector_update (40.96s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	41.020s

@bill-rich bill-rich merged commit d6f9982 into hashicorp:main Aug 11, 2021
@github-actions github-actions bot added this to the v3.54.0 milestone Aug 11, 2021
@github-actions
Copy link

This functionality has been released in v3.54.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@ewbankkit ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label Aug 13, 2021
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bill-rich bill-rich bill-rich approved these changes

@ewbankkit ewbankkit Awaiting requested review from ewbankkit

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/chime Issues and PRs that pertain to the chime service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.54.0
Development

Successfully merging this pull request may close these issues.
4 participants
@aleks1001 @tylersmith34 @bill-rich @ewbankkit