Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/default_vpc_dhcp_options - add owner_id arg #19656

Merged
merged 3 commits into from
Jun 8, 2021

Conversation

DrFaust92
Copy link
Collaborator

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #19558

Output from acceptance testing:

$ make testacc TESTARGS='-run=estAccAWSDefaultVpcDhcpOptions_''
--- PASS: TestAccAWSDefaultVpcDhcpOptions_basic (35.35s)
--- PASS: TestAccAWSDefaultVpcDhcpOptions_owner (43.05s)

@DrFaust92 DrFaust92 requested a review from a team as a code owner June 3, 2021 21:27
@ghost ghost added size/M Managed by automation to categorize the size of a PR. labels Jun 3, 2021
@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. service/ec2 Issues and PRs that pertain to the ec2 service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Jun 3, 2021
@DrFaust92 DrFaust92 added the bug Addresses a defect in current functionality. label Jun 3, 2021
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

Commercial
% make testacc TEST=./aws TESTARGS='-run=TestAccAWSDefaultVpcDhcpOptions_' 
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSDefaultVpcDhcpOptions_ -timeout 180m
=== RUN   TestAccAWSDefaultVpcDhcpOptions_basic
=== PAUSE TestAccAWSDefaultVpcDhcpOptions_basic
=== RUN   TestAccAWSDefaultVpcDhcpOptions_owner
=== PAUSE TestAccAWSDefaultVpcDhcpOptions_owner
=== CONT  TestAccAWSDefaultVpcDhcpOptions_basic
=== CONT  TestAccAWSDefaultVpcDhcpOptions_owner
--- PASS: TestAccAWSDefaultVpcDhcpOptions_basic (10.57s)
--- PASS: TestAccAWSDefaultVpcDhcpOptions_owner (11.64s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	14.856s
GovCloud
% make testacc TEST=./aws TESTARGS='-run=TestAccAWSDefaultVpcDhcpOptions_'                            
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSDefaultVpcDhcpOptions_ -timeout 180m
=== RUN   TestAccAWSDefaultVpcDhcpOptions_basic
=== PAUSE TestAccAWSDefaultVpcDhcpOptions_basic
=== RUN   TestAccAWSDefaultVpcDhcpOptions_owner
=== PAUSE TestAccAWSDefaultVpcDhcpOptions_owner
=== CONT  TestAccAWSDefaultVpcDhcpOptions_basic
=== CONT  TestAccAWSDefaultVpcDhcpOptions_owner
--- PASS: TestAccAWSDefaultVpcDhcpOptions_basic (16.06s)
--- PASS: TestAccAWSDefaultVpcDhcpOptions_owner (17.96s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	21.286s

@ewbankkit ewbankkit merged commit 1624764 into hashicorp:main Jun 8, 2021
@github-actions github-actions bot added this to the v3.45.0 milestone Jun 8, 2021
@DrFaust92 DrFaust92 deleted the r/default_dhcp branch June 8, 2021 14:59
@github-actions
Copy link

This functionality has been released in v3.45.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. documentation Introduces or discusses updates to documentation. service/ec2 Issues and PRs that pertain to the ec2 service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aws_default_vpc_dhcp_options does not work when shared VPCs are present
2 participants