-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
r/ecs_task_definition - add support for fsx win fs #19670
Conversation
This reverts commit 2ff8db8b63107f398dae08ac74fd7aea705b8aee.
81934ab
to
d12fa5c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
Commercial
% make testacc TEST=./aws TESTARGS='-run=TestAccAWSEcsTaskDefinition_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSEcsTaskDefinition_ -timeout 180m
=== RUN TestAccAWSEcsTaskDefinition_basic
=== PAUSE TestAccAWSEcsTaskDefinition_basic
=== RUN TestAccAWSEcsTaskDefinition_withScratchVolume
=== PAUSE TestAccAWSEcsTaskDefinition_withScratchVolume
=== RUN TestAccAWSEcsTaskDefinition_withDockerVolume
=== PAUSE TestAccAWSEcsTaskDefinition_withDockerVolume
=== RUN TestAccAWSEcsTaskDefinition_withDockerVolumeMinimalConfig
=== PAUSE TestAccAWSEcsTaskDefinition_withDockerVolumeMinimalConfig
=== RUN TestAccAWSEcsTaskDefinition_withEFSVolumeMinimal
=== PAUSE TestAccAWSEcsTaskDefinition_withEFSVolumeMinimal
=== RUN TestAccAWSEcsTaskDefinition_withEFSVolume
=== PAUSE TestAccAWSEcsTaskDefinition_withEFSVolume
=== RUN TestAccAWSEcsTaskDefinition_withTransitEncryptionEFSVolume
=== PAUSE TestAccAWSEcsTaskDefinition_withTransitEncryptionEFSVolume
=== RUN TestAccAWSEcsTaskDefinition_withEFSAccessPoint
=== PAUSE TestAccAWSEcsTaskDefinition_withEFSAccessPoint
=== RUN TestAccAWSEcsTaskDefinition_withFsxWinFileSystem
=== PAUSE TestAccAWSEcsTaskDefinition_withFsxWinFileSystem
=== RUN TestAccAWSEcsTaskDefinition_withTaskScopedDockerVolume
=== PAUSE TestAccAWSEcsTaskDefinition_withTaskScopedDockerVolume
=== RUN TestAccAWSEcsTaskDefinition_withEcsService
=== PAUSE TestAccAWSEcsTaskDefinition_withEcsService
=== RUN TestAccAWSEcsTaskDefinition_withTaskRoleArn
=== PAUSE TestAccAWSEcsTaskDefinition_withTaskRoleArn
=== RUN TestAccAWSEcsTaskDefinition_withNetworkMode
=== PAUSE TestAccAWSEcsTaskDefinition_withNetworkMode
=== RUN TestAccAWSEcsTaskDefinition_withIPCMode
=== PAUSE TestAccAWSEcsTaskDefinition_withIPCMode
=== RUN TestAccAWSEcsTaskDefinition_withPidMode
=== PAUSE TestAccAWSEcsTaskDefinition_withPidMode
=== RUN TestAccAWSEcsTaskDefinition_constraint
=== PAUSE TestAccAWSEcsTaskDefinition_constraint
=== RUN TestAccAWSEcsTaskDefinition_changeVolumesForcesNewResource
=== PAUSE TestAccAWSEcsTaskDefinition_changeVolumesForcesNewResource
=== RUN TestAccAWSEcsTaskDefinition_arrays
=== PAUSE TestAccAWSEcsTaskDefinition_arrays
=== RUN TestAccAWSEcsTaskDefinition_Fargate
=== PAUSE TestAccAWSEcsTaskDefinition_Fargate
=== RUN TestAccAWSEcsTaskDefinition_ExecutionRole
=== PAUSE TestAccAWSEcsTaskDefinition_ExecutionRole
=== RUN TestAccAWSEcsTaskDefinition_disappears
=== PAUSE TestAccAWSEcsTaskDefinition_disappears
=== RUN TestAccAWSEcsTaskDefinition_Tags
=== PAUSE TestAccAWSEcsTaskDefinition_Tags
=== RUN TestAccAWSEcsTaskDefinition_ProxyConfiguration
=== PAUSE TestAccAWSEcsTaskDefinition_ProxyConfiguration
=== RUN TestAccAWSEcsTaskDefinition_inferenceAccelerator
=== PAUSE TestAccAWSEcsTaskDefinition_inferenceAccelerator
=== CONT TestAccAWSEcsTaskDefinition_basic
=== CONT TestAccAWSEcsTaskDefinition_withIPCMode
=== CONT TestAccAWSEcsTaskDefinition_ExecutionRole
=== CONT TestAccAWSEcsTaskDefinition_withEFSAccessPoint
=== CONT TestAccAWSEcsTaskDefinition_withTaskScopedDockerVolume
=== CONT TestAccAWSEcsTaskDefinition_withFsxWinFileSystem
=== CONT TestAccAWSEcsTaskDefinition_Fargate
=== CONT TestAccAWSEcsTaskDefinition_changeVolumesForcesNewResource
=== CONT TestAccAWSEcsTaskDefinition_constraint
=== CONT TestAccAWSEcsTaskDefinition_arrays
=== CONT TestAccAWSEcsTaskDefinition_withPidMode
=== CONT TestAccAWSEcsTaskDefinition_withEFSVolumeMinimal
=== CONT TestAccAWSEcsTaskDefinition_ProxyConfiguration
=== CONT TestAccAWSEcsTaskDefinition_withTransitEncryptionEFSVolume
=== CONT TestAccAWSEcsTaskDefinition_withEcsService
=== CONT TestAccAWSEcsTaskDefinition_withNetworkMode
=== CONT TestAccAWSEcsTaskDefinition_withEFSVolume
=== CONT TestAccAWSEcsTaskDefinition_inferenceAccelerator
=== CONT TestAccAWSEcsTaskDefinition_withTaskRoleArn
=== CONT TestAccAWSEcsTaskDefinition_Tags
--- PASS: TestAccAWSEcsTaskDefinition_withTaskScopedDockerVolume (52.87s)
=== CONT TestAccAWSEcsTaskDefinition_withScratchVolume
--- PASS: TestAccAWSEcsTaskDefinition_arrays (53.27s)
=== CONT TestAccAWSEcsTaskDefinition_withDockerVolumeMinimalConfig
--- PASS: TestAccAWSEcsTaskDefinition_inferenceAccelerator (55.70s)
=== CONT TestAccAWSEcsTaskDefinition_disappears
--- PASS: TestAccAWSEcsTaskDefinition_withTaskRoleArn (59.59s)
=== CONT TestAccAWSEcsTaskDefinition_withDockerVolume
--- PASS: TestAccAWSEcsTaskDefinition_withIPCMode (60.86s)
--- PASS: TestAccAWSEcsTaskDefinition_constraint (61.12s)
--- PASS: TestAccAWSEcsTaskDefinition_withPidMode (64.15s)
--- PASS: TestAccAWSEcsTaskDefinition_ExecutionRole (65.06s)
--- PASS: TestAccAWSEcsTaskDefinition_withNetworkMode (65.73s)
--- PASS: TestAccAWSEcsTaskDefinition_ProxyConfiguration (69.45s)
--- PASS: TestAccAWSEcsTaskDefinition_withTransitEncryptionEFSVolume (70.58s)
--- PASS: TestAccAWSEcsTaskDefinition_withEFSVolumeMinimal (73.25s)
--- PASS: TestAccAWSEcsTaskDefinition_withEFSVolume (73.75s)
--- PASS: TestAccAWSEcsTaskDefinition_withEFSAccessPoint (75.37s)
--- PASS: TestAccAWSEcsTaskDefinition_Fargate (76.75s)
--- PASS: TestAccAWSEcsTaskDefinition_changeVolumesForcesNewResource (82.88s)
--- PASS: TestAccAWSEcsTaskDefinition_basic (83.44s)
--- PASS: TestAccAWSEcsTaskDefinition_withDockerVolumeMinimalConfig (36.94s)
--- PASS: TestAccAWSEcsTaskDefinition_withScratchVolume (37.40s)
--- PASS: TestAccAWSEcsTaskDefinition_withDockerVolume (31.00s)
--- PASS: TestAccAWSEcsTaskDefinition_disappears (42.62s)
--- PASS: TestAccAWSEcsTaskDefinition_Tags (100.23s)
--- PASS: TestAccAWSEcsTaskDefinition_withEcsService (157.31s)
--- PASS: TestAccAWSEcsTaskDefinition_withFsxWinFileSystem (1420.86s)
PASS
ok github.com/terraform-providers/terraform-provider-aws/aws 1424.417s
GovCloud
% make testacc TEST=./aws TESTARGS='-run=TestAccAWSEcsTaskDefinition_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSEcsTaskDefinition_ -timeout 180m
=== RUN TestAccAWSEcsTaskDefinition_basic
=== PAUSE TestAccAWSEcsTaskDefinition_basic
=== RUN TestAccAWSEcsTaskDefinition_withScratchVolume
=== PAUSE TestAccAWSEcsTaskDefinition_withScratchVolume
=== RUN TestAccAWSEcsTaskDefinition_withDockerVolume
=== PAUSE TestAccAWSEcsTaskDefinition_withDockerVolume
=== RUN TestAccAWSEcsTaskDefinition_withDockerVolumeMinimalConfig
=== PAUSE TestAccAWSEcsTaskDefinition_withDockerVolumeMinimalConfig
=== RUN TestAccAWSEcsTaskDefinition_withEFSVolumeMinimal
=== PAUSE TestAccAWSEcsTaskDefinition_withEFSVolumeMinimal
=== RUN TestAccAWSEcsTaskDefinition_withEFSVolume
=== PAUSE TestAccAWSEcsTaskDefinition_withEFSVolume
=== RUN TestAccAWSEcsTaskDefinition_withTransitEncryptionEFSVolume
=== PAUSE TestAccAWSEcsTaskDefinition_withTransitEncryptionEFSVolume
=== RUN TestAccAWSEcsTaskDefinition_withEFSAccessPoint
=== PAUSE TestAccAWSEcsTaskDefinition_withEFSAccessPoint
=== RUN TestAccAWSEcsTaskDefinition_withFsxWinFileSystem
=== PAUSE TestAccAWSEcsTaskDefinition_withFsxWinFileSystem
=== RUN TestAccAWSEcsTaskDefinition_withTaskScopedDockerVolume
=== PAUSE TestAccAWSEcsTaskDefinition_withTaskScopedDockerVolume
=== RUN TestAccAWSEcsTaskDefinition_withEcsService
=== PAUSE TestAccAWSEcsTaskDefinition_withEcsService
=== RUN TestAccAWSEcsTaskDefinition_withTaskRoleArn
=== PAUSE TestAccAWSEcsTaskDefinition_withTaskRoleArn
=== RUN TestAccAWSEcsTaskDefinition_withNetworkMode
=== PAUSE TestAccAWSEcsTaskDefinition_withNetworkMode
=== RUN TestAccAWSEcsTaskDefinition_withIPCMode
=== PAUSE TestAccAWSEcsTaskDefinition_withIPCMode
=== RUN TestAccAWSEcsTaskDefinition_withPidMode
=== PAUSE TestAccAWSEcsTaskDefinition_withPidMode
=== RUN TestAccAWSEcsTaskDefinition_constraint
=== PAUSE TestAccAWSEcsTaskDefinition_constraint
=== RUN TestAccAWSEcsTaskDefinition_changeVolumesForcesNewResource
=== PAUSE TestAccAWSEcsTaskDefinition_changeVolumesForcesNewResource
=== RUN TestAccAWSEcsTaskDefinition_arrays
=== PAUSE TestAccAWSEcsTaskDefinition_arrays
=== RUN TestAccAWSEcsTaskDefinition_Fargate
=== PAUSE TestAccAWSEcsTaskDefinition_Fargate
=== RUN TestAccAWSEcsTaskDefinition_ExecutionRole
=== PAUSE TestAccAWSEcsTaskDefinition_ExecutionRole
=== RUN TestAccAWSEcsTaskDefinition_disappears
=== PAUSE TestAccAWSEcsTaskDefinition_disappears
=== RUN TestAccAWSEcsTaskDefinition_Tags
=== PAUSE TestAccAWSEcsTaskDefinition_Tags
=== RUN TestAccAWSEcsTaskDefinition_ProxyConfiguration
=== PAUSE TestAccAWSEcsTaskDefinition_ProxyConfiguration
=== RUN TestAccAWSEcsTaskDefinition_inferenceAccelerator
=== PAUSE TestAccAWSEcsTaskDefinition_inferenceAccelerator
=== CONT TestAccAWSEcsTaskDefinition_basic
=== CONT TestAccAWSEcsTaskDefinition_ExecutionRole
=== CONT TestAccAWSEcsTaskDefinition_inferenceAccelerator
=== CONT TestAccAWSEcsTaskDefinition_ProxyConfiguration
=== CONT TestAccAWSEcsTaskDefinition_Tags
=== CONT TestAccAWSEcsTaskDefinition_disappears
=== CONT TestAccAWSEcsTaskDefinition_withPidMode
=== CONT TestAccAWSEcsTaskDefinition_constraint
=== CONT TestAccAWSEcsTaskDefinition_Fargate
=== CONT TestAccAWSEcsTaskDefinition_withIPCMode
=== CONT TestAccAWSEcsTaskDefinition_withEFSAccessPoint
=== CONT TestAccAWSEcsTaskDefinition_withNetworkMode
=== CONT TestAccAWSEcsTaskDefinition_withTaskRoleArn
=== CONT TestAccAWSEcsTaskDefinition_withEcsService
=== CONT TestAccAWSEcsTaskDefinition_withTaskScopedDockerVolume
=== CONT TestAccAWSEcsTaskDefinition_arrays
=== CONT TestAccAWSEcsTaskDefinition_withEFSVolumeMinimal
=== CONT TestAccAWSEcsTaskDefinition_withTransitEncryptionEFSVolume
=== CONT TestAccAWSEcsTaskDefinition_withFsxWinFileSystem
=== CONT TestAccAWSEcsTaskDefinition_changeVolumesForcesNewResource
=== CONT TestAccAWSEcsTaskDefinition_inferenceAccelerator
provider_test.go:1103: skipping test for aws-us-gov/us-gov-west-1: Error running apply: exit status 1
2021/06/07 06:21:14 [DEBUG] Using modified User-Agent: Terraform/0.12.31 HashiCorp-terraform-exec/0.13.3
Error: ClientException: Unsupported field 'inferenceAccelerators'.
on terraform_plugin_test.tf line 2, in resource "aws_ecs_task_definition" "test":
2: resource "aws_ecs_task_definition" "test" {
--- SKIP: TestAccAWSEcsTaskDefinition_inferenceAccelerator (6.15s)
=== CONT TestAccAWSEcsTaskDefinition_withEFSVolume
--- PASS: TestAccAWSEcsTaskDefinition_arrays (65.16s)
=== CONT TestAccAWSEcsTaskDefinition_withDockerVolume
--- PASS: TestAccAWSEcsTaskDefinition_withTaskScopedDockerVolume (66.20s)
=== CONT TestAccAWSEcsTaskDefinition_withDockerVolumeMinimalConfig
--- PASS: TestAccAWSEcsTaskDefinition_constraint (68.34s)
=== CONT TestAccAWSEcsTaskDefinition_withScratchVolume
--- PASS: TestAccAWSEcsTaskDefinition_withTaskRoleArn (74.48s)
--- PASS: TestAccAWSEcsTaskDefinition_withIPCMode (76.45s)
--- PASS: TestAccAWSEcsTaskDefinition_withNetworkMode (77.07s)
--- PASS: TestAccAWSEcsTaskDefinition_withPidMode (77.25s)
--- PASS: TestAccAWSEcsTaskDefinition_ExecutionRole (77.42s)
--- PASS: TestAccAWSEcsTaskDefinition_ProxyConfiguration (78.51s)
--- PASS: TestAccAWSEcsTaskDefinition_withEFSVolumeMinimal (78.64s)
--- PASS: TestAccAWSEcsTaskDefinition_withTransitEncryptionEFSVolume (81.40s)
--- PASS: TestAccAWSEcsTaskDefinition_Fargate (82.39s)
--- PASS: TestAccAWSEcsTaskDefinition_withEFSAccessPoint (83.54s)
--- PASS: TestAccAWSEcsTaskDefinition_disappears (85.26s)
--- PASS: TestAccAWSEcsTaskDefinition_withEFSVolume (59.82s)
--- PASS: TestAccAWSEcsTaskDefinition_basic (91.24s)
--- PASS: TestAccAWSEcsTaskDefinition_changeVolumesForcesNewResource (91.29s)
--- PASS: TestAccAWSEcsTaskDefinition_withDockerVolume (29.29s)
--- PASS: TestAccAWSEcsTaskDefinition_withScratchVolume (27.24s)
--- PASS: TestAccAWSEcsTaskDefinition_withDockerVolumeMinimalConfig (29.51s)
--- PASS: TestAccAWSEcsTaskDefinition_Tags (106.55s)
--- PASS: TestAccAWSEcsTaskDefinition_withEcsService (131.01s)
=== RUN TestAccAWSEcsTaskDefinition_withFsxWinFileSystem
resource_aws_ecs_task_definition_test.go:369: Amazon FSx for Windows File Server volumes for ECS tasks are not supported in GovCloud partition
--- SKIP: TestAccAWSEcsTaskDefinition_withFsxWinFileSystem (0.00s)
PASS
ok github.com/terraform-providers/terraform-provider-aws/aws 1127.866s
@DrFaust92 Thanks for the contribution 🎉 👏. |
This functionality has been released in v3.45.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Community Note
Closes #19652
Output from acceptance testing: