resource,data_source/aws_servicequotas_service_quota: Handle embedded error in ServiceQuota struct

[gdavison]

Handles errors embedded errors in ServiceQuota struct instead of being returned as an API error code.

Closes #19719

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAwsServiceQuotasServiceQuotaDataSource\|TestAccAwsServiceQuotasServiceQuota'

--- SKIP: TestAccAwsServiceQuotasServiceQuota_Value_IncreaseOnCreate (0.00s)
--- SKIP: TestAccAwsServiceQuotasServiceQuota_Value_IncreaseOnUpdate (0.00s)
--- PASS: TestAccAwsServiceQuotasServiceQuotaDataSource_PermissionError_QuotaCode (5.28s)
--- PASS: TestAccAwsServiceQuotasServiceQuotaDataSource_PermissionError_QuotaName (5.52s)
--- PASS: TestAccAwsServiceQuotasServiceQuota_PermissionError (9.46s)
--- PASS: TestAccAwsServiceQuotasServiceQuotaDataSource_QuotaCode (16.47s)
--- PASS: TestAccAwsServiceQuotasServiceQuotaDataSource_QuotaName (16.54s)
--- PASS: TestAccAwsServiceQuotasServiceQuota_basic (18.61s)

[ewbankkit]

LGTM 🚀.

Commercial

% make testacc TEST=./aws TESTARGS='-run=TestAccAwsServiceQuotasServiceQuotaDataSource\|TestAccAwsServiceQuotasServiceQuota'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAwsServiceQuotasServiceQuotaDataSource\|TestAccAwsServiceQuotasServiceQuota -timeout 180m
=== RUN   TestAccAwsServiceQuotasServiceQuotaDataSource_QuotaCode
=== PAUSE TestAccAwsServiceQuotasServiceQuotaDataSource_QuotaCode
=== RUN   TestAccAwsServiceQuotasServiceQuotaDataSource_PermissionError_QuotaCode
=== PAUSE TestAccAwsServiceQuotasServiceQuotaDataSource_PermissionError_QuotaCode
=== RUN   TestAccAwsServiceQuotasServiceQuotaDataSource_QuotaName
=== PAUSE TestAccAwsServiceQuotasServiceQuotaDataSource_QuotaName
=== RUN   TestAccAwsServiceQuotasServiceQuotaDataSource_PermissionError_QuotaName
=== PAUSE TestAccAwsServiceQuotasServiceQuotaDataSource_PermissionError_QuotaName
=== RUN   TestAccAwsServiceQuotasServiceQuota_basic
=== PAUSE TestAccAwsServiceQuotasServiceQuota_basic
=== RUN   TestAccAwsServiceQuotasServiceQuota_Value_IncreaseOnCreate
    resource_aws_servicequotas_service_quota_test.go:52: Environment variable SERVICEQUOTAS_INCREASE_ON_CREATE_QUOTA_CODE is not set. WARNING: This test will submit a real service quota increase!
--- SKIP: TestAccAwsServiceQuotasServiceQuota_Value_IncreaseOnCreate (0.00s)
=== RUN   TestAccAwsServiceQuotasServiceQuota_Value_IncreaseOnUpdate
    resource_aws_servicequotas_service_quota_test.go:94: Environment variable SERVICEQUOTAS_INCREASE_ON_UPDATE_QUOTA_CODE is not set. WARNING: This test will submit a real service quota increase!
--- SKIP: TestAccAwsServiceQuotasServiceQuota_Value_IncreaseOnUpdate (0.00s)
=== RUN   TestAccAwsServiceQuotasServiceQuota_PermissionError
=== PAUSE TestAccAwsServiceQuotasServiceQuota_PermissionError
=== CONT  TestAccAwsServiceQuotasServiceQuotaDataSource_QuotaCode
=== CONT  TestAccAwsServiceQuotasServiceQuota_basic
=== CONT  TestAccAwsServiceQuotasServiceQuotaDataSource_QuotaName
=== CONT  TestAccAwsServiceQuotasServiceQuotaDataSource_PermissionError_QuotaCode
=== CONT  TestAccAwsServiceQuotasServiceQuota_PermissionError
=== CONT  TestAccAwsServiceQuotasServiceQuotaDataSource_PermissionError_QuotaName
    provider_test.go:2222: skipping test; environment variable TF_ACC_ASSUME_ROLE_ARN must be set. Usage: Amazon Resource Name (ARN) of existing IAM Role to assume for testing restricted permissions
--- SKIP: TestAccAwsServiceQuotasServiceQuotaDataSource_PermissionError_QuotaName (1.33s)
=== CONT  TestAccAwsServiceQuotasServiceQuota_PermissionError
    provider_test.go:2222: skipping test; environment variable TF_ACC_ASSUME_ROLE_ARN must be set. Usage: Amazon Resource Name (ARN) of existing IAM Role to assume for testing restricted permissions
--- SKIP: TestAccAwsServiceQuotasServiceQuota_PermissionError (1.37s)
=== CONT  TestAccAwsServiceQuotasServiceQuotaDataSource_PermissionError_QuotaCode
    provider_test.go:2222: skipping test; environment variable TF_ACC_ASSUME_ROLE_ARN must be set. Usage: Amazon Resource Name (ARN) of existing IAM Role to assume for testing restricted permissions
--- SKIP: TestAccAwsServiceQuotasServiceQuotaDataSource_PermissionError_QuotaCode (1.38s)
--- PASS: TestAccAwsServiceQuotasServiceQuotaDataSource_QuotaCode (11.48s)
--- PASS: TestAccAwsServiceQuotasServiceQuotaDataSource_QuotaName (12.28s)
--- PASS: TestAccAwsServiceQuotasServiceQuota_basic (15.84s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	19.013s

GovCloud

% make testacc TEST=./aws TESTARGS='-run=TestAccAwsServiceQuotasServiceQuotaDataSource\|TestAccAwsServiceQuotasServiceQuota'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAwsServiceQuotasServiceQuotaDataSource\|TestAccAwsServiceQuotasServiceQuota -timeout 180m
=== RUN   TestAccAwsServiceQuotasServiceQuotaDataSource_QuotaCode
=== PAUSE TestAccAwsServiceQuotasServiceQuotaDataSource_QuotaCode
=== RUN   TestAccAwsServiceQuotasServiceQuotaDataSource_PermissionError_QuotaCode
=== PAUSE TestAccAwsServiceQuotasServiceQuotaDataSource_PermissionError_QuotaCode
=== RUN   TestAccAwsServiceQuotasServiceQuotaDataSource_QuotaName
=== PAUSE TestAccAwsServiceQuotasServiceQuotaDataSource_QuotaName
=== RUN   TestAccAwsServiceQuotasServiceQuotaDataSource_PermissionError_QuotaName
=== PAUSE TestAccAwsServiceQuotasServiceQuotaDataSource_PermissionError_QuotaName
=== RUN   TestAccAwsServiceQuotasServiceQuota_basic
=== PAUSE TestAccAwsServiceQuotasServiceQuota_basic
=== RUN   TestAccAwsServiceQuotasServiceQuota_Value_IncreaseOnCreate
    resource_aws_servicequotas_service_quota_test.go:52: Environment variable SERVICEQUOTAS_INCREASE_ON_CREATE_QUOTA_CODE is not set. WARNING: This test will submit a real service quota increase!
--- SKIP: TestAccAwsServiceQuotasServiceQuota_Value_IncreaseOnCreate (0.00s)
=== RUN   TestAccAwsServiceQuotasServiceQuota_Value_IncreaseOnUpdate
    resource_aws_servicequotas_service_quota_test.go:94: Environment variable SERVICEQUOTAS_INCREASE_ON_UPDATE_QUOTA_CODE is not set. WARNING: This test will submit a real service quota increase!
--- SKIP: TestAccAwsServiceQuotasServiceQuota_Value_IncreaseOnUpdate (0.00s)
=== RUN   TestAccAwsServiceQuotasServiceQuota_PermissionError
=== PAUSE TestAccAwsServiceQuotasServiceQuota_PermissionError
=== CONT  TestAccAwsServiceQuotasServiceQuotaDataSource_QuotaCode
=== CONT  TestAccAwsServiceQuotasServiceQuota_basic
=== CONT  TestAccAwsServiceQuotasServiceQuotaDataSource_QuotaName
=== CONT  TestAccAwsServiceQuotasServiceQuota_PermissionError
=== CONT  TestAccAwsServiceQuotasServiceQuotaDataSource_PermissionError_QuotaCode
=== CONT  TestAccAwsServiceQuotasServiceQuotaDataSource_PermissionError_QuotaName
=== CONT  TestAccAwsServiceQuotasServiceQuotaDataSource_PermissionError_QuotaCode
    provider_test.go:2222: skipping test; environment variable TF_ACC_ASSUME_ROLE_ARN must be set. Usage: Amazon Resource Name (ARN) of existing IAM Role to assume for testing restricted permissions
--- SKIP: TestAccAwsServiceQuotasServiceQuotaDataSource_PermissionError_QuotaCode (1.86s)
=== CONT  TestAccAwsServiceQuotasServiceQuota_PermissionError
    provider_test.go:2222: skipping test; environment variable TF_ACC_ASSUME_ROLE_ARN must be set. Usage: Amazon Resource Name (ARN) of existing IAM Role to assume for testing restricted permissions
--- SKIP: TestAccAwsServiceQuotasServiceQuota_PermissionError (1.99s)
=== CONT  TestAccAwsServiceQuotasServiceQuotaDataSource_PermissionError_QuotaName
    provider_test.go:2222: skipping test; environment variable TF_ACC_ASSUME_ROLE_ARN must be set. Usage: Amazon Resource Name (ARN) of existing IAM Role to assume for testing restricted permissions
--- SKIP: TestAccAwsServiceQuotasServiceQuotaDataSource_PermissionError_QuotaName (2.00s)
--- PASS: TestAccAwsServiceQuotasServiceQuotaDataSource_QuotaCode (14.89s)
--- PASS: TestAccAwsServiceQuotasServiceQuotaDataSource_QuotaName (16.24s)
--- PASS: TestAccAwsServiceQuotasServiceQuota_basic (20.45s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	23.376s

[github-actions]

This functionality has been released in v3.45.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.