Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

service/ec2: Support Private NAT Gateways #19758

Merged
merged 3 commits into from
Jun 10, 2021

Conversation

ewbankkit
Copy link
Contributor

@ewbankkit ewbankkit commented Jun 10, 2021

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

This release adds a new optional parameter connectivityType (public, private) for the CreateNatGateway API. Private NatGateway does not require customers to attach an InternetGateway to the VPC and can be used for communication with other VPCs and on-premise networks.

Announcement.

Output from acceptance testing:

Commercial

% make testacc TEST=./aws TESTARGS='-run=TestAccAWSNatGateway_\|TestAccDataSourceAwsNatGateway_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSNatGateway_\|TestAccDataSourceAwsNatGateway_ -timeout 180m
=== RUN   TestAccDataSourceAwsNatGateway_basic
=== PAUSE TestAccDataSourceAwsNatGateway_basic
=== RUN   TestAccAWSNatGateway_basic
=== PAUSE TestAccAWSNatGateway_basic
=== RUN   TestAccAWSNatGateway_ConnectivityType_Private
=== PAUSE TestAccAWSNatGateway_ConnectivityType_Private
=== RUN   TestAccAWSNatGateway_tags
=== PAUSE TestAccAWSNatGateway_tags
=== CONT  TestAccDataSourceAwsNatGateway_basic
=== CONT  TestAccAWSNatGateway_tags
=== CONT  TestAccAWSNatGateway_ConnectivityType_Private
=== CONT  TestAccAWSNatGateway_basic
--- PASS: TestAccAWSNatGateway_ConnectivityType_Private (181.42s)
--- PASS: TestAccDataSourceAwsNatGateway_basic (187.93s)
--- PASS: TestAccAWSNatGateway_basic (218.63s)
--- PASS: TestAccAWSNatGateway_tags (263.67s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	266.733s

GovCloud

% make testacc TEST=./aws TESTARGS='-run=TestAccAWSNatGateway_\|TestAccDataSourceAwsNatGateway_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSNatGateway_\|TestAccDataSourceAwsNatGateway_ -timeout 180m
=== RUN   TestAccDataSourceAwsNatGateway_basic
=== PAUSE TestAccDataSourceAwsNatGateway_basic
=== RUN   TestAccAWSNatGateway_basic
=== PAUSE TestAccAWSNatGateway_basic
=== RUN   TestAccAWSNatGateway_ConnectivityType_Private
=== PAUSE TestAccAWSNatGateway_ConnectivityType_Private
=== RUN   TestAccAWSNatGateway_tags
=== PAUSE TestAccAWSNatGateway_tags
=== CONT  TestAccDataSourceAwsNatGateway_basic
=== CONT  TestAccAWSNatGateway_tags
=== CONT  TestAccAWSNatGateway_ConnectivityType_Private
=== CONT  TestAccAWSNatGateway_basic
--- PASS: TestAccDataSourceAwsNatGateway_basic (181.82s)
--- PASS: TestAccAWSNatGateway_ConnectivityType_Private (197.42s)
--- PASS: TestAccAWSNatGateway_basic (213.17s)
--- PASS: TestAccAWSNatGateway_tags (262.52s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	265.552s

Output from acceptance testing:

```
--- PASS: TestAccAWSNatGateway_ConnectivityType_Private (184.75s)
--- PASS: TestAccAWSNatGateway_basic (232.08s)
--- PASS: TestAccAWSNatGateway_tags (253.75s)

--- PASS: TestAccDataSourceAwsNatGateway_basic (181.34s)
```
@ewbankkit ewbankkit requested a review from a team as a code owner June 10, 2021 19:01
@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. service/ec2 Issues and PRs that pertain to the ec2 service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/M Managed by automation to categorize the size of a PR. labels Jun 10, 2021
Copy link
Contributor

@anGie44 anGie44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small q, otherwise LGTM 🚀

@ewbankkit ewbankkit merged commit 8c7c501 into main Jun 10, 2021
@ewbankkit ewbankkit deleted the f-aws_nat_gateway-connectivity_type branch June 10, 2021 19:59
@github-actions github-actions bot added this to the v3.45.0 milestone Jun 10, 2021
github-actions bot pushed a commit that referenced this pull request Jun 10, 2021
@github-actions
Copy link

This functionality has been released in v3.45.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. service/ec2 Issues and PRs that pertain to the ec2 service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants