r/cloudwatch_log_metric_filter - add unit

[DrFaust92]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #19800

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSCloudWatchLogMetricFilter_'
--- PASS: TestAccAWSCloudWatchLogMetricFilter_disappears (38.42s)
--- PASS: TestAccAWSCloudWatchLogMetricFilter_basic (226.30s)
--- PASS: TestAccAWSCloudWatchLogMetricFilter_disappears_logGroup (28.00s)

[ewbankkit]

LGTM 🚀.

Commercial

% make testacc TEST=./aws TESTARGS='-run=TestAccAWSCloudWatchLogMetricFilter_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSCloudWatchLogMetricFilter_ -timeout 180m
=== RUN   TestAccAWSCloudWatchLogMetricFilter_basic
=== PAUSE TestAccAWSCloudWatchLogMetricFilter_basic
=== RUN   TestAccAWSCloudWatchLogMetricFilter_disappears
=== PAUSE TestAccAWSCloudWatchLogMetricFilter_disappears
=== RUN   TestAccAWSCloudWatchLogMetricFilter_disappears_logGroup
=== PAUSE TestAccAWSCloudWatchLogMetricFilter_disappears_logGroup
=== CONT  TestAccAWSCloudWatchLogMetricFilter_basic
=== CONT  TestAccAWSCloudWatchLogMetricFilter_disappears_logGroup
=== CONT  TestAccAWSCloudWatchLogMetricFilter_disappears
--- PASS: TestAccAWSCloudWatchLogMetricFilter_disappears_logGroup (13.09s)
--- PASS: TestAccAWSCloudWatchLogMetricFilter_disappears (15.38s)
--- PASS: TestAccAWSCloudWatchLogMetricFilter_basic (76.04s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	79.514s

GovCloud

% make testacc TEST=./aws TESTARGS='-run=TestAccAWSCloudWatchLogMetricFilter_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSCloudWatchLogMetricFilter_ -timeout 180m
=== RUN   TestAccAWSCloudWatchLogMetricFilter_basic
=== PAUSE TestAccAWSCloudWatchLogMetricFilter_basic
=== RUN   TestAccAWSCloudWatchLogMetricFilter_disappears
=== PAUSE TestAccAWSCloudWatchLogMetricFilter_disappears
=== RUN   TestAccAWSCloudWatchLogMetricFilter_disappears_logGroup
=== PAUSE TestAccAWSCloudWatchLogMetricFilter_disappears_logGroup
=== CONT  TestAccAWSCloudWatchLogMetricFilter_basic
=== CONT  TestAccAWSCloudWatchLogMetricFilter_disappears_logGroup
=== CONT  TestAccAWSCloudWatchLogMetricFilter_disappears
--- PASS: TestAccAWSCloudWatchLogMetricFilter_disappears_logGroup (14.44s)
--- PASS: TestAccAWSCloudWatchLogMetricFilter_disappears (16.96s)
--- PASS: TestAccAWSCloudWatchLogMetricFilter_basic (87.24s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	90.376s

[ewbankkit]

@DrFaust92 Thanks for the contribution 🎉 👏.

[github-actions]

This functionality has been released in v3.46.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[tdmalone]

Getting spurious diffs from this change in the latest version of the provider:

build	18-Jun-2021 08:33:00	  # aws_cloudwatch_log_metric_filter.functionbeat_ingest_failures["cloudwatch-logs"] will be updated in-place
build	18-Jun-2021 08:33:00	  ~ resource "aws_cloudwatch_log_metric_filter" "functionbeat_ingest_failures"
build	18-Jun-2021 08:33:00	
build	18-Jun-2021 08:33:00	      ~ metric_transformation
build	18-Jun-2021 08:33:00	          + unit          = "None"
build	18-Jun-2021 08:33:00	
build	18-Jun-2021 08:33:00	  # aws_cloudwatch_log_metric_filter.functionbeat_ingest_failures["dlq"] will be updated in-place
build	18-Jun-2021 08:33:00	  ~ resource "aws_cloudwatch_log_metric_filter" "functionbeat_ingest_failures"
build	18-Jun-2021 08:33:00	
build	18-Jun-2021 08:33:00	      ~ metric_transformation
build	18-Jun-2021 08:33:00	          + unit          = "None"
build	18-Jun-2021 08:33:00	
build	18-Jun-2021 08:33:00	  # aws_cloudwatch_log_metric_filter.functionbeat_ingest_failures["sqs"] will be updated in-place
build	18-Jun-2021 08:33:00	  ~ resource "aws_cloudwatch_log_metric_filter" "functionbeat_ingest_failures"
build	18-Jun-2021 08:33:00	
build	18-Jun-2021 08:33:00	      ~ metric_transformation
build	18-Jun-2021 08:33:00	          + unit          = "None"
build	18-Jun-2021 08:33:00	
build	18-Jun-2021 08:33:00	Plan: 0 to add, 3 to change, 0 to destroy.

[ewbankkit]

@tdmalone Applying the planned change should cause no difference in functionality as the API Reference states

If you omit this, the unit is set as None.

Before:

After:

Feel free to raise an issue linking to this PR if necessary.
Thanks.

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.