Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/fsx_windows_file_system - add audit_log_configuration #19970

Merged
merged 3 commits into from
Jun 28, 2021

Conversation

DrFaust92
Copy link
Collaborator

@DrFaust92 DrFaust92 commented Jun 25, 2021

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #19793

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSFsxWindowsFileSystem_'
--- PASS: TestAccAWSFsxWindowsFileSystem_auditConfig (1458.07s)

@github-actions github-actions bot added service/fsx Issues and PRs that pertain to the fsx service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/L Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. labels Jun 25, 2021
@DrFaust92 DrFaust92 added the enhancement Requests to existing resources that expand the functionality or scope. label Jun 25, 2021
@DrFaust92 DrFaust92 marked this pull request as ready for review June 25, 2021 21:13
@DrFaust92 DrFaust92 marked this pull request as draft June 26, 2021 14:08
@DrFaust92 DrFaust92 force-pushed the r/fsx_windows_fs_audit branch from 2f04568 to 33559d0 Compare June 26, 2021 21:37
@DrFaust92 DrFaust92 marked this pull request as ready for review June 26, 2021 21:37
DrFaust92 and others added 2 commits June 28, 2021 18:30
Co-authored-by: Kit Ewbank <Kit_Ewbank@hotmail.com>
@DrFaust92
Copy link
Collaborator Author

Amended the typo 🤦

@DrFaust92 DrFaust92 requested a review from ewbankkit June 28, 2021 17:20
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TEST=./aws TESTARGS='-run=TestAccAWSFsxWindowsFileSystem_'                                 
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSFsxWindowsFileSystem_ -timeout 180m
=== RUN   TestAccAWSFsxWindowsFileSystem_basic
=== PAUSE TestAccAWSFsxWindowsFileSystem_basic
=== RUN   TestAccAWSFsxWindowsFileSystem_singleAz2
=== PAUSE TestAccAWSFsxWindowsFileSystem_singleAz2
=== RUN   TestAccAWSFsxWindowsFileSystem_storageTypeHdd
=== PAUSE TestAccAWSFsxWindowsFileSystem_storageTypeHdd
=== RUN   TestAccAWSFsxWindowsFileSystem_multiAz
=== PAUSE TestAccAWSFsxWindowsFileSystem_multiAz
=== RUN   TestAccAWSFsxWindowsFileSystem_disappears
=== PAUSE TestAccAWSFsxWindowsFileSystem_disappears
=== RUN   TestAccAWSFsxWindowsFileSystem_AutomaticBackupRetentionDays
=== PAUSE TestAccAWSFsxWindowsFileSystem_AutomaticBackupRetentionDays
=== RUN   TestAccAWSFsxWindowsFileSystem_CopyTagsToBackups
=== PAUSE TestAccAWSFsxWindowsFileSystem_CopyTagsToBackups
=== RUN   TestAccAWSFsxWindowsFileSystem_DailyAutomaticBackupStartTime
=== PAUSE TestAccAWSFsxWindowsFileSystem_DailyAutomaticBackupStartTime
=== RUN   TestAccAWSFsxWindowsFileSystem_KmsKeyId
=== PAUSE TestAccAWSFsxWindowsFileSystem_KmsKeyId
=== RUN   TestAccAWSFsxWindowsFileSystem_SecurityGroupIds
=== PAUSE TestAccAWSFsxWindowsFileSystem_SecurityGroupIds
=== RUN   TestAccAWSFsxWindowsFileSystem_SelfManagedActiveDirectory
=== PAUSE TestAccAWSFsxWindowsFileSystem_SelfManagedActiveDirectory
=== RUN   TestAccAWSFsxWindowsFileSystem_SelfManagedActiveDirectory_Username
=== PAUSE TestAccAWSFsxWindowsFileSystem_SelfManagedActiveDirectory_Username
=== RUN   TestAccAWSFsxWindowsFileSystem_StorageCapacity
=== PAUSE TestAccAWSFsxWindowsFileSystem_StorageCapacity
=== RUN   TestAccAWSFsxWindowsFileSystem_Tags
=== PAUSE TestAccAWSFsxWindowsFileSystem_Tags
=== RUN   TestAccAWSFsxWindowsFileSystem_ThroughputCapacity
=== PAUSE TestAccAWSFsxWindowsFileSystem_ThroughputCapacity
=== RUN   TestAccAWSFsxWindowsFileSystem_WeeklyMaintenanceStartTime
=== PAUSE TestAccAWSFsxWindowsFileSystem_WeeklyMaintenanceStartTime
=== RUN   TestAccAWSFsxWindowsFileSystem_auditConfig
=== PAUSE TestAccAWSFsxWindowsFileSystem_auditConfig
=== CONT  TestAccAWSFsxWindowsFileSystem_basic
=== CONT  TestAccAWSFsxWindowsFileSystem_SecurityGroupIds
=== CONT  TestAccAWSFsxWindowsFileSystem_ThroughputCapacity
=== CONT  TestAccAWSFsxWindowsFileSystem_Tags
=== CONT  TestAccAWSFsxWindowsFileSystem_auditConfig
=== CONT  TestAccAWSFsxWindowsFileSystem_disappears
=== CONT  TestAccAWSFsxWindowsFileSystem_storageTypeHdd
=== CONT  TestAccAWSFsxWindowsFileSystem_StorageCapacity
=== CONT  TestAccAWSFsxWindowsFileSystem_singleAz2
=== CONT  TestAccAWSFsxWindowsFileSystem_SelfManagedActiveDirectory_Username
=== CONT  TestAccAWSFsxWindowsFileSystem_SelfManagedActiveDirectory
=== CONT  TestAccAWSFsxWindowsFileSystem_multiAz
=== CONT  TestAccAWSFsxWindowsFileSystem_WeeklyMaintenanceStartTime
=== CONT  TestAccAWSFsxWindowsFileSystem_AutomaticBackupRetentionDays
=== CONT  TestAccAWSFsxWindowsFileSystem_KmsKeyId
=== CONT  TestAccAWSFsxWindowsFileSystem_DailyAutomaticBackupStartTime
=== CONT  TestAccAWSFsxWindowsFileSystem_CopyTagsToBackups
--- PASS: TestAccAWSFsxWindowsFileSystem_SelfManagedActiveDirectory (3264.42s)
--- PASS: TestAccAWSFsxWindowsFileSystem_disappears (3446.19s)
--- PASS: TestAccAWSFsxWindowsFileSystem_WeeklyMaintenanceStartTime (3550.71s)
--- PASS: TestAccAWSFsxWindowsFileSystem_basic (3597.00s)
--- PASS: TestAccAWSFsxWindowsFileSystem_DailyAutomaticBackupStartTime (3676.88s)
--- PASS: TestAccAWSFsxWindowsFileSystem_auditConfig (3689.29s)
--- PASS: TestAccAWSFsxWindowsFileSystem_AutomaticBackupRetentionDays (3690.70s)
--- PASS: TestAccAWSFsxWindowsFileSystem_StorageCapacity (3925.09s)
--- PASS: TestAccAWSFsxWindowsFileSystem_ThroughputCapacity (3949.41s)
--- PASS: TestAccAWSFsxWindowsFileSystem_Tags (3979.15s)
--- PASS: TestAccAWSFsxWindowsFileSystem_singleAz2 (4319.90s)
--- PASS: TestAccAWSFsxWindowsFileSystem_storageTypeHdd (4522.83s)
--- PASS: TestAccAWSFsxWindowsFileSystem_SelfManagedActiveDirectory_Username (4575.30s)
--- PASS: TestAccAWSFsxWindowsFileSystem_SecurityGroupIds (4884.61s)
--- PASS: TestAccAWSFsxWindowsFileSystem_multiAz (4937.93s)
--- PASS: TestAccAWSFsxWindowsFileSystem_KmsKeyId (5199.66s)
--- PASS: TestAccAWSFsxWindowsFileSystem_CopyTagsToBackups (5261.80s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	5265.611s

@ewbankkit ewbankkit merged commit f3ccd2a into hashicorp:main Jun 28, 2021
@github-actions github-actions bot added this to the v3.48.0 milestone Jun 28, 2021
@github-actions
Copy link

github-actions bot commented Jul 8, 2021

This functionality has been released in v3.48.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@DrFaust92 DrFaust92 deleted the r/fsx_windows_fs_audit branch July 8, 2021 17:28
@github-actions
Copy link

github-actions bot commented Aug 8, 2021

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/fsx Issues and PRs that pertain to the fsx service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
2 participants