r/fsx_windows_filesystem - support aliases

[DrFaust92]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #16548
Supersedes #16683

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'
--- PASS: TestAccAWSFsxWindowsFileSystem_aliases (2000.94s)

[ewbankkit]

LGTM 🚀.

% make testacc TEST=./aws TESTARGS='-run=TestAccAWSFsxWindowsFileSystem_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSFsxWindowsFileSystem_ -timeout 180m
=== RUN   TestAccAWSFsxWindowsFileSystem_basic
=== PAUSE TestAccAWSFsxWindowsFileSystem_basic
=== RUN   TestAccAWSFsxWindowsFileSystem_singleAz2
=== PAUSE TestAccAWSFsxWindowsFileSystem_singleAz2
=== RUN   TestAccAWSFsxWindowsFileSystem_storageTypeHdd
=== PAUSE TestAccAWSFsxWindowsFileSystem_storageTypeHdd
=== RUN   TestAccAWSFsxWindowsFileSystem_multiAz
=== PAUSE TestAccAWSFsxWindowsFileSystem_multiAz
=== RUN   TestAccAWSFsxWindowsFileSystem_disappears
=== PAUSE TestAccAWSFsxWindowsFileSystem_disappears
=== RUN   TestAccAWSFsxWindowsFileSystem_aliases
=== PAUSE TestAccAWSFsxWindowsFileSystem_aliases
=== RUN   TestAccAWSFsxWindowsFileSystem_AutomaticBackupRetentionDays
=== PAUSE TestAccAWSFsxWindowsFileSystem_AutomaticBackupRetentionDays
=== RUN   TestAccAWSFsxWindowsFileSystem_CopyTagsToBackups
=== PAUSE TestAccAWSFsxWindowsFileSystem_CopyTagsToBackups
=== RUN   TestAccAWSFsxWindowsFileSystem_DailyAutomaticBackupStartTime
=== PAUSE TestAccAWSFsxWindowsFileSystem_DailyAutomaticBackupStartTime
=== RUN   TestAccAWSFsxWindowsFileSystem_KmsKeyId
=== PAUSE TestAccAWSFsxWindowsFileSystem_KmsKeyId
=== RUN   TestAccAWSFsxWindowsFileSystem_SecurityGroupIds
=== PAUSE TestAccAWSFsxWindowsFileSystem_SecurityGroupIds
=== RUN   TestAccAWSFsxWindowsFileSystem_SelfManagedActiveDirectory
=== PAUSE TestAccAWSFsxWindowsFileSystem_SelfManagedActiveDirectory
=== RUN   TestAccAWSFsxWindowsFileSystem_SelfManagedActiveDirectory_Username
=== PAUSE TestAccAWSFsxWindowsFileSystem_SelfManagedActiveDirectory_Username
=== RUN   TestAccAWSFsxWindowsFileSystem_StorageCapacity
=== PAUSE TestAccAWSFsxWindowsFileSystem_StorageCapacity
=== RUN   TestAccAWSFsxWindowsFileSystem_Tags
=== PAUSE TestAccAWSFsxWindowsFileSystem_Tags
=== RUN   TestAccAWSFsxWindowsFileSystem_ThroughputCapacity
=== PAUSE TestAccAWSFsxWindowsFileSystem_ThroughputCapacity
=== RUN   TestAccAWSFsxWindowsFileSystem_WeeklyMaintenanceStartTime
=== PAUSE TestAccAWSFsxWindowsFileSystem_WeeklyMaintenanceStartTime
=== RUN   TestAccAWSFsxWindowsFileSystem_auditConfig
=== PAUSE TestAccAWSFsxWindowsFileSystem_auditConfig
=== CONT  TestAccAWSFsxWindowsFileSystem_basic
=== CONT  TestAccAWSFsxWindowsFileSystem_SecurityGroupIds
=== CONT  TestAccAWSFsxWindowsFileSystem_multiAz
=== CONT  TestAccAWSFsxWindowsFileSystem_KmsKeyId
=== CONT  TestAccAWSFsxWindowsFileSystem_aliases
=== CONT  TestAccAWSFsxWindowsFileSystem_DailyAutomaticBackupStartTime
=== CONT  TestAccAWSFsxWindowsFileSystem_CopyTagsToBackups
=== CONT  TestAccAWSFsxWindowsFileSystem_AutomaticBackupRetentionDays
=== CONT  TestAccAWSFsxWindowsFileSystem_ThroughputCapacity
=== CONT  TestAccAWSFsxWindowsFileSystem_disappears
=== CONT  TestAccAWSFsxWindowsFileSystem_WeeklyMaintenanceStartTime
=== CONT  TestAccAWSFsxWindowsFileSystem_storageTypeHdd
=== CONT  TestAccAWSFsxWindowsFileSystem_singleAz2
=== CONT  TestAccAWSFsxWindowsFileSystem_SelfManagedActiveDirectory_Username
=== CONT  TestAccAWSFsxWindowsFileSystem_SelfManagedActiveDirectory
=== CONT  TestAccAWSFsxWindowsFileSystem_auditConfig
=== CONT  TestAccAWSFsxWindowsFileSystem_Tags
=== CONT  TestAccAWSFsxWindowsFileSystem_StorageCapacity
    resource_aws_fsx_windows_file_system_test.go:602: Step 1/3 error: Error running apply: exit status 1
        2021/07/09 11:42:38 [DEBUG] Using modified User-Agent: Terraform/0.12.31 HashiCorp-terraform-exec/0.14.0
        
        Error: error waiting for Directory Service Directory (d-9267714ac8) to create: unexpected state 'Failed', wanted target 'Active'. last error: An internal service error has been encountered during directory creation. Please retry the operation.
        
          on terraform_plugin_test.tf line 27, in resource "aws_directory_service_directory" "test":
          27: resource "aws_directory_service_directory" "test" {
        
        
--- FAIL: TestAccAWSFsxWindowsFileSystem_StorageCapacity (2701.05s)
--- PASS: TestAccAWSFsxWindowsFileSystem_SelfManagedActiveDirectory (3168.04s)
--- PASS: TestAccAWSFsxWindowsFileSystem_DailyAutomaticBackupStartTime (3289.53s)
--- PASS: TestAccAWSFsxWindowsFileSystem_basic (3376.99s)
--- PASS: TestAccAWSFsxWindowsFileSystem_disappears (3396.80s)
--- PASS: TestAccAWSFsxWindowsFileSystem_WeeklyMaintenanceStartTime (3441.20s)
--- PASS: TestAccAWSFsxWindowsFileSystem_AutomaticBackupRetentionDays (3536.30s)
--- PASS: TestAccAWSFsxWindowsFileSystem_auditConfig (3674.66s)
--- PASS: TestAccAWSFsxWindowsFileSystem_Tags (3678.99s)
--- PASS: TestAccAWSFsxWindowsFileSystem_singleAz2 (3860.68s)
--- PASS: TestAccAWSFsxWindowsFileSystem_storageTypeHdd (4062.78s)
--- PASS: TestAccAWSFsxWindowsFileSystem_aliases (4353.25s)
--- PASS: TestAccAWSFsxWindowsFileSystem_ThroughputCapacity (4509.17s)
--- PASS: TestAccAWSFsxWindowsFileSystem_SelfManagedActiveDirectory_Username (4519.44s)
--- PASS: TestAccAWSFsxWindowsFileSystem_multiAz (4556.42s)
--- PASS: TestAccAWSFsxWindowsFileSystem_KmsKeyId (4966.82s)
--- PASS: TestAccAWSFsxWindowsFileSystem_CopyTagsToBackups (5133.11s)
--- PASS: TestAccAWSFsxWindowsFileSystem_SecurityGroupIds (5234.71s)

The failure is unrelated to this change.

[jeremyciak]

Oh man @DrFaust92 I would have loved to benefit from a bit of education on what you adjusted from my PR and why so I can learn and become a meaningful contributor.

[DrFaust92]

Hi @jeremyciak changes were mostly around testing and adding waiting logic around alias changes. but the core of the logic was you contribution (Thanks Again!)

[github-actions]

This functionality has been released in v3.50.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.