Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EKS - aws_eks_node_group - support for parallel node upgrades #20137

Closed
vikas027 opened this issue Jul 12, 2021 · 5 comments · Fixed by #20250
Closed

EKS - aws_eks_node_group - support for parallel node upgrades #20137

vikas027 opened this issue Jul 12, 2021 · 5 comments · Fixed by #20250
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/eks Issues and PRs that pertain to the eks service.
Milestone

Comments

@vikas027
Copy link

vikas027 commented Jul 12, 2021

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

AWS has recently started supporting upgrades of node group in parallel which shorten the time of node upgrades.

This is how it looks on the EKS node group
2021-07-12_10-05-50

New or Affected Resource(s)

Potential Terraform Configuration

Something like this can be handy

resource "aws_eks_node_group" "node_group" {

node_update_config {
  number = 1
  # or percentage = 50%
}

}

References

@vikas027 vikas027 added the enhancement Requests to existing resources that expand the functionality or scope. label Jul 12, 2021
@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. service/eks Issues and PRs that pertain to the eks service. labels Jul 12, 2021
@ewbankkit
Copy link
Contributor

Looking at the API Reference the new syntax should probably be:

update_config {
  max_unavailable = 3

  max_unavailable_percentage = 25
}

@ewbankkit ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label Jul 12, 2021
@vikas027
Copy link
Author

Sure, @ewbankkit. That makes more sense as it is aligned to the API.

@sylr
Copy link
Contributor

sylr commented Jul 20, 2021

I'm working on it.

@github-actions
Copy link

This functionality has been released in v3.56.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/eks Issues and PRs that pertain to the eks service.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants