Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to set event_bus_name as ARN on EventBridge aws_cloudwatch_event_rule resource. #20312

Closed
wants to merge 28 commits into from

Conversation

FrancescoFucile-CAZ
Copy link
Contributor

@FrancescoFucile-CAZ FrancescoFucile-CAZ commented Jul 26, 2021

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #19234
Closes #8759

Release note for CHANGELOG:

* resource/resource_aws_cloudwatch_event_target: Allow to set event_bus_name as ARN.
* resource/resource_aws_cloudwatch_event_rule: Allow to set event_bus_name as ARN.

Output from acceptance testing:

% make testacc TESTARGS='-run=TestAccAWSCloudWatchEventRule_EventBusArn'         
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSCloudWatchEventRule_EventBusArn -timeout 180m
=== RUN   TestAccAWSCloudWatchEventRule_EventBusArn
=== PAUSE TestAccAWSCloudWatchEventRule_EventBusArn
=== CONT  TestAccAWSCloudWatchEventRule_EventBusArn
--- PASS: TestAccAWSCloudWatchEventRule_EventBusArn (51.80s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       53.926s


% make testacc TESTARGS='-run=TestAccAWSCloudWatchEventTarget_EventBusArn'                                                                
==> Checking that code complies with gofmt requirements... 
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSCloudWatchEventTarget_EventBusArn -timeout 180m
=== RUN   TestAccAWSCloudWatchEventTarget_EventBusArn
=== PAUSE TestAccAWSCloudWatchEventTarget_EventBusArn
=== CONT  TestAccAWSCloudWatchEventTarget_EventBusArn
--- PASS: TestAccAWSCloudWatchEventTarget_EventBusArn (55.62s)
PASS 
ok      github.com/terraform-providers/terraform-provider-aws/aws       58.043s
...

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. dependencies Used to indicate dependency changes. documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/cloudwatchevents tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/M Managed by automation to categorize the size of a PR. labels Jul 26, 2021
@FrancescoFucile-CAZ FrancescoFucile-CAZ changed the title F add arn support for event bus rule and target Allow to set event_bus_name as ARN on EventBridge aws_cloudwatch_event_rule resource. Jul 26, 2021
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @FrancescoFucile-CAZ 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@github-actions github-actions bot added size/L Managed by automation to categorize the size of a PR. and removed size/M Managed by automation to categorize the size of a PR. labels Jul 28, 2021
@github-actions
Copy link

Thank you for your contribution! 🚀

Please note that the CHANGELOG.md file contents are handled by the maintainers during merge. This is to prevent pull request merge conflicts, especially for contributions which may not be merged immediately. Please see the Contributing Guide for additional pull request review items.

Remove any changes to the CHANGELOG.md file and commit them in this pull request to prevent delays with reviewing and potentially merging this pull request.

@github-actions github-actions bot added size/M Managed by automation to categorize the size of a PR. and removed dependencies Used to indicate dependency changes. size/L Managed by automation to categorize the size of a PR. labels Jul 29, 2021
@FrancescoFucile-CAZ FrancescoFucile-CAZ marked this pull request as draft July 29, 2021 14:35
@github-actions github-actions bot added size/L Managed by automation to categorize the size of a PR. and removed size/M Managed by automation to categorize the size of a PR. labels Jul 29, 2021
@FrancescoFucile-CAZ FrancescoFucile-CAZ marked this pull request as ready for review July 29, 2021 16:13
@FrancescoFucile-CAZ FrancescoFucile-CAZ marked this pull request as draft July 30, 2021 14:54
@FrancescoFucile-CAZ FrancescoFucile-CAZ marked this pull request as ready for review August 2, 2021 16:27
@FrancescoFucile-CAZ
Copy link
Contributor Author

FrancescoFucile-CAZ commented Aug 6, 2021

The CI fails on format/linting tests for issues located on files that are not changed by the PR, according to the error logs.
We kindly ask the maintainers to share their opinion on this behaviour, in case they have a better understanding of it.

resource_aws_ecs_capacity_provider_test.go: two format verbs on one line (%[2]q = %[3]q). katbyte/terrafmt#46
resource_aws_efs_file_system_test.go: argument name is format verb and replaced with quoted string. katbyte/terrafmt#47
resource_aws_kms_grant_test.go: argument name is format verb and replaced with quoted string. katbyte/terrafmt#47
resource_aws_quicksight_user_test.go: format verb as resource name (%[1]q). katbyte/terrafmt#48
resource_aws_sns_platform_application_test.go: argument name is format verb and replaced with quoted string.

image

@ewbankkit ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label Aug 18, 2021
@ewbankkit
Copy link
Contributor

@FrancescoFucile-CAZ Thanks for the contribution 🎉 👏.
In order to get this merged for this week's release I used your commits and fixed the merge and terrafmt errors in #20613.

@ewbankkit ewbankkit closed this Aug 18, 2021
@FrancescoFucile-CAZ
Copy link
Contributor Author

@FrancescoFucile-CAZ Thanks for the contribution 🎉 👏.
In order to get this merged for this week's release I used your commits and fixed the merge and terrafmt errors in #20613.

Thank you for taking care of the terrafmt errors and merging. I'm happy my contribution was accepted. 😄

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
4 participants